March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Pass Discard is irrelevant for AttachDiskModel
by Code Review 12 Mar '17

12 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Pass Discard is irrelevant for AttachDiskModel ...................................................................... webadmin: Pass Discard is irrelevant for AttachDiskModel AttachDiskModel is a sub class of AbstractDiskModel, and thus when events like storageDomain_SelectedItemChanged are raised in AttachDiskModel, updatePassDiscardAvailability and updatePassDiscardChangeability are called although Pass Discard is irrelevant for AttachDiskModel. This patch adds an empty override of these methods to AttachDiskModel to solve this problem. Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Bug-Url: https://bugzilla.redhat.com/1430754 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/73924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: eliminate redundant query on clone vm
by Code Review 12 Mar '17

12 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: eliminate redundant query on clone vm ...................................................................... core: eliminate redundant query on clone vm This is a minor cleanup for some not-that-nice code that got in as part of Ic8fbae and introduced a redundant query from the DB. Change-Id: If2cc716606b89a22ead7babc10b887f71f7b1c9a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/73913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2cc716606b89a22ead7babc10b887f71f7b1c9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: change indexing of virtio-scsi io threads to start from 1
by Code Review 12 Mar '17

12 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: change indexing of virtio-scsi io threads to start from 1 ...................................................................... core: change indexing of virtio-scsi io threads to start from 1 Libvirt expects the IO Threads to be indexed from 1, not from 0. For virtio blk it was already implemented correctly in VmInfoBuilderImpl.pinToIoThreads() but the case of virtio-scsi have indexed the threads from 0. Change-Id: Ifa818d31d56cbd8f098620d6bc6598ce6ca5d4ea Bug-Url: https://bugzilla.redhat.com/1366507 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/73879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa818d31d56cbd8f098620d6bc6598ce6ca5d4ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Properly adjust # of usb-controllers in UpdateTemplate...
by Code Review 12 Mar '17

12 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm ...................................................................... core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm The VmDeviceUtils#updateUsbSlots method was not being called in the flows in UpdateVmTemplateCommand and AddVmCommand, which resulted in creation of templates (and consequently also VMs) with incorrect number of usb controllers and thus preventing the VM to be run in some cases. Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430009 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 3 files changed, 21 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Fix NPE when requesting ticket on a down VM
by Code Review 12 Mar '17

12 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix NPE when requesting ticket on a down VM ...................................................................... restapi: Fix NPE when requesting ticket on a down VM When the VM is down, the vm_dynamic-dependent `deriveGraphicsType()` returns null which caused NPE when forwarding to a subresource of a given console type. Fixed by forwarding the null graphics type to the backend where the down VM case is already handled. In order to do this the ticket invocation code was extracted to the Ticketer helper class that encapsulates the single operation and is used both by the old BackendVmResource endpoint and the newer BackendVmGraphicsConsoleResource subresource endpoints. Change-Id: I58250c34a5624f8be39b84e7eed1956dc589d995 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1428863 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java 4 files changed, 51 insertions(+), 47 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/73880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58250c34a5624f8be39b84e7eed1956dc589d995 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: pythonlib: Add mem.py
by Code Review 12 Mar '17

12 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: pythonlib: Add mem.py ...................................................................... packaging: pythonlib: Add mem.py Allow getting total amount of memory Make setup code use that Allow parsing values intended for java -Xm{s,x}value Change-Id: I14bfa4b8165c1b899b82d623e2e0dc3fbea2b1bc Bug-Url: https://bugzilla.redhat.com/1329119 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 60233fbc8fa90d7b1b18a70faf7061f1c59132b6) --- A packaging/pythonlib/ovirt_engine/mem.py M packaging/setup/plugins/ovirt-engine-common/base/system/mem.py 2 files changed, 92 insertions(+), 25 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/73736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14bfa4b8165c1b899b82d623e2e0dc3fbea2b1bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: pythonlib: Require python-dateutil
by Code Review 12 Mar '17

12 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: pythonlib: Require python-dateutil ...................................................................... packaging: pythonlib: Require python-dateutil service.py needs it. Change-Id: Id9443fbd02770355e1ea3e50a36d10c28997e10d Bug-Url: https://bugzilla.redhat.com/1430817 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9443fbd02770355e1ea3e50a36d10c28997e10d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Handle ext tracker 'None' status in set_modified hook
by Code Review 12 Mar '17

12 Mar '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Handle ext tracker 'None' status in set_modified hook ...................................................................... Handle ext tracker 'None' status in set_modified hook The hook checks the external trackers (patches) of the bug, and according to the external tracker 'status' field it checks if the patch is open ('POST') or closed ('MERGED'). The problem is when the user adds manual patch by adding the patch number, the 'status' parameter remain 'None'. Adding some code to query gerrit (if the 'status' == 'None') to get the real status of the patch. Change-Id: I56d37381e7af07a431b69d44b695667ad6a7f9ad Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1235 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/set_modified 1 file changed, 78 insertions(+), 32 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73695 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56d37381e7af07a431b69d44b695667ad6a7f9ad Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SsoExtensionManager type inference
by Code Review 12 Mar '17

12 Mar '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: SsoExtensionManager type inference ...................................................................... core: SsoExtensionManager type inference Change-Id: I1cf0e645a8ec4d8b2c2629d5a87f69b7f3bd60f8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoExtensionsManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cf0e645a8ec4d8b2c2629d5a87f69b7f3bd60f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AuthenticationUtils lambda's parenthesis
by Code Review 10 Mar '17

10 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: AuthenticationUtils lambda's parenthesis ...................................................................... core: AuthenticationUtils lambda's parenthesis Remove redundant parenthesis that just make the code less easy to read. Change-Id: I2588ca29832bdb0a399229c079948e7cef1d9253 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2588ca29832bdb0a399229c079948e7cef1d9253 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0