Change in ovirt-engine[master]: core: Monitor devices only for vms that are already in the db
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Monitor devices only for vms that are already in the db
......................................................................
core: Monitor devices only for vms that are already in the db
Before this fix vm devices hash was stored in an internal cache
for all vms that were reported by vdsm no matter if they were
present in the engine db at the time.
This caused problems with hosted engine vm that was imported
after the device hash was saved in the cache. Since device monitoring
relies on this cache and there was no change in the hash reported
from vdsm and the hash in the cache the devices weren't imported.
This patch allows monitoring caching info only for vms that already
exist in the db and so solves this issue.
Change-Id: Ib011ac5c7f28de7891b0b6e3c09b107679c1ff29
Bug-Url: https://bugzilla.redhat.com/1425108
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/73237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib011ac5c7f28de7891b0b6e3c09b107679c1ff29
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: core: @Inject OvfDataUpdater dependencies
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject OvfDataUpdater dependencies
......................................................................
core: @Inject OvfDataUpdater dependencies
Change-Id: Ib041874dc6049fe97c5d3b2f93327e67dc95e8fd
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdaterTest.java
2 files changed, 16 insertions(+), 13 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/73341
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib041874dc6049fe97c5d3b2f93327e67dc95e8fd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: core: OvfDataUpdater as a BackendService
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: OvfDataUpdater as a BackendService
......................................................................
core: OvfDataUpdater as a BackendService
Turn OvfDataUpdater to a BackendService to reuse the ServiceLoader's
capabilities and remove some boilerplate code.
Change-Id: Ib13fbe1eaf13ccf112056c70e41986811b360585
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdaterTest.java
4 files changed, 13 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73340
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib13fbe1eaf13ccf112056c70e41986811b360585
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk[sdk_4.1]: Update to model 4.1.31 and metamodel 1.1.12
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.1.31 and metamodel 1.1.12
......................................................................
Update to model 4.1.31 and metamodel 1.1.12
The more relevant changes in the new version of the model are the
following:
* Add `auto_storage_select` attribute to the `VmPool` type.
* Move `vnic_profile_mappings` and `reassign_bad_macs` from the
`import` operation to the `register` operation
* Add IPv6 details to the `NicConfiguration` type.
* Add NFS 4.2 support.
The changes in the metamodel aren't relevant for the Python SDK, but it
is good practice to keep it updated to use the latest version.
Change-Id: I652ac019c7723ffcdf8fc98e1c6ed75a119678b3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1425731
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73380
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I652ac019c7723ffcdf8fc98e1c6ed75a119678b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: core: Sort disk order in Libvirt XML by the alias lexonumeri...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Sort disk order in Libvirt XML by the alias lexonumerically
......................................................................
core: Sort disk order in Libvirt XML by the alias lexonumerically
The disk order sent in the Libvirt XML should be ordered lexonumerically
to avoid situations where "Disk10" will come before "Disk2"
Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433
Bug-Url: https://bugzilla.redhat.com/1317490
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73351
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1.1.z]: packaging: setup: Change the SSL protocols supported by Apache
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: Change the SSL protocols supported by Apache
......................................................................
packaging: setup: Change the SSL protocols supported by Apache
This patch removes the support for TLSv1, as well as makes sure the
older SSLv3 protocol is also disabled.
This leaves only the TLSv1.1 and TLSv1.2, which are currently
considered as safe.
Change-Id: Icf8d0cc990ea6c2051f6275435fc9fe309e0fa37
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1388456
(cherry picked from commit 7f43bdf526cdfdc0bfcbe227b434f8275b6b47be)
---
M packaging/setup/ovirt_engine_setup/engine_common/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/ssl.py
2 files changed, 9 insertions(+), 0 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73360
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf8d0cc990ea6c2051f6275435fc9fe309e0fa37
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: packaging: setup: Change the SSL protocols supported by Apache
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: Change the SSL protocols supported by Apache
......................................................................
packaging: setup: Change the SSL protocols supported by Apache
This patch removes the support for TLSv1, as well as makes sure the
older SSLv3 protocol is also disabled.
This leaves only the TLSv1.1 and TLSv1.2, which are currently
considered as safe.
Change-Id: Icf8d0cc990ea6c2051f6275435fc9fe309e0fa37
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1388456
(cherry picked from commit 7f43bdf526cdfdc0bfcbe227b434f8275b6b47be)
---
M packaging/setup/ovirt_engine_setup/engine_common/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/ssl.py
2 files changed, 9 insertions(+), 0 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73359
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf8d0cc990ea6c2051f6275435fc9fe309e0fa37
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: change Discard After Delete logic
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: change Discard After Delete logic
......................................................................
backend: change Discard After Delete logic
Up until now, DAD (Discard After Delete) [1] was not related to Pass
Discard [2], i.e a disk was first discarded before it was deleted only
if its block storage domain's DAD value was true.
That created a situation where a vm disk that had its Pass Discard
enabled was not discarded before it was deleted if its storage domain's
DAD value was disabled. This situation does not make sense because if
the user specifies that he wants "live" discarding (Pass Discard), he
will most likely want to discard the whole disk before it's deleted.
This patch fixes the DAD logic so that a disk will be discarded before
it's deleted if DAD is enabled for its storage domain, or if the same
disk is attached to at least one vm with its Pass Discard enabled.
[1] http://www.ovirt.org/develop/release-management/features/storage/discard-...
[2] http://www.ovirt.org/develop/release-management/features/storage/pass-dis...
Change-Id: I06345cd0cebed0ee4ad9ccc930e978807ab47f11
Bug-Url: https://bugzilla.redhat.com/1427543
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandlerTest.java
2 files changed, 78 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/73348
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06345cd0cebed0ee4ad9ccc930e978807ab47f11
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: generic type of PostDeleteActionHandler::fixParameters
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: generic type of PostDeleteActionHandler::fixParameters
......................................................................
backend: generic type of PostDeleteActionHandler::fixParameters
PostDeleteActionHandler::fixParameters gets a parameters object of type
<T extends StorageDomainIdParametersBase & PostDeleteAction>.
While this is a correct generic type, it can be more specific since all
the parameters that are sent to this handler extend
StoragePoolDomainAndGroupIdBaseVDSCommandParameters, which is a subtype
of StorageDomainIdParametersBase.
Change-Id: Iff6988365db5e237dc736f333711047762dc4967
Bug-Url: https://bugzilla.redhat.com/1427543
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandlerTest.java
2 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/73347
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff6988365db5e237dc736f333711047762dc4967
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in jenkins[master]: Mirror injector: Added support for multiple mirror injection
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Mirror injector: Added support for multiple mirror injection
......................................................................
Mirror injector: Added support for multiple mirror injection
The new upgrade suites have 2 reposync-config.repo files, this patch will
add support for mirror injection to those suites (and any other suites that
may use *.repo files in the future)
Change-Id: Ia7138d4913f36c6394a98cd6be85e22d3e59944c
Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com>
---
M jobs/confs/groovy-scripts/test-ovirt-repo.groovy
M jobs/confs/shell-scripts/system_tests.collect_logs.sh
M jobs/confs/yaml/builders/system_tests_builders.yaml
M scripts/mirror_client.py
4 files changed, 22 insertions(+), 9 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Daniel Belenky: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73146
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7138d4913f36c6394a98cd6be85e22d3e59944c
Gerrit-PatchSet: 7
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months