Change in ovirt-engine[master]: restapi: Set 'filter=true' by default for non admins
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: restapi: Set 'filter=true' by default for non admins
......................................................................
restapi: Set 'filter=true' by default for non admins
The API supports the 'filter' parameter to indicate if results should be
filtered according to the permissions of the user. Due to the way this
is implemented, non admin users need to set this parameter for almost
all operations, as the default value is 'false'. To simplify things for
non admin users, this patch changes the default value to 'true', but
only for non admin users. If the value is explicitly given in a request
it will be honored.
This is a backwards compatibility breaking change, as clients that used
non admin users and did *not* provide explicitly the 'filter' parameter
will start to behave differently. However, this is unlikely, as calls
from non admin users without the 'filter=true' is almost useless. For
those unlikely cases where this may be a problem, the patch also
introduces a new 'ENGINE_API_FILTER_BY_DEFAUL' configuration parameter:
#
# This flags indicates if 'filtering' should be enabled by default for
# users that aren't administartors.
#
ENGINE_API_FILTER_BY_DEFAULT="true"
If it is necessary to revert to the behaviour of previous versions of the
engine, it can be achieved by changing this parameter in a configuration
file inside the '/etc/ovirt-engine/engine.conf.d' directory. For
example:
# echo 'ENGINE_API_FILTER_BY_DEFAULT="true"' > \
/etc/ovirt-engine/engine.conf.d/99-filter-by-default.conf
# systemctl restart ovirt-engine
Change-Id: I14d2e1101c32727f880ca8c82d48eb65fca9b8c2
Bug-Url: https://bugzilla.redhat.com/1420310
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/LocalConfig.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ParametersHelper.java
M packaging/services/ovirt-engine/ovirt-engine.conf.in
4 files changed, 33 insertions(+), 5 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Juan Hernandez: Verified
Daniel Erez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73039
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14d2e1101c32727f880ca8c82d48eb65fca9b8c2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk[master]: Update to model 4.2.6 and metamodel 1.2.2
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.2.6 and metamodel 1.2.2
......................................................................
Update to model 4.2.6 and metamodel 1.2.2
The more relevant changes in the new version of the model are the
following:
* Add `auto_storage_select` attribute to the `VmPool` type.
* Move `vnic_profile_mappings` and `reassign_bad_macs` from the
`import` operation to the `register` operation
* Add `all_content` parameter to snapshots services.
* Add `default_route` value to the `NetworkUsage` enum.
* Add IPv6 details to the `NicConfiguration` type.
* Add NFS 4.2 support.
The changes in the metamodel aren't relevant for the Python SDK, but it
is good practice to keep it updated to use the latest version.
Change-Id: I652ac019c7723ffcdf8fc98e1c6ed75a119678b3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1425731
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I652ac019c7723ffcdf8fc98e1c6ed75a119678b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: core: Introducing UpdateVolumeCommand
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Introducing UpdateVolumeCommand
......................................................................
core: Introducing UpdateVolumeCommand
Added UpdateVolumeCommand that allows to change volume metadata. The
supported metadata that can be changed:
- description of the volume
- volume type (allows to make a leaf volume shared)
- legality (legal/illegal)
- generation
Added UpdateAllTemplateDisksCommand that runs UpdateVolumeCommand on all
disks of a template. This command is designed to be called from
AddVmTemplateCommand and it works only on non-shared volumes of a
template.
Change-Id: Ic5ba999df76507f87767fa5a23278779ce453ffd
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateAllTemplateDisksCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UpdateVolumeCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateAllTemplateDisksParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVolumeCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
5 files changed, 287 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5ba999df76507f87767fa5a23278779ce453ffd
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Make BaseDisk implement Nameable
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Make BaseDisk implement Nameable
......................................................................
core: Make BaseDisk implement Nameable
BaseDisk entity and all it's subclasses are now nameable to allow running
actions that require naming on them, the name will refer to the disk alias
Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386
Related-To: https://bugzilla.redhat.com/1317490
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73354
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Sort disk order in Libvirt XML by the alias lexonumeri...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Sort disk order in Libvirt XML by the alias lexonumerically
......................................................................
core: Sort disk order in Libvirt XML by the alias lexonumerically
The disk order sent in the Libvirt XML should be ordered lexonumerically
to avoid situations where "Disk10" will come before "Disk2"
Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433
Bug-Url: https://bugzilla.redhat.com/1317490
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73355
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Make BaseDisk implement Nameable
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Make BaseDisk implement Nameable
......................................................................
core: Make BaseDisk implement Nameable
BaseDisk entity and all it's subclasses are now nameable to allow running
actions that require naming on them, the name will refer to the disk alias
Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386
Related-To: https://bugzilla.redhat.com/1317490
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73352
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Sort disk order in Libvirt XML by the alias lexonumeri...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Sort disk order in Libvirt XML by the alias lexonumerically
......................................................................
core: Sort disk order in Libvirt XML by the alias lexonumerically
The disk order sent in the Libvirt XML should be ordered lexonumerically
to avoid situations where "Disk10" will come before "Disk2"
Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433
Bug-Url: https://bugzilla.redhat.com/1317490
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73353
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 3 months
Change in ovirt-engine[master]: core: Make BaseDisk implement Nameable
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Make BaseDisk implement Nameable
......................................................................
core: Make BaseDisk implement Nameable
BaseDisk entity and all it's subclasses are now nameable to allow running
actions that require naming on them, the name will refer to the disk alias
Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386
Related-To: https://bugzilla.redhat.com/1317490
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73350
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1.1.z]: webadmin: Enable overflow setting in DisksAllocationView
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Enable overflow setting in DisksAllocationView
......................................................................
webadmin: Enable overflow setting in DisksAllocationView
Enable setting the overflow in the disks table inside DisksAllocationView
and set it to auto in DisksAllocationPopupView which is used for move VM
disks dialog, this will avoid the disks list running over the dialog
buttons in case we are moving more than 8 disks
Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0
Bug-Url: https://bugzilla.redhat.com/1419352
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73374
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Enable overflow setting in DisksAllocationView
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Enable overflow setting in DisksAllocationView
......................................................................
webadmin: Enable overflow setting in DisksAllocationView
Enable setting the overflow in the disks table inside DisksAllocationView
and set it to auto in DisksAllocationPopupView which is used for move VM
disks dialog, this will avoid the disks list running over the dialog
buttons in case we are moving more than 8 disks
Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0
Bug-Url: https://bugzilla.redhat.com/1419352
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months