Change in ovirt-engine[master]: webadmin: Enable overflow setting in DisksAllocationView
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Enable overflow setting in DisksAllocationView
......................................................................
webadmin: Enable overflow setting in DisksAllocationView
Enable setting the overflow in the disks table inside DisksAllocationView
and set it to auto in DisksAllocationPopupView which is used for move VM
disks dialog, this will avoid the disks list running over the dialog
buttons in case we are moving more than 8 disks
Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0
Bug-Url: https://bugzilla.redhat.com/1419352
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73369
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in jenkins[master]: Add ovirt-engine-metrics jobs/conf
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add ovirt-engine-metrics jobs/conf
......................................................................
Add ovirt-engine-metrics jobs/conf
Change-Id: Idf0775e38b6cffb71220b11a074677786213dfa7
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
A jobs/confs/projects/ovirt-engine-metrics/ovirt-engine-metrics_build-artifacts.yaml
A jobs/confs/yaml/scms/ovirt-engine-metrics.yaml
2 files changed, 62 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73154
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf0775e38b6cffb71220b11a074677786213dfa7
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in ovirt-engine[ovirt-engine-4.1]: core: StorageHandlingCommandBase - getEntitiesFromStorageOvf...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: StorageHandlingCommandBase - getEntitiesFromStorageOvfDisk() loop
......................................................................
core: StorageHandlingCommandBase - getEntitiesFromStorageOvfDisk() loop
getEntitiesFromStorageOvfDisk() will enter infinte loop if the
ovfStoreDiskImages list contains only not updated ovf store disks.
This patch changes it to break in that case, avoiding the inifinte loop.
The issue existed since the relevant code was introduced, it was exposed
by https://bugzilla.redhat.com/1412547 which made it occur frequently.
This patch makes the minimal change to solve the issue as it's going
to be backported to the stable branch, more refactors will be made on
the master branch.
Change-Id: I8669fc6a14879456116fb95ea23737f1ff6672a3
Bug-Url: https://bugzilla.redhat.com/1424755
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/73255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8669fc6a14879456116fb95ea23737f1ff6672a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Fixing unexpected UI behavior in the New External ...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fixing unexpected UI behavior in the New External Subnet window
......................................................................
webadmin: Fixing unexpected UI behavior in the New External Subnet window
The elements did not fit in on the panel when dns entries were added,
resulting in elements being visible outside the popup window.
Added a scroll panel.
Also enlarged the window, so that the scrollbars fit in without breaking
the panel layout.
The dns size on the subnet panel was made smaller, so that the +/- buttons
fit in. The other use of ExternalSubnetWidget in the AbstractNetworkPopupView
also looks good with the new size.
Screenshots of affected dialogs:
http://imgur.com/a/mGqaM
Change-Id: I66c8fe243299a46b743370627489ae184952af6b
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1425156
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ExternalSubnetPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/ExternalSubnetWidget.ui.xml
2 files changed, 23 insertions(+), 12 deletions(-)
Approvals:
Marcin Mirecki: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73324
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66c8fe243299a46b743370627489ae184952af6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in jenkins[master]: Revert "ovirt-engine-dashboard: drop fc24 builds and 4.0 and...
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Revert "ovirt-engine-dashboard: drop fc24 builds and 4.0 and 4.1 nightly"
......................................................................
Revert "ovirt-engine-dashboard: drop fc24 builds and 4.0 and 4.1 nightly"
This reverts commit b4214f609b011302376503c53916c10a316908d3.
Missing Fedora 24 jobs for 4.1 release
Change-Id: I2ba9842bd4b62b51e936c43010923017523ca05a
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-dashboard/ovirt-engine-dashboard_standard.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml
3 files changed, 9 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests; Ready for merge
Greg Sheremeta: Looks good to me
--
To view, visit https://gerrit.ovirt.org/73337
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ba9842bd4b62b51e936c43010923017523ca05a
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in ovirt-engine[master]: core: TagsDirectorTest injections
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: core: TagsDirectorTest injections
......................................................................
core: TagsDirectorTest injections
The TagsDirector instance in the test is already annotated with
@InjectMocks, but many of the dependencies are mocked manually.
This patch cleans up the test and allows Mockito to do it's thing
without duplicating its behavior.
Change-Id: I706977cccf822e6c7adac5dd7a68a252d5f15085
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java
1 file changed, 4 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/73111
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I706977cccf822e6c7adac5dd7a68a252d5f15085
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in ovirt-engine[master]: core: Enable TagsDirectorTest#testDirectDescetor
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: core: Enable TagsDirectorTest#testDirectDescetor
......................................................................
core: Enable TagsDirectorTest#testDirectDescetor
testDirectDescetor is an old-style (JUnit 3) test, and is not run in
when using a JUnit 4 runner.
This patch adds the @Test annotation to it to ensure that it's really
run.
Change-Id: I4d4c27ab55ad877ce4a872ea61ef8bd6f3542844
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/73110
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d4c27ab55ad877ce4a872ea61ef8bd6f3542844
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in ovirt-engine[master]: core: Inline TagsDirector#tagDao
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: core: Inline TagsDirector#tagDao
......................................................................
core: Inline TagsDirector#tagDao
The getTagDao() method is a useless getter that only existed so it could
be stubbed away in the test. Since the test now injects a mock dao,
there's no need for it, and it can safely be removed.
Change-Id: I4346fb8a4c38e8de2f4c2d4ff649525afbeb2a31
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/73112
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4346fb8a4c38e8de2f4c2d4ff649525afbeb2a31
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in ovirt-engine[master]: core: Remove TagsDirectorTest logging management
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: core: Remove TagsDirectorTest logging management
......................................................................
core: Remove TagsDirectorTest logging management
Since we use a nop logger, there's no need to manually manage the
test's log file (which, of course, doesn't exist).
Removing it both cleans up the code and speeds up the test a bit by
saving needless OS interactions.
Change-Id: I3eb5c7139a3a03042f85359e2893002fdac089d1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java
1 file changed, 0 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/73109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eb5c7139a3a03042f85359e2893002fdac089d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in ovirt-engine[master]: core: TagsDirectorTest streams
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: core: TagsDirectorTest streams
......................................................................
core: TagsDirectorTest streams
Use streams instead of boiler-plate for loops to clean up the code.
Change-Id: I2fdf7100670fc7c2d4211681ad0fdb3980b2666d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java
1 file changed, 2 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/73113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fdf7100670fc7c2d4211681ad0fdb3980b2666d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months