Change in ovirt-engine[ovirt-engine-4.1]: restapi: disable keepaliveInterval for download image
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: disable keepaliveInterval for download image
......................................................................
restapi: disable keepaliveInterval for download image
Removing keepaliveInterval for download/upload image through the API.
The UploadImageUiInactivityTimeoutInSeconds ConfigValue is irrelevant
for the API as chunk_size is being explicitly specified by the script.
I.e. when the chunk_size is relatively large, a keepalive timeout
might occur, and hence, the download/upload would be paused.
Change-Id: Ie0ce6d9fbecc8d50ca410e678150e717fc166e3d
Bug-Url: https://bugzilla.redhat.com/1414484
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransfersResource.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0ce6d9fbecc8d50ca410e678150e717fc166e3d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: restapi: Set 'filter=true' by default for non admins
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Set 'filter=true' by default for non admins
......................................................................
restapi: Set 'filter=true' by default for non admins
The API supports the 'filter' parameter to indicate if results should be
filtered according to the permissions of the user. Due to the way this
is implemented, non admin users need to set this parameter for almost
all operations, as the default value is 'false'. To simplify things for
non admin users, this patch changes the default value to 'true', but
only for non admin users. If the value is explicitly given in a request
it will be honored.
This is a backwards compatibility breaking change, as clients that used
non admin users and did *not* provide explicitly the 'filter' parameter
will start to behave differently. However, this is unlikely, as calls
from non admin users without the 'filter=true' is almost useless. For
those unlikely cases where this may be a problem, the patch also
introduces a new 'ENGINE_API_FILTER_BY_DEFAUL' configuration parameter:
#
# This flags indicates if 'filtering' should be enabled by default for
# users that aren't administartors.
#
ENGINE_API_FILTER_BY_DEFAULT="true"
If it is necessary to revert to the behaviour of previous versions of the
engine, it can be achieved by changing this parameter in a configuration
file inside the '/etc/ovirt-engine/engine.conf.d' directory. For
example:
# echo 'ENGINE_API_FILTER_BY_DEFAULT="true"' > \
/etc/ovirt-engine/engine.conf.d/99-filter-by-default.conf
# systemctl restart ovirt-engine
Change-Id: I14d2e1101c32727f880ca8c82d48eb65fca9b8c2
Related-To: https://bugzilla.redhat.com/1420310
Bug-Url: https://bugzilla.redhat.com/1427987
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 233e85a1a6ba26ce98a7ea6325c83db4c6abd977)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/LocalConfig.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ParametersHelper.java
M packaging/services/ovirt-engine/ovirt-engine.conf.in
4 files changed, 33 insertions(+), 5 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14d2e1101c32727f880ca8c82d48eb65fca9b8c2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: restapi: Disable filtering by default for non-admin users
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Disable filtering by default for non-admin users
......................................................................
restapi: Disable filtering by default for non-admin users
The previous patch enabled filtering by default for non-admin users,
like in the master branch. But we don't want to do that in the 4.1
branch, as it is a backwards compatibility breaking change. To avoid
that this patch flips the default value from 'true' to 'false'.
Change-Id: I851d04fa0f1f03b326e40f5434896418d24b7f56
Bug-Url: https://bugzilla.redhat.com/1427987
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73397
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I851d04fa0f1f03b326e40f5434896418d24b7f56
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Ignore unsupported Enum values
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Ignore unsupported Enum values
......................................................................
Ignore unsupported Enum values
If Ruby SDK is used with engine which has some new functionality
implemented, which is not supported by Ruby SDK, the Ruby SDK
should ignore those new elements.
For example if new version of API will implement new Enum value for,
RngSource, the old Ruby SDK should ignore this element, and read
only the elements the Ruby SDK understand.
Change-Id: Ice6b822548008ada589e1b78258c1611527a5df6
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 1ebb796edfebc0b9b58840e3a4e640c49b57c93e)
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M sdk/lib/ovirtsdk4/reader.rb
M sdk/spec/cluster_reader_spec.rb
M sdk/spec/vm_reader_spec.rb
4 files changed, 80 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73394
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice6b822548008ada589e1b78258c1611527a5df6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: restapi: disable keepaliveInterval for download image
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: disable keepaliveInterval for download image
......................................................................
restapi: disable keepaliveInterval for download image
Removing keepaliveInterval for download/upload image through the API.
The UploadImageUiInactivityTimeoutInSeconds ConfigValue is irrelevant
for the API as chunk_size is being explicitly specified by the script.
I.e. when the chunk_size is relatively large, a keepalive timeout
might occur, and hence, the download/upload would be paused.
Change-Id: Ie0ce6d9fbecc8d50ca410e678150e717fc166e3d
Bug-Url: https://bugzilla.redhat.com/1414484
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransfersResource.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/73375
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0ce6d9fbecc8d50ca410e678150e717fc166e3d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-ruby[master]: Ignore unsupported Enum values
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Ignore unsupported Enum values
......................................................................
Ignore unsupported Enum values
If Ruby SDK is used with engine which has some new functionality
implemented, which is not supported by Ruby SDK, the Ruby SDK
should ignore those new elements.
For example if new version of API will implement new Enum value for,
RngSource, the old Ruby SDK should ignore this element, and read
only the elements the Ruby SDK understand.
Change-Id: Ice6b822548008ada589e1b78258c1611527a5df6
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M sdk/lib/ovirtsdk4/reader.rb
M sdk/spec/cluster_reader_spec.rb
M sdk/spec/vm_reader_spec.rb
4 files changed, 80 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice6b822548008ada589e1b78258c1611527a5df6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: restapi: support cloud-init IPv6 properties in REST-API
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: support cloud-init IPv6 properties in REST-API
......................................................................
restapi: support cloud-init IPv6 properties in REST-API
Change-Id: If755cb1b81417c92fbcc71818b9aabb1d2d410c7
Bug-Url: https://bugzilla.redhat.com/1330217
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InitializationMapper.java
1 file changed, 44 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/72289
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If755cb1b81417c92fbcc71818b9aabb1d2d410c7
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: engine: populate macPoolId on DC in queries
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: populate macPoolId on DC in queries
......................................................................
engine: populate macPoolId on DC in queries
Polpuplate macPoolId on DC in the following queries:
* GetAllStoragePools
* Search
Change-Id: Ia76a8ca63c2a3aca6c81e5e0c361d780dbf8a4d1
Bug-Url: https://bugzilla.redhat.com/1421434
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DcSingleMacPoolFinder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetAllStoragePoolsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolQueryBase.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/DcSingleMacPoolFinderTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolByIdQueryTest.java
6 files changed, 157 insertions(+), 60 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/73161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia76a8ca63c2a3aca6c81e5e0c361d780dbf8a4d1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1.1.z]: backend: sync luns on live dc upgrade
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: sync luns on live dc upgrade
......................................................................
backend: sync luns on live dc upgrade
When running a live dc upgrade, active storage domains don't get updated
with the latest luns information from vdsm.
Since on new dc versions, it is possible that new information about the
storge domains' luns can be returned from vdsm, this patch synchronizes
these luns as a part of the upgrade process.
Change-Id: I81f9b247c73cffa688e7c2776b0da6fc937710ea
Bug-Url: https://bugzilla.redhat.com/1419327
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 127 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/73338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81f9b247c73cffa688e7c2776b0da6fc937710ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: sync luns on live dc upgrade
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: sync luns on live dc upgrade
......................................................................
backend: sync luns on live dc upgrade
When running a live dc upgrade, active storage domains don't get updated
with the latest luns information from vdsm.
Since on new dc versions, it is possible that new information about the
storge domains' luns can be returned from vdsm, this patch synchronizes
these luns as a part of the upgrade process.
Change-Id: I81f9b247c73cffa688e7c2776b0da6fc937710ea
Bug-Url: https://bugzilla.redhat.com/1419327
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 127 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/73302
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81f9b247c73cffa688e7c2776b0da6fc937710ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months