Change in ovirt-engine[master]: engine: Avoid injection in audit log of VdsManager
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Avoid injection in audit log of VdsManager
......................................................................
engine: Avoid injection in audit log of VdsManager
Since all of the data to be logged is already present at the creating of
the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more efficient
implementation of the AuditLogable.
Change-Id: I45431af770b4ad2682a99639e1e75d569e9166f6
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
1 file changed, 29 insertions(+), 19 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45431af770b4ad2682a99639e1e75d569e9166f6
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: engine: Remove spare injection in FenceVdsVDSCommand
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Remove spare injection in FenceVdsVDSCommand
......................................................................
engine: Remove spare injection in FenceVdsVDSCommand
There is no need to ues injection in AuditLogableBase if all of the data
required for logging the event is already present.
Change-Id: I75fda33b1f40b6314257fec71297be3db86e4281
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76282
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75fda33b1f40b6314257fec71297be3db86e4281
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in jenkins[master]: ost manual: Allow using custom Lago repo URL
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: ost manual: Allow using custom Lago repo URL
......................................................................
ost manual: Allow using custom Lago repo URL
Until now, there was a 'choice' parameter that allowed to use
stable/unstable Lago repository when running OST Manual. Sometimes, it
is useful to test Lago's unmerged PRs against OST.
With the recent addition of 'createrepo' stage in all standard-ci jobs,
for each Lago PR, the exported-artifacts contains a valid yum
repository. This patch removes the 'stable/unstable' option and instead
allows defining a custom Lago Repo URL. If left blank, it will use
whatever is defined in the automation/*.repos files.
Change-Id: Iee732ff5d01e2890f7be757b1616f73d43d1d969
Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
M jobs/confs/yaml/builders/system_tests_builders.yaml
2 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75004
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee732ff5d01e2890f7be757b1616f73d43d1d969
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 11 months
Change in ovirt-engine[master]: engine: Save VM ID as part of event log
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Save VM ID as part of event log
......................................................................
engine: Save VM ID as part of event log
The VM ID is needed to associate the event with a VM.
Change-Id: I2bf7f64579f6ff9823ae2ce6977ceb205930b714
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76258
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bf7f64579f6ff9823ae2ce6977ceb205930b714
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: engine: Save host id as part of the event
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Save host id as part of the event
......................................................................
engine: Save host id as part of the event
The host-id is required to identify the host and to associate it with
relates events. In addition, the former AuditLogableBase can be
replace with the AuditLogableImpl POJO.
Change-Id: Ia54f715749f7d08c2d5a1ff2c78ba3d302336eb4
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpdatesChecker.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76257
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia54f715749f7d08c2d5a1ff2c78ba3d302336eb4
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: engine: Use AuditLogableImpl in CertificationValidityChecker
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use AuditLogableImpl in CertificationValidityChecker
......................................................................
engine: Use AuditLogableImpl in CertificationValidityChecker
Change-Id: I57680de11255d6889362de7cedf5e803c178d957
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76253
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57680de11255d6889362de7cedf5e803c178d957
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: engine: Use AuditLogableImpl in ClusterOperationCommandBase
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use AuditLogableImpl in ClusterOperationCommandBase
......................................................................
engine: Use AuditLogableImpl in ClusterOperationCommandBase
Change-Id: I1a6ca8abe9d0f0c28f95918b118a04fdd024a391
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76254
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a6ca8abe9d0f0c28f95918b118a04fdd024a391
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: engine: Avoid injection in GetVmsFromExternalProviderQuery
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Avoid injection in GetVmsFromExternalProviderQuery
......................................................................
engine: Avoid injection in GetVmsFromExternalProviderQuery
Since all of the data to be logged is already present at the creating of
the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more efficient
implementation of the AuditLogable.
Change-Id: Ie0ee416b3eb339b90e5cb76662241928fadc2cf2
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java
1 file changed, 15 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0ee416b3eb339b90e5cb76662241928fadc2cf2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: engine: Use AuditLogableImpl in VnicProfileHelper
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use AuditLogableImpl in VnicProfileHelper
......................................................................
engine: Use AuditLogableImpl in VnicProfileHelper
Change-Id: I1a0bcc2794a60443c03f26ccc2104bcf45d09c25
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelperTest.java
2 files changed, 7 insertions(+), 6 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a0bcc2794a60443c03f26ccc2104bcf45d09c25
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: engine: Move shared code to interface
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Move shared code to interface
......................................................................
engine: Move shared code to interface
Change-Id: Ia1b7fd7b5e68759487c9735f04a19290637e6b86
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogable.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
2 files changed, 15 insertions(+), 14 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1b7fd7b5e68759487c9735f04a19290637e6b86
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months