August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add firewall type field to cluster
by Code Review 22 Aug '17

22 Aug '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/79846 ) Change subject: core: Add firewall type field to cluster ...................................................................... core: Add firewall type field to cluster This patch add a firewall type to cluster, so we can manage the type of the firewall to be used for all hosts in cluster. Change-Id: I65527ce4a383312fb6085a8045f07d4906161438 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1462811 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/network/DefaultFirewallType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/network/FirewallType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/clusters_sp.sql A packaging/dbscripts/upgrade/04_02_0500_add_firewall_type_to_cluster.sql 10 files changed, 133 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65527ce4a383312fb6085a8045f07d4906161438 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Allow ovirt user to access engine_id_rsa
by Code Review 22 Aug '17

22 Aug '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/80664 ) Change subject: packaging: setup: Allow ovirt user to access engine_id_rsa ...................................................................... packaging: setup: Allow ovirt user to access engine_id_rsa ... so that the engine can use it for ansible. Change-Id: I4c520e63d9cfbae44a9546db1f3d8cb534022f58 Bug-Url: https://bugzilla.redhat.com/1462811 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c520e63d9cfbae44a9546db1f3d8cb534022f58 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: improve nfs storage domain
by Code Review 22 Aug '17

22 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80926 ) Change subject: inventory: improve nfs storage domain ...................................................................... inventory: improve nfs storage domain - Only display the header if we have data available - Add copyright to sql file - put the inner join in one single line Change-Id: Id186d79fe1c366d5f89284e5ed10dbea0d9a2eee Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh M src/inventory_report/produceReport/sqls/storage_domains_nfs_path.sql 2 files changed, 16 insertions(+), 9 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id186d79fe1c366d5f89284e5ed10dbea0d9a2eee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: fix query for mac pools
by Code Review 22 Aug '17

22 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80925 ) Change subject: inventory: fix query for mac pools ...................................................................... inventory: fix query for mac pools There are SQL schema that clusters tablet might exist and not have mac_pool_id. Adding double check. Change-Id: I5f444b6e22a1fb229c36e43cfd4e714f172daa98 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/mac_pools_query_show_data_based_on_datacenter_and_cluster.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f444b6e22a1fb229c36e43cfd4e714f172daa98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: HE - Check if HA is in Global Maint
by Code Review 22 Aug '17

22 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80922 ) Change subject: inventory: HE - Check if HA is in Global Maint ...................................................................... inventory: HE - Check if HA is in Global Maint Change-Id: Ide30c7ce8a318b304b580fcd264717a01aef3369 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks A src/inventory_report/produceReport/sqls/vds_statistics_query_ha_global_maintenance.sql 3 files changed, 54 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide30c7ce8a318b304b580fcd264717a01aef3369 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove unused classes in gwt-common project
by Code Review 22 Aug '17

22 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80910 ) Change subject: webadmin: Remove unused classes in gwt-common project ...................................................................... webadmin: Remove unused classes in gwt-common project Change-Id: I146696ee9c654963b6ed5a228e791e03abf8d4e0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateDiskListModelTable.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolDiskListModelTable.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java 4 files changed, 0 insertions(+), 378 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I146696ee9c654963b6ed5a228e791e03abf8d4e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Add template version in networks Template subtab
by Code Review 22 Aug '17

22 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80594 ) Change subject: webadmin: Add template version in networks Template subtab ...................................................................... webadmin: Add template version in networks Template subtab Add version column, that contains version number for VM template. Change-Id: I1786f6b5c6b718c6a31a4372d8727e4f7aca1526 Signed-off-by: Ales Musil <amusil(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1479779 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileTemplateView.java 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Ales Musil: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1786f6b5c6b718c6a31a4372d8727e4f7aca1526 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: rename css class
by Code Review 22 Aug '17

22 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80765 ) Change subject: webadmin: rename css class ...................................................................... webadmin: rename css class Rename css class 'obrand_list_view_icon' to 'icon-status-panel-container', since it wasn't related to to other obrand classes. Change-Id: I08188ff1dfa102ce396ee9ac2e82148ce9edbd88 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/brands/ovirt-brand/src/main/sass/_branding_common.scss M frontend/brands/ovirt-brand/src/main/sass/_ovirt.scss M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/IconStatusPanel.java 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08188ff1dfa102ce396ee9ac2e82148ce9edbd88 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: Animal Sniffer for Java 8
by Code Review 22 Aug '17

22 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80871 ) Change subject: build: Animal Sniffer for Java 8 ...................................................................... build: Animal Sniffer for Java 8 This patch [re]adds maven-animal-sniffer-plugin to the build process to ensure that methods from JDKs newer than 8 aren't used. This is a defensive measure against developers that use JDK 9 on their development machines inadvertently introduce dependencies on that JDK, which oVirt does not yet support. Change-Id: Ibe7933866ebd441550a41c6154c31d30b79eafc6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe7933866ebd441550a41c6154c31d30b79eafc6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: Bump maven-javadoc-plugin version
by Code Review 22 Aug '17

22 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80880 ) Change subject: build: Bump maven-javadoc-plugin version ...................................................................... build: Bump maven-javadoc-plugin version Defensively bump maven-javadoc-plugin's version in order to support Java 9 in build time. Change-Id: Iab314c6da0466503861e06e833ee84f04dfbba87 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/extensions-api-root/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab314c6da0466503861e06e833ee84f04dfbba87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0