Change in ovirt-engine[master]: packaging: setup: populate SETUP_ATTRS_MODULES early
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79344 )
Change subject: packaging: setup: populate SETUP_ATTRS_MODULES early
......................................................................
packaging: setup: populate SETUP_ATTRS_MODULES early
It used to be populated in STAGE_SETUP.
Move this to STAGE_BOOT, before
SECRETS_FILTERED_FROM_SETUP_ATTRS_MODULES, so that secret keys will be
filtered early.
Change-Id: Ie8bfb95022e0dec328a50cd10f3071265ac3fc31
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/misc.py
M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py
M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/misc.py
4 files changed, 56 insertions(+), 21 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/79344
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8bfb95022e0dec328a50cd10f3071265ac3fc31
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.5-1
by Code Review
>From Lev Veyde <lveyde(a)redhat.com>:
Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/80886 )
Change subject: build: ovirt-live 4.1.5-1
......................................................................
build: ovirt-live 4.1.5-1
Change-Id: I543f58e37536dd6a7e802e7eb906a6815332ce39
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved; Passed CI tests
Sandro Bonazzola: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80886
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I543f58e37536dd6a7e802e7eb906a6815332ce39
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.1
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: Fix typo in method name.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/80864 )
Change subject: core: Fix typo in method name.
......................................................................
core: Fix typo in method name.
Fix typo
Change-Id: I437c9d708aac0f919cba6dd34fb0e9e118166376
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I437c9d708aac0f919cba6dd34fb0e9e118166376
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: missing injection caused NPE in event log
by Code Review
>From Eli Mesika <emesika(a)redhat.com>:
Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/80860 )
Change subject: core: missing injection caused NPE in event log
......................................................................
core: missing injection caused NPE in event log
When trying to dismiss an error (like in the case you try to add a host
to an incompatible dc/cluster version), a NPE is thrown as a result of
a AuditLogBase instance that is created without injecting its members.
This patch handled this problem by populating an AuditLogImpl instance
instead without a need of injection.
Change-Id: Ibe53da55b969962139b43b9701f8c100a2a40306
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1480208
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java
1 file changed, 18 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80860
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe53da55b969962139b43b9701f8c100a2a40306
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: handle HE VM hosting host fencing
by Code Review
>From Eli Mesika <emesika(a)redhat.com>:
Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/79882 )
Change subject: core: handle HE VM hosting host fencing
......................................................................
core: handle HE VM hosting host fencing
The non-responding host is in a fencing flow while the engine VM is
restarted on another machine, the fencing flow did only the <stop>
step from the fencing flow and then the engine VM goes down.
Since in the engine start we look only for host with <non-responding> status ,
this host which is actually in <down> status will not be started.
Proposed solution is to add a is_in_fencing_flow boolean column to vds_dynamic
1) The flag is set at the start of hard fencing flow (stop command) and reset
at the end of the hard fencing flow (start command) when the origin
of those command comes from non-responding host and not manual fencing
2) In the non-responding treatment that occurs on engine start we will take
in account also hosts that have the is_in_fencing_flow
and reset the is_in_fencing_flow flag
3) when the host is UP either by a successful start command or by Host Monitoring,
the is_in_fencing_flow should be rest as well
This will ensure that engine will try to fence hosts that were stuck in the middle
of a fencing flow as a result of engine restart
Change-Id: I8761b52b5ffb4e10875a5b235a4cfc8de6664cf9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1440101
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/startup/recovery/RecoveryStartupBean.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_02_0480_add_vm_dynamic_in_fence_flow.sql
M packaging/dbscripts/vds_sp.sql
13 files changed, 105 insertions(+), 28 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8761b52b5ffb4e10875a5b235a4cfc8de6664cf9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: webadmin: Change message to match new UI
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80866 )
Change subject: webadmin: Change message to match new UI
......................................................................
webadmin: Change message to match new UI
Before this patch, when importing an image from Glance, the text in
the dialog box redirects to the "'Events' or 'Tasks' tabs in the
footer pane", which doesn't exist in the new UI.
Also, the main 'tabs' are called 'content views'.
Change-Id: I8d64089a0c1627c3e70882bdfa7bad9ae6c32cf3
Bug-Url: https://bugzilla.redhat.com/1482451
Signed-off-by: Shani Leviim <sleviim(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Shani Leviim: Verified
--
To view, visit https://gerrit.ovirt.org/80866
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d64089a0c1627c3e70882bdfa7bad9ae6c32cf3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: set vm owner on import vm like on add vm
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/77050 )
Change subject: core: set vm owner on import vm like on add vm
......................................................................
core: set vm owner on import vm like on add vm
In theory, the permission settings on import VM should be similar to that
on add VM. This patch applies what commit I7e814ab0 did for add VM to
import VM, in order to prevent a scenario in which users import VMs and
then lack the required permissions to manage them.
Change-Id: I4a8c63e8a5cce4c313fdeee8e90a8857faca11d0
Bug-Url: https://bugzilla.redhat.com/1451501
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
1 file changed, 33 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/77050
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a8c63e8a5cce4c313fdeee8e90a8857faca11d0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-log-collector[master]: inventory: hypervisor table - add description
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80876 )
Change subject: inventory: hypervisor table - add description
......................................................................
inventory: hypervisor table - add description
Change-Id: Id5608eb300378c2e89e4247bd66f340ea02c4f5a
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80876
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5608eb300378c2e89e4247bd66f340ea02c4f5a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-host-deploy[master]: packaging: setup: Remove unneeded STAGE_BOOT priorities
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79568 )
Change subject: packaging: setup: Remove unneeded STAGE_BOOT priorities
......................................................................
packaging: setup: Remove unneeded STAGE_BOOT priorities
Change-Id: I6588dbaaa207c09758d23be056e39f92cfaff722
Related-To: https://bugzilla.redhat.com/1472325
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-host-deploy.spec.in
M src/plugins/ovirt-host-deploy/core/misc.py
M src/plugins/ovirt-host-mgmt/core/misc.py
3 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/79568
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6588dbaaa207c09758d23be056e39f92cfaff722
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: packaging: setup: Allow marking env keys as secret
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79343 )
Change subject: packaging: setup: Allow marking env keys as secret
......................................................................
packaging: setup: Allow marking env keys as secret
Add a new parameter 'is_secret' to the decorator osetupattrs
used to create "attributed-constants".
Add keys with 'is_secret=True' to LOG_FILTER_KEYS.
Change-Id: Iab8e0807d39f04cd88de78f334d1a0c13231c4b0
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py
A packaging/setup/plugins/ovirt-engine-common/base/core/filter_secrets.py
3 files changed, 72 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/79343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab8e0807d39f04cd88de78f334d1a0c13231c4b0
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month