August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: CpuQosDaoTest to extend BaseGenericDaoTestCase
by Code Review 14 Aug '17

14 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80418 ) Change subject: core: CpuQosDaoTest to extend BaseGenericDaoTestCase ...................................................................... core: CpuQosDaoTest to extend BaseGenericDaoTestCase Make CpuQosDaoTest extend BaseGenericDaoTestCase instead of reimplementing its logic. Change-Id: I4ae28c42ea32fbf8fbf9af65d89e99c82a2b2fcf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/CpuQosDaoTest.java 1 file changed, 31 insertions(+), 60 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ae28c42ea32fbf8fbf9af65d89e99c82a2b2fcf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: list view select highlight
by Code Review 14 Aug '17

14 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80532 ) Change subject: webadmin: list view select highlight ...................................................................... webadmin: list view select highlight - Standard PF hover overrides the color from selection highlight. This patch override that behavior to show the selection color even when hovering Change-Id: I308482257cf8a2a4fe0af707c5873e0d0e385163 Bug-Url: https://bugzilla.redhat.com/1479764 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/patternfly-ovirt.css 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I308482257cf8a2a4fe0af707c5873e0d0e385163 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: Typo: Operational -> Operating
by Code Review 14 Aug '17

14 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80613 ) Change subject: Typo: Operational -> Operating ...................................................................... Typo: Operational -> Operating Change-Id: I1a2b7f00ea0dd16c70e170e07453c027ce1eed86 Signed-off-by: Yaniv Kaul <ykaul(a)redhat.com> Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a2b7f00ea0dd16c70e170e07453c027ce1eed86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Check for images with illegal or locked status
by Code Review 14 Aug '17

14 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80612 ) Change subject: inventory: Check for images with illegal or locked status ...................................................................... inventory: Check for images with illegal or locked status Virtual Machine might contain images with illegal status, lets detect it before the upgrade. Thanks to Gordon Watson for the suggestion and initial SQL. Change-Id: I24c33d1146611ecd76b8b030b8bea8a334a4827f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/images_query_invalid_status.sql 4 files changed, 27 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24c33d1146611ecd76b8b030b8bea8a334a4827f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: Typo: Operational -> Operating
by Code Review 14 Aug '17

14 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80572 ) Change subject: Typo: Operational -> Operating ...................................................................... Typo: Operational -> Operating Change-Id: I1a2b7f00ea0dd16c70e170e07453c027ce1eed86 Signed-off-by: Yaniv Kaul <ykaul(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a2b7f00ea0dd16c70e170e07453c027ce1eed86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: TransferImage - move disk to illegal only on upload fa...
by Code Review 14 Aug '17

14 Aug '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80583 ) Change subject: core: TransferImage - move disk to illegal only on upload failure ...................................................................... core: TransferImage - move disk to illegal only on upload failure Setting image status as ILLEGAL should be done only upon failure of an upload operation. Change-Id: Id0c79d5bb54975a65a738c4b9763da00821a1338 Bug-Url: https://bugzilla.redhat.com/1481115 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0c79d5bb54975a65a738c4b9763da00821a1338 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: TransferImage - rollback only for upload
by Code Review 14 Aug '17

14 Aug '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80582 ) Change subject: core: TransferImage - rollback only for upload ...................................................................... core: TransferImage - rollback only for upload Rollback on TransferImageCommand is relevant only for upload operation. I.e. deletion of the disk upon failure of download should be avoided. Change-Id: I690834d665df7c95a03ce6817f5e9669f621d743 Bug-Url: https://bugzilla.redhat.com/1481115 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80582 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I690834d665df7c95a03ce6817f5e9669f621d743 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: TransferImage - VerifyUntrustedVolume only for upload
by Code Review 14 Aug '17

14 Aug '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80581 ) Change subject: core: TransferImage - VerifyUntrustedVolume only for upload ...................................................................... core: TransferImage - VerifyUntrustedVolume only for upload Invoking VerifyUntrustedVolumeVDSCommand is relevant only when uploading an image. As download is merely a read operation of the image. Change-Id: I87afb16e16b0a83246819be369ffd4c9afcbb8df Bug-Url: https://bugzilla.redhat.com/1481115 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87afb16e16b0a83246819be369ffd4c9afcbb8df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove outdated comment
by Code Review 14 Aug '17

14 Aug '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80466 ) Change subject: core: remove outdated comment ...................................................................... core: remove outdated comment The plugged property is no longer a Boolean and readonly was moved away. Change-Id: If8fbd7fa86c212088a317b0318a93a5034d74f2f Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Benny Zlotnik: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8fbd7fa86c212088a317b0318a93a5034d74f2f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: frontend: Ensure consistent item order with client-side sorting
by Code Review 14 Aug '17

14 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80544 ) Change subject: frontend: Ensure consistent item order with client-side sorting ...................................................................... frontend: Ensure consistent item order with client-side sorting Change-Id: I78320a33a27f560f91a956f3bacb4346e0075b48 Bug-Url: https://bugzilla.redhat.com/1445235 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DefaultModelItemComparator.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SortableColumn.java 4 files changed, 101 insertions(+), 65 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/80544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78320a33a27f560f91a956f3bacb4346e0075b48 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0