Change in ovirt-engine[ovirt-engine-4.1]: core: Release mac addresses on force remove SD.
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged. ( https://gerrit.ovirt.org/80151 )
Change subject: core: Release mac addresses on force remove SD.
......................................................................
core: Release mac addresses on force remove SD.
Release mac addresses from memory once VMs are being removed as part of
the force remove process.
Change-Id: I1dd9751d847cb7d85a9caf30e907dbb47f87da1b
Bug-Url: https://bugzilla.redhat.com/1475272
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ForceRemoveStorageDomainCommand.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80151
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dd9751d847cb7d85a9caf30e907dbb47f87da1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: core: fixing NPE in fencing flow
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged. ( https://gerrit.ovirt.org/80401 )
Change subject: core: fixing NPE in fencing flow
......................................................................
core: fixing NPE in fencing flow
This patch fixed an NPE in fencing flow non-responding-treatment.
Adding a check for NULL resolved the problem.
Change-Id: I70b3e988cdc3392bea05bb58df2f480f73a4112c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1477700
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80401
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70b3e988cdc3392bea05bb58df2f480f73a4112c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: readonly managed gluster volume checkbox
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged. ( https://gerrit.ovirt.org/80437 )
Change subject: webadmin: readonly managed gluster volume checkbox
......................................................................
webadmin: readonly managed gluster volume checkbox
Set the Managed gluster volume checkbox to be readonly
when edit is not allowed
Change-Id: Ia6b83af6f45ddc1a976189c46670e637c478f949
iBug-Url: https://bugzilla.redhat.com/1417558
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Gobinda Das: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Sahina Bose: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80437
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6b83af6f45ddc1a976189c46670e637c478f949
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gobinda Das <godas(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: core: sort disks by boot order before setting scsi address
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged. ( https://gerrit.ovirt.org/80383 )
Change subject: core: sort disks by boot order before setting scsi address
......................................................................
core: sort disks by boot order before setting scsi address
VmInfoBuildUtils -> getVmDeviceUnitMapForScsiDisks:
Sort VM's disks by boot order prior to setting SCSI
address unit. This is done to ensure that a bootable
disk gets an higher priority in unit index of the
SCSI controller.
Change-Id: I9f8a5a45ec284ebe4fcba9596f177d26986afd71
Bug-Url: https://bugzilla.redhat.com/1336708
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
1 file changed, 10 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80383
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f8a5a45ec284ebe4fcba9596f177d26986afd71
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Verify that the VM exists when returning callback
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged. ( https://gerrit.ovirt.org/80421 )
Change subject: core: Verify that the VM exists when returning callback
......................................................................
core: Verify that the VM exists when returning callback
It seems that there are use cases where a merge operation fails, leaving
a step in ACTIVE state in the command_entities table. However, at
some point, the VM is deleted. In this case, i.e. as long as the failed
step is ACTIVE, engine restart fails because we will be looking for a VM
that doesn't exist anymore and failing on NPE. In this patch, a
protective check is added in order not to fail on NPE when restarting
the engine and a warning is added to the log asking the user to cleanup
the command_entities table.
Change-Id: Ia49bd24da914f36f09241feae8875055ea1dd27a
Bug-Url: https://bugzilla.redhat.com/1477042
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/80421
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia49bd24da914f36f09241feae8875055ea1dd27a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: core: move getSortedDisks method to VmInfoBuildUtils
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged. ( https://gerrit.ovirt.org/80382 )
Change subject: core: move getSortedDisks method to VmInfoBuildUtils
......................................................................
core: move getSortedDisks method to VmInfoBuildUtils
Moved 'getSortedDisks' method to VmInfoBuildUtils
for reusability.
Change-Id: Ie539ed68b8b4cf51ffc5c4556f484f74652986c2
Bug-Url: https://bugzilla.redhat.com/1336708
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
2 files changed, 14 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80382
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie539ed68b8b4cf51ffc5c4556f484f74652986c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: core: always clone on import from cfme
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged. ( https://gerrit.ovirt.org/80416 )
Change subject: core: always clone on import from cfme
......................................................................
core: always clone on import from cfme
When importing a VM not as a new entity (i.e., not cloning it), we preserve
its MAC address. This is also the case when the mac address is out of the
MACs pool's range, which leads to unplugged NIC(s) for the imported VM.
As a temporary workaround, we change the import from external URL (i.e.,
only from external provider by CFME at the moment) to always clone the VM,
also when the VM doesn't exist in the system. This way, the MAC addresses
are reallocated during the import process.
Change-Id: I709a0dee90eeade0f7715e3be3242a6ce15e1f65
Bug-Url: https://bugzilla.redhat.com/1437152
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalUrlCommand.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/80416
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I709a0dee90eeade0f7715e3be3242a6ce15e1f65
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-log-collector[master]: inventory: fix network_cluster table check
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80424 )
Change subject: inventory: fix network_cluster table check
......................................................................
inventory: fix network_cluster table check
The column network_cluster.management does not exist in old version
of engine database. This patch use network.description as replacement.
Change-Id: I3a61d8ae1be3f3026cd0bc5517aec7371787fe1f
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/sqls/network_query_cluster_with_non_ovirtmgmt_as_management_network.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a61d8ae1be3f3026cd0bc5517aec7371787fe1f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-log-collector[master]: inventory: Avoid psql warning about global temporary table
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80423 )
Change subject: inventory: Avoid psql warning about global temporary table
......................................................................
inventory: Avoid psql warning about global temporary table
global is deprecated, let's avoid this warning to users, this
message can show in old dbs.
Change-Id: I53d9cd4d7a6a3f91b826302ced8b8ee00284726e
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53d9cd4d7a6a3f91b826302ced8b8ee00284726e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-log-collector[master]: inventory: improvement in displaying and validation
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80420 )
Change subject: inventory: improvement in displaying and validation
......................................................................
inventory: improvement in displaying and validation
This patch move stderr to /dev/null when extracting files
and check if variable ENGINE_CONF_D_10_SETUP_JAVA has value.
Change-Id: I483132a1c5e46ddb72c65eb5314e00948fa40de9
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/unpackHostsSosReports.sh
2 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80420
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I483132a1c5e46ddb72c65eb5314e00948fa40de9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months