August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: Deactivate Vm's disk attachment example
by Code Review 30 Aug '17

30 Aug '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. ( https://gerrit.ovirt.org/80523 ) Change subject: Deactivate Vm's disk attachment example ...................................................................... Deactivate Vm's disk attachment example This patch adds an example that shows how to deactivate a VM's disk attachment by changing its 'active' property from 'True' to 'False'. After finding the relevant VM's disk, its disk attachment is indicated. Change-Id: Iaa74a9acda5111b982c649aab7e074b6b7636aac Signed-off-by: Shani Leviim <sleviim(a)redhat.com> --- A sdk/examples/deactivate_disk_attachment.py 1 file changed, 82 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Shani Leviim: Verified -- To view, visit https://gerrit.ovirt.org/80523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa74a9acda5111b982c649aab7e074b6b7636aac Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Enable additional feature for cluster
by Code Review 30 Aug '17

30 Aug '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80080 ) Change subject: restapi: Enable additional feature for cluster ...................................................................... restapi: Enable additional feature for cluster List features enabled for cluster level and allow enabling/disabling feature for a cluster Change-Id: I8810af40fd33b8afbd429743bf3ac548863e8b00 Bug-Url: https://bugzilla.redhat.com/1477053 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterEnabledFeatureResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterEnabledFeaturesResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterFeatureHelper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterFeatureResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterFeaturesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterLevelResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterFeaturesMapper.java 9 files changed, 407 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/80080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8810af40fd33b8afbd429743bf3ac548863e8b00 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Gobinda <godas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Example for download disk snapshots
by Code Review 30 Aug '17

30 Aug '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. ( https://gerrit.ovirt.org/80921 ) Change subject: Example for download disk snapshots ...................................................................... Example for download disk snapshots Added an example for downloading all disk snapshots of a specified disk (introduced in 4.2). Note - this example will work only after merging the engine patches: https://gerrit.ovirt.org/#/c/80815/ https://gerrit.ovirt.org/#/c/80816/ Change-Id: I4829cdd8e041656e3751c22f2c8cbf78ce9eae79 Bug-Url: https://bugzilla.redhat.com/1483305 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A sdk/examples/download_disk_snapshots.py 1 file changed, 189 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved; Passed CI tests Juan Hernandez: Looks good to me, but someone else must approve Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/80921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4829cdd8e041656e3751c22f2c8cbf78ce9eae79 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Pass plugin type for each external network allocate request.
by Code Review 30 Aug '17

30 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80525 ) Change subject: Pass plugin type for each external network allocate request. ...................................................................... Pass plugin type for each external network allocate request. Plugin type must be passed to vdsm whenever a port is allocated. The plugin type can be used to determine which provider driver will be executed, and allow to have multiple drivers installed. Currently the drivers have no way of knowing which should be handling the nic. This will also fix the problem where the openstacknet driver can not be installed along any of the other external network providers. The openstack driver is checking for plugin type before it decides to run or not to run. With no plugin type, the openstacknet hooks were failing, even if the nic belonged to a different type of provider. Bug-Url: https://bugzilla.redhat.com/1478823 Change-Id: I4f76d4f4e4e087bc88c9412705c168d4e1fa08c7 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java 2 files changed, 2 insertions(+), 12 deletions(-) Approvals: Marcin Mirecki: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80525 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f76d4f4e4e087bc88c9412705c168d4e1fa08c7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: IE numa DnD
by Code Review 29 Aug '17

29 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/81186 ) Change subject: webadmin: IE numa DnD ...................................................................... webadmin: IE numa DnD - Worked around IE being a broken browser for DnD for numa. Change-Id: I17386a85592b67a73ea6fbcdd91eab9499ac890f Bug-Url: https://bugzilla.redhat.com/1450460 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/DragTargetScrollPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/DraggableVirtualNumaPanel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java 3 files changed, 35 insertions(+), 23 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/81186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17386a85592b67a73ea6fbcdd91eab9499ac890f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove no longer needed host_deploy_firewalld_supported
by Code Review 29 Aug '17

29 Aug '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/81009 ) Change subject: core: Remove no longer needed host_deploy_firewalld_supported ...................................................................... core: Remove no longer needed host_deploy_firewalld_supported This parameter for ovirt-host-deploy-firewalld role is no longer needed as we check VDSM version installed on the host within this role and all other conditions passed via this parameter were redundant. Change-Id: Iaaf9e22877daea4d6f393e51eed03ad5dc8f6d88 Bug-Url: https://bugzilla.redhat.com/1462811 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaf9e22877daea4d6f393e51eed03ad5dc8f6d88 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Check for net_config_dirty
by Code Review 29 Aug '17

29 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81027 ) Change subject: inventory: Check for net_config_dirty ...................................................................... inventory: Check for net_config_dirty This patch adds a validation to identify if any hypervisor contain network config in 'dirty' mode and requires persist network. Change-Id: If780e82e0cfb7d8000bd25d609223c3ffc024108 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vds_dynamic_check_for_net_config_dirty.sql 4 files changed, 38 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If780e82e0cfb7d8000bd25d609223c3ffc024108 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Germano Veit Michel <germano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: cast dedicated_vm_for_vds for string_to_array
by Code Review 29 Aug '17

29 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81185 ) Change subject: inventory: cast dedicated_vm_for_vds for string_to_array ...................................................................... inventory: cast dedicated_vm_for_vds for string_to_array Old dbs are more sensitive to type. Change-Id: I212956dd8ac183bf2bfccf1adb90c041c45933e5 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/vms_query_pinned_virtual_machines.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81185 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I212956dd8ac183bf2bfccf1adb90c041c45933e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Add validation to detect missing restore.sql
by Code Review 29 Aug '17

29 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81184 ) Change subject: inventory: Add validation to detect missing restore.sql ...................................................................... inventory: Add validation to detect missing restore.sql Change-Id: If41bb6f50f86491c232cb18d3007ed58ccfc4e60 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/unpackAndPrepareDump.sh 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81184 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If41bb6f50f86491c232cb18d3007ed58ccfc4e60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: change exception log level to debug
by Code Review 29 Aug '17

29 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/81181 ) Change subject: backend: change exception log level to debug ...................................................................... backend: change exception log level to debug When the description of an unregistered disk is not in a JSON format, an exception is thrown by MetadataDiskDescriptionHandler::enrichDiskByJsonDescription. This very long exception with its traceback is logged by GetUnregisteredDiskQuery::executeQueryCommand in warning level, and pollutes the log with unnecessary information for the average user. Therefore, this log level was changed to debug, and a shorter and more informative warning log was added instead. Change-Id: Iee539cd3b45a975f08af77b571ab615193f5cab4 Bug-Url: https://bugzilla.redhat.com/1486293 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDiskQuery.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/81181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee539cd3b45a975f08af77b571ab615193f5cab4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0