Change in ovirt-hosted-engine-ha[master]: Allow only one submonitor of a given type
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/80646 )
Change subject: Allow only one submonitor of a given type
......................................................................
Allow only one submonitor of a given type
When you try to start submonitor of same type,
it will kill previously existing submnitor and
start new one.
https://github.com/oVirt/ovirt-site/pull/1157
Change-Id: I7732d6ecfe16b0d7098c819175361432a104f0d4
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M ovirt-hosted-engine-ha.spec.in
M ovirt_hosted_engine_ha/broker/monitor.py
2 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80646
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7732d6ecfe16b0d7098c819175361432a104f0d4
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in ovirt-hosted-engine-ha[master]: brokerlink: Moved all rpc handlers to the separate class.
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/81014 )
Change subject: brokerlink: Moved all rpc handlers to the separate class.
......................................................................
brokerlink: Moved all rpc handlers to the separate class.
https://github.com/oVirt/ovirt-site/pull/1157
Change-Id: I5c396a13fdfe37a17fc934fb5c232af71520b35d
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/listener.py
1 file changed, 99 insertions(+), 78 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81014
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c396a13fdfe37a17fc934fb5c232af71520b35d
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in ovirt-hosted-engine-ha[master]: broker: Made monitor list stateless
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/81013 )
Change subject: broker: Made monitor list stateless
......................................................................
broker: Made monitor list stateless
As we support only a single storage domain, we do not need
monitor lists to be bounded to several connections.
https://github.com/oVirt/ovirt-site/pull/1157
Change-Id: I8902280ebf61eb7a6fac34878e6ea2e93acd4624
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/listener.py
1 file changed, 3 insertions(+), 42 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81013
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8902280ebf61eb7a6fac34878e6ea2e93acd4624
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in ovirt-hosted-engine-ha[master]: broker: Broker should read storage info from the config.
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/81011 )
Change subject: broker: Broker should read storage info from the config.
......................................................................
broker: Broker should read storage info from the config.
As we do not support multiple storages now, it makes no sense
to accept storage info from the agent. Therefore, broker must be
able to get storage info (and construct relevant objects) on it's own,
using a config file. This also makes set-storage RPC call useless,
so it is removed.
This also removes support for different storage backends in broker,
so FilesystemBackend is not supported anymore.
https://github.com/oVirt/ovirt-site/pull/1157
Change-Id: I7dec5f52689d5051af4e2ec0e56401fd65fa1d6b
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/broker/listener.py
M ovirt_hosted_engine_ha/broker/storage_broker.py
M ovirt_hosted_engine_ha/client/client.py
M ovirt_hosted_engine_ha/env/constants.py.in
M ovirt_hosted_engine_ha/lib/brokerlink.py
6 files changed, 37 insertions(+), 147 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81011
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7dec5f52689d5051af4e2ec0e56401fd65fa1d6b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in ovirt-hosted-engine-ha[master]: rpc: Removed manual function mapping
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/81224 )
Change subject: rpc: Removed manual function mapping
......................................................................
rpc: Removed manual function mapping
xmlrpclib can automatically bind class instances to the
rpc functions, so we do not need to do it manually.
https://github.com/oVirt/ovirt-site/pull/1157
Change-Id: I507aefaf87921d24b882a5d7a425396f9c3cda70
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/listener.py
M ovirt_hosted_engine_ha/lib/brokerlink.py
2 files changed, 11 insertions(+), 29 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81224
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I507aefaf87921d24b882a5d7a425396f9c3cda70
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in ovirt-hosted-engine-ha[master]: storage: Removed VdsmBackend.Device serialization/deserializ...
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/81012 )
Change subject: storage: Removed VdsmBackend.Device serialization/deserialization
......................................................................
storage: Removed VdsmBackend.Device serialization/deserialization
As we do not transfer storage information over RPC calls,
we do not need to support serialization/deserialization of
the storage objects.
https://github.com/oVirt/ovirt-site/pull/1157
Change-Id: If20631b9d24e54d9cea2596ae23d4d65d393de79
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/storage_backends.py
1 file changed, 1 insertion(+), 48 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Andrej Krejcir: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/81012
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If20631b9d24e54d9cea2596ae23d4d65d393de79
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in ovirt-hosted-engine-ha[master]: rpc: Custom made RPC replaced with xmlrpc
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/81083 )
Change subject: rpc: Custom made RPC replaced with xmlrpc
......................................................................
rpc: Custom made RPC replaced with xmlrpc
Broker link was just a home made implementation of
a remote procedure calls. This patch removes BrokerLink
and introduces standard pathing xmlrpc as a replacement.
https://github.com/oVirt/ovirt-site/pull/1157
Change-Id: I28c31844394df7dfe6012d4b8d3421ad8a69a2ab
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1457468
---
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/broker/listener.py
M ovirt_hosted_engine_ha/broker/notifications.py
M ovirt_hosted_engine_ha/broker/storage_broker.py
M ovirt_hosted_engine_ha/client/client.py
M ovirt_hosted_engine_ha/lib/Makefile.am
M ovirt_hosted_engine_ha/lib/brokerlink.py
D ovirt_hosted_engine_ha/lib/brokerlink_test.py
A ovirt_hosted_engine_ha/lib/unixrpc.py
10 files changed, 165 insertions(+), 431 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28c31844394df7dfe6012d4b8d3421ad8a69a2ab
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in ovirt-hosted-engine-ha[master]: rpc: Block on listen
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/81225 )
Change subject: rpc: Block on listen
......................................................................
rpc: Block on listen
To implement safe shutdown procedure, We used (partially)
non-blocking listen call, that returned control back
after each accepted connection. With new RPC we can
safely block in listen forever and initiate shutdown on a signal.
https://github.com/oVirt/ovirt-site/pull/1157
Change-Id: Ieb7b0c4624ea8113720812617355b921ffa01dc8
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/broker.py
M ovirt_hosted_engine_ha/broker/listener.py
2 files changed, 13 insertions(+), 31 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb7b0c4624ea8113720812617355b921ffa01dc8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: fix sort order for event list model.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/81228 )
Change subject: webadmin: fix sort order for event list model.
......................................................................
webadmin: fix sort order for event list model.
- Fixed issue where an order was assigned to events when it
shouldn't have.
Change-Id: Ic3760601f98b2c5970b94d60484df0448e9c996c
Bug-Url: https://bugzilla.redhat.com/1478687
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/81228
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3760601f98b2c5970b94d60484df0448e9c996c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Allow changing external provider on the hosted engine VM
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/81214 )
Change subject: core: Allow changing external provider on the hosted engine VM
......................................................................
core: Allow changing external provider on the hosted engine VM
This allows the HE VM to be maintained by Satellite.
Change-Id: I6b48e5129de780d743c571ec85c5c1aaa8755ec9
Bug-Url: https://bugzilla.redhat.com/1476265
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/81214
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b48e5129de780d743c571ec85c5c1aaa8755ec9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months