Change in ovirt-engine[master]: core: Block adding disks without storage_domain
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80057 )
Change subject: core: Block adding disks without storage_domain
......................................................................
core: Block adding disks without storage_domain
When creating a disk / disk attachment without specifying a storage
domain, an error should be raised and the operation should fail.
The old functionality looks for a storage domain of another disk on
that VM and sets the new disk's storage domain according to it.
Change-Id: I1241b5c88885de1958f1e0754eba9ba8519c0a97
Bug-Url: https://bugzilla.redhat.com/1476744
Signed-off-by: Shani Leviim <sleviim(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
2 files changed, 3 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Shani Leviim: Verified
--
To view, visit https://gerrit.ovirt.org/80057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1241b5c88885de1958f1e0754eba9ba8519c0a97
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: align disks handling with the ovf specification
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79590 )
Change subject: core: align disks handling with the ovf specification
......................................................................
core: align disks handling with the ovf specification
According to the OVF specification, the disks reside in the DiskSection element
and their ovf:diskId does not have to contain a UUID. Adjust OVF reader accordingly.
Change-Id: Id0d3722b2f67f85c14df97a0d9db97901d1ee93e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
1 file changed, 34 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79590
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0d3722b2f67f85c14df97a0d9db97901d1ee93e
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: reduce boilerplate code in ovf handling
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79445 )
Change subject: core: reduce boilerplate code in ovf handling
......................................................................
core: reduce boilerplate code in ovf handling
Change VdsProperties class that contains the constants used for generating
and parsing OVFs to be an interface. That makes the code within OVF
writers and readers easier to read.
Change-Id: I627dae37e1a1500f777cf3231ae12e9d3d2b6912
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/HostedEngineOvfWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
9 files changed, 282 insertions(+), 338 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I627dae37e1a1500f777cf3231ae12e9d3d2b6912
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: apply the formatter to OvfWriter
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79446 )
Change subject: core: apply the formatter to OvfWriter
......................................................................
core: apply the formatter to OvfWriter
Change-Id: I91db0798e0400230477040ab756deb2d44753ed0
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
1 file changed, 10 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/79446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91db0798e0400230477040ab756deb2d44753ed0
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: reduce boilerplate code in ovf writing
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79447 )
Change subject: core: reduce boilerplate code in ovf writing
......................................................................
core: reduce boilerplate code in ovf writing
Introduce another utility method that significantly reduces the #LOC
in OvfWriter.
Change-Id: Ib2b592eeaa52b86034c9c1634e8161e6c04131a0
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlTextWriter.java
2 files changed, 58 insertions(+), 137 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/79447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2b592eeaa52b86034c9c1634e8161e6c04131a0
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: core: better alignment with ovf specification for disks
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79585 )
Change subject: core: better alignment with ovf specification for disks
......................................................................
core: better alignment with ovf specification for disks
The "File" elements in the References section are designed to enable tools
to verify the integrity of the OVF package (OVA). They are supposed to be
minimal. However, we abuse them by adding additional information about the
disk in these elements.
So in order to be better aligned with the specification, this patch changes
the OVF reader to consume that data from the "Disk" elements inside the
"DiskSection" part, without breaking backward compatibility.
Change-Id: Idcbc86decd53d2495b5f8ece78acf52cbef60bc4
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
2 files changed, 60 insertions(+), 32 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/79585
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcbc86decd53d2495b5f8ece78acf52cbef60bc4
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: restapi: Add Link-Following support
by Code Review
>From Ori Liel <oliel(a)redhat.com>:
Ori Liel has submitted this change and it was merged. ( https://gerrit.ovirt.org/79993 )
Change subject: restapi: Add Link-Following support
......................................................................
restapi: Add Link-Following support
Add 'link-following' feature. This feature enables API users
to request references inside an entity to be fully fetched
alonside the entity. For example, to recieve a VM along
with its nics:
GET .../api/vms?follow=nics
Complex usages are possible, with several links/references of
an entity followd, and at several levels of depth, e.g:
GET .../api/vms?follow=disk_attachments.disk,nics
Bug-Url: https//bugzilla.redhat.com/1463633
Change-Id: I67e242b3668612c70acca9e80d0495b87823ae27
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTree.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTreeCrawler.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTreeNode.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/EntityHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ReflectionHelper.java
A backend/manager/modules/restapi/interface/definition/src/test/java/org/ovirt/engine/api/utils/EntityHelperTest.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/ResourceLocator.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/LinkFollower.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/LinksTreeNode.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ParametersHelper.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/utils/LinksTreeNodeTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/LinkFollowerTest.java
M pom.xml
16 files changed, 919 insertions(+), 11 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved; Passed CI tests
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79993
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67e242b3668612c70acca9e80d0495b87823ae27
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: webadmin: added static IDs to action buttons
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80077 )
Change subject: webadmin: added static IDs to action buttons
......................................................................
webadmin: added static IDs to action buttons
Change-Id: I558bb6e193d364b98e6afd4ffc5d0f2a405210c2
Bug-Url: https://bugzilla.redhat.com/1475966
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ActionPanelView.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/80077
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I558bb6e193d364b98e6afd4ffc5d0f2a405210c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
6 years, 8 months
Change in ovirt-engine[master]: webadmin: remove leading >>
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80075 )
Change subject: webadmin: remove leading >>
......................................................................
webadmin: remove leading >>
- PF standards dicate there should be no leading >>, removed
Change-Id: I805ce7353aa3b58fe101a635c3722d5ba2e185a4
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/OvirtBreadCrumbsView.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I805ce7353aa3b58fe101a635c3722d5ba2e185a4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-engine[master]: backend: Added saving/updating of Network Filter Parameter i...
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79608 )
Change subject: backend: Added saving/updating of Network Filter Parameter into backend
......................................................................
backend: Added saving/updating of Network Filter Parameter into backend
Adding and updating of Network Filter Parameter is added to backend to
VmInterface commands to ensure atomicity of saving/editing operation.
In case something goes wrong with saving/editing proccess nothing is
commited to database.
Change-Id: Icc7d8a3afacf760eff35d0d77fa37ba18a8fbbb7
Signed-off-by: Ales Musil <amusil(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1366905
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmNicFilterParameterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmInterfaceParameters.java
4 files changed, 64 insertions(+), 0 deletions(-)
Approvals:
Ales Musil: Verified
Dominik Holler: Looks good to me, but someone else must approve
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79608
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc7d8a3afacf760eff35d0d77fa37ba18a8fbbb7
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ales Musil <amusil(a)redhat.com>
Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months