- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: HE: Store maximum number of vcpus to the OVF file
by rgolan＠redhat.com 13 Jul '16

13 Jul '16

Roy Golan has submitted this change and it was merged. Change subject: HE: Store maximum number of vcpus to the OVF file ...................................................................... HE: Store maximum number of vcpus to the OVF file This patch adds the computed number of vCPUs to the OVF file for VMs. The number can then be used by the hosted engine tooling to request the proper topology from VDSM when starting the hosted engine VM and that in turn should enable CPU hotplug for the VM. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1304387 Change-Id: If48ec31ada5888dc4ed90c30db044a188481fc0c Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCpuCountHelper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 5 files changed, 69 insertions(+), 15 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If48ec31ada5888dc4ed90c30db044a188481fc0c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix validation of pool when adding permission
by juan.hernandez＠redhat.com 13 Jul '16

13 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix validation of pool when adding permission ...................................................................... restapi: Fix validation of pool when adding permission When adding a permission we check that there is an object provided, a data center, a virtual machine, etc. But the validation for the pool uses an incorrect name, "vmpool" instead of "vmPool". As a result the validation always fail, and it is impossible to add a permission for a pool. This patch fixes that issue. Change-Id: I8be122dc6be608f5df85864be50d8faa0032806c Bug-Url: https://bugzilla.redhat.com/1354463 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8be122dc6be608f5df85864be50d8faa0032806c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Description of engine lock structure
by ahadas＠redhat.com 13 Jul '16

13 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Description of engine lock structure ...................................................................... core: Description of engine lock structure JavaDoc only change Change-Id: I54b2452baaf8351e4a6dfdc3d033e138ae856030 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54b2452baaf8351e4a6dfdc3d033e138ae856030 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: prevent floating vms in unknown status
by ahadas＠redhat.com 13 Jul '16

13 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent floating vms in unknown status ...................................................................... core: prevent floating vms in unknown status On non-responsive treatment, update VMs to unknown status only if they run on some host. This check is done in the database level, with the protection of the database lock. This way, if the monitoring has just updated the VM to down state we will not end up with a VM with unknown status and run_on_vds = NULL. This is not the ideal solution but it seems to cover the most problematic scenario and yet simple. Change-Id: I48c205e9228a32822148332af13c89e51cc80afa Bug-Url: https://bugzilla.redhat.com/1354494 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/vms_sp.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48c205e9228a32822148332af13c89e51cc80afa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-dwh: removed fc23 build for 3.6
by sbonazzo＠redhat.com 13 Jul '16

13 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-dwh: removed fc23 build for 3.6 ...................................................................... ovirt-dwh: removed fc23 build for 3.6 fc23 is not supported for dwh 3.6 since it requires java 1.7 Change-Id: Id029abdbbdc891cc0a7b153a86037202d15c6f8b Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M jobs/confs/projects/ovirt-dwh/ovirt-dwh_standard.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Shirly Radco: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id029abdbbdc891cc0a7b153a86037202d15c6f8b Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Extract PCI and IDE limit check from VmCommand to VmVa...
by tnisan＠redhat.com 13 Jul '16

13 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Extract PCI and IDE limit check from VmCommand to VmValidator ...................................................................... core: Extract PCI and IDE limit check from VmCommand to VmValidator Related-To: https://bugzilla.redhat.com/854932 Change-Id: Iea6bbc43c2814897166bec16af6db6ab922505af Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java 9 files changed, 95 insertions(+), 94 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea6bbc43c2814897166bec16af6db6ab922505af Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix validation in PauseVmCommand
by tnisan＠redhat.com 13 Jul '16

13 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix validation in PauseVmCommand ...................................................................... core: Fix validation in PauseVmCommand The validation in PauseVmCommand passed the messages as a parameter to canPauseVm and added the validation error messages if needed to it, since the canPauseVm method is ran from within the command it can: 1. Become private 2. Add the messages directly as per the Engine common practices Related-To: https://bugzilla.redhat.com/854932 Change-Id: Icb5a8fda42fa95fdac0e20fb157859f955c3adec Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PauseVmCommand.java 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59791 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb5a8fda42fa95fdac0e20fb157859f955c3adec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Make ValidationResult contain more than one EngineMessage
by tnisan＠redhat.com 13 Jul '16

13 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Make ValidationResult contain more than one EngineMessage ...................................................................... core: Make ValidationResult contain more than one EngineMessage Related-To: https://bugzilla.redhat.com/854932 Change-Id: If1fec2eeb7c590710129f1293109cd26696c5ff3 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PauseVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/NumaValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/CpuPinningValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ImportValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/IscsiBondValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ValidationResultMatchers.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageConnectionValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageServerConnectionExtensionValidatorTest.java 25 files changed, 157 insertions(+), 130 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1fec2eeb7c590710129f1293109cd26696c5ff3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: persist before validate() only when there is a parent ...
by tnisan＠redhat.com 13 Jul '16

13 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: persist before validate() only when there is a parent with cb ...................................................................... core: persist before validate() only when there is a parent with cb Currently we persist the command entity before the validate() check and on failure the command status is updated to ENDED_WITH_FAILURE. We do that so that When there is a parent command with a callback, it will be able to detect that the child command execution failed on that phase. Additionally, the parent is responsible to clear the command hirerchy. When there is no parent command, the command entity will never be cleared/monitored. In this patch the logic is changed so that the command is persisted before the CDA phase only in case there's a parent with a CB, otherwise it'll be persisted on the execution phase. Change-Id: Iae96cb414677c970c91ef860824d2a5ca981d861 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1352825 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java 2 files changed, 22 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/60575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae96cb414677c970c91ef860824d2a5ca981d861 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: CommandBase - don't update the command entity always
by tnisan＠redhat.com 13 Jul '16

13 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CommandBase - don't update the command entity always ...................................................................... core: CommandBase - don't update the command entity always In change Iae96c executeAction() was changed to only update the command entity if present after the execution. On flows with async tasks a CommandEntity is being created for the root command with special values during the execution, the update done in CommandBase will override those values to different ones. This patch sets the update to be done only on commands with cb/parent command with cb to avoid updating the unneeded entities. Change-Id: I68af8d469ce9f42c8b1230fc4bef23448345b59a Bug-Url: https://bugzilla.redhat.com/1352825 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/60625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68af8d469ce9f42c8b1230fc4bef23448345b59a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0