- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine : Command-coordination: re-acquire engine lock after ...
by mperina＠redhat.com 12 Jul '16

12 Jul '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Command-coordination: re-acquire engine lock after engine restart ...................................................................... engine : Command-coordination: re-acquire engine lock after engine restart CoCo needs to reacquire locks on engine restart for commands executing not managed by async task manager and managed by command callback. Change-Id: Ic6c9a92b3b1d6e151127187c1bdb869931ede45f Bug-Url: https://bugzilla.redhat.com/1226561 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/CommandStatus.java 3 files changed, 31 insertions(+), 8 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6c9a92b3b1d6e151127187c1bdb869931ede45f Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Adding pretty name to OS version format
by tnisan＠redhat.com 12 Jul '16

12 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Adding pretty name to OS version format ...................................................................... core: Adding pretty name to OS version format This patch adds pretty_name to vds_dynamic table and to the data access layer. This field is filled by the VDSM and sent to the engine's VdsBroker which persist it to the database. The pretty name is a friendly representation of the OS release/version and is displayed as a separate field in the UI Host->General->Software sub tab and is also available from the API when getting the host information. Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346782 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0820_add_vds_dynamic_pretty_name.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/vds_sp.sql 15 files changed, 66 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase - don't update the command entity always
by laravot＠redhat.com 12 Jul '16

12 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - don't update the command entity always ...................................................................... core: CommandBase - don't update the command entity always In change Iae96c executeAction() was changed to only update the command entity if present after the execution. On flows with async tasks a CommandEntity is being created for the root command with special values during the execution, the update done in CommandBase will override those values to different ones. This patch sets the update to be done only on commands with cb/parent command with cb to avoid updating the unneeded entities. Change-Id: I68af8d469ce9f42c8b1230fc4bef23448345b59a Bug-Url: https://bugzilla.redhat.com/1352825 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68af8d469ce9f42c8b1230fc4bef23448345b59a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Conflict with python-daemon-2.1.0
by tnisan＠redhat.com 12 Jul '16

12 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Conflict with python-daemon-2.1.0 ...................................................................... core: Conflict with python-daemon-2.1.0 python-daemon-2.1.0 adds 'initgroups' parameter with default value True. That causes subsequential attempt of changing the process GID (in case the prameter is ommitted), which fails on insufficient privileges. This patch is an alternative approach to patch #58635 Change-Id: Icda9de9f58d0469f4217f12ddcfe40a7d56fab96 Bug-Url: https://bugzilla.redhat.com/1343155 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda9de9f58d0469f4217f12ddcfe40a7d56fab96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: builders: stop publish fc22 artifacts
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: builders: stop publish fc22 artifacts ...................................................................... builders: stop publish fc22 artifacts Avoid to publish fedora 22 artifacts after EOL. Change-Id: I2bb039c9983583235f4979d7e05695a35232788e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/builders/copy-create-job-artifact.yaml 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bb039c9983583235f4979d7e05695a35232788e Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: ovirt-hosted-engine-setup-2.0.1
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-2.0.1 ...................................................................... build: ovirt-hosted-engine-setup-2.0.1 Change-Id: I8c957bfe6f127aa9562086a0d2c596f1f8ce9d34 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 13 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c957bfe6f127aa9562086a0d2c596f1f8ce9d34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove msg of Native USB on clusters < 3.2
by tjelinek＠redhat.com 12 Jul '16

12 Jul '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: remove msg of Native USB on clusters < 3.2 ...................................................................... webadmin: remove msg of Native USB on clusters < 3.2 This patch removed the following warning message appeared in New/Edit VM dialog, Console tab, while selecting USB Support to be "Native": "Migration is NOT currently supported using SPICE Native USB redirection on cluster version lower than 3.2". This message is no longer relevant on version 4.0.1 as the lowest supported cluster version is 3.6. Change-Id: I959f5c4e44c686d5e4d30d11cfff834b44b55e78 Bug-Url: https://bugzilla.redhat.com/1351200 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 4 files changed, 0 insertions(+), 35 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/60484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I959f5c4e44c686d5e4d30d11cfff834b44b55e78 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.0.z]: build: ovirt-hosted-engine-ha-2.0.1
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-2.0.1 ...................................................................... build: ovirt-hosted-engine-ha-2.0.1 Change-Id: I1f660956aaa3b80a753b62fc41dadfb6fcf17e0c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f660956aaa3b80a753b62fc41dadfb6fcf17e0c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.0.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract numa-statistics from vm-statistics
by ahadas＠redhat.com 12 Jul '16

12 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract numa-statistics from vm-statistics ...................................................................... core: extract numa-statistics from vm-statistics VM numa nodes resided in VmStatistics but were not persisted to the database. This patch changes this: 1. The nodes that are reported by VDSM are now stored in VdsmVm instead 2. The nodes were not persisted but they are expected to be used in the future so as a preparation for that, they are stored in VmAnalyzer and a getter was added in order to be able to fetch it in VmsMonitoring. Change-Id: I487e8507f3642f6274451d4d184461514d7e7e33 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java 5 files changed, 32 insertions(+), 29 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I487e8507f3642f6274451d4d184461514d7e7e33 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Yamlize the coverity_analysis job
by eedri＠redhat.com 12 Jul '16

12 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: Yamlize the coverity_analysis job ...................................................................... Yamlize the coverity_analysis job Change-Id: Ib6da53dc040922bfb3a0debf6cdef1109082121d Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A jobs/confs/shell-scripts/coverity_analysis.sh A jobs/confs/yaml/jobs/ovirt-engine_master_coverity-analysis.yaml 2 files changed, 71 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6da53dc040922bfb3a0debf6cdef1109082121d Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0