- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: rename VmInternalData
by ahadas＠redhat.com 06 Jul '16

06 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: rename VmInternalData ...................................................................... core: rename VmInternalData VmInternalData -> VdsmVm Change-Id: I7a41ac5ecc642dc9dc2072ff09c5491423925d57 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VdsmVm.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcherTest.java 15 files changed, 109 insertions(+), 109 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60226 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a41ac5ecc642dc9dc2072ff09c5491423925d57 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "packaging: Add Hosted Engine VM detection"
by sbonazzo＠redhat.com 06 Jul '16

06 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "packaging: Add Hosted Engine VM detection" ...................................................................... Revert "packaging: Add Hosted Engine VM detection" This reverts commit 99f0d1d39ee8709f8b77a36fcf36e1a9be40eaba. The patch is failing on non-hosted engine systems. Change-Id: Ibb8431f617726dab0c201b4e3c5ef5777419575b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py D packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/he.py 3 files changed, 0 insertions(+), 122 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb8431f617726dab0c201b4e3c5ef5777419575b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactor VmInternalData
by ahadas＠redhat.com 06 Jul '16

06 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refactor VmInternalData ...................................................................... core: refactor VmInternalData Replace all constructors with one constructor that receives the notification time. All other arguments should be set with setter methods. This simplifies the instanciation of this class. In addition, statically import the methods in VdsBrokerObjectsBuilder that are used in VmStatsVdsBrokerCommand and in ListVDSCommand in order to make it more readable. Change-Id: Iceeacc97412fdba7bb54d1d1c4139d800a45528a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java 5 files changed, 49 insertions(+), 51 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iceeacc97412fdba7bb54d1d1c4139d800a45528a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Fix size calculation when zeroing VDSM volumes
by sbonazzo＠redhat.com 06 Jul '16

06 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix size calculation when zeroing VDSM volumes ...................................................................... Fix size calculation when zeroing VDSM volumes Instead of os.stat().st_size, which works only on regular files, open the file and seek to the end. Change-Id: Ibfba9c165983e6b36dacdff844960827bbe57995 Bug-Url: https://bugzilla.redhat.com/1346341 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/59241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfba9c165983e6b36dacdff844960827bbe57995 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: packaging: setup: Add Cockpit to firewall
by sbonazzo＠redhat.com 06 Jul '16

06 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Add Cockpit to firewall ...................................................................... packaging: setup: Add Cockpit to firewall Change-Id: I2795e821e761cbb5511b18e86410090fea7dc098 Bug-Url: https://bugzilla.redhat.com/1335426 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 2ade86b901a4a3b7a3d0b8db3570b33ed79c976e) --- M src/plugins/gr-he-setup/network/firewall.py M templates/Makefile.am A templates/hosted-cockpit.xml.in 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/60263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2795e821e761cbb5511b18e86410090fea7dc098 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: hosted-engine: prevent a race cond. between ha-agent and vdsm
by stirabos＠redhat.com 06 Jul '16

06 Jul '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: hosted-engine: prevent a race cond. between ha-agent and vdsm ...................................................................... hosted-engine: prevent a race cond. between ha-agent and vdsm Without this, host-deploy will first start ovirt-ha-agent that will bring up vdsm due to systemd dependencies but, just after that, host-deploy will (re)start vdsm. If ovirt-ha-agent is not quick enough, vdsm will be restarted in the middle of connectStorageServer that will not complete, because vdsm was stopped and does not continue such operations upon restart. On the other side, the timeout waiting for connectStorageServer to be completed is pretty long (900 seconds) so ovirt-ha-agent will take a lot of time to realize the issue. In the mean time, ovirt-ha-broker will fail accessing the shared storage and vdsm get the error and reports back a bad status to the engine and so adding the host from the webui could fail if ovirt-ha-agent is not fast enough. Reversing the start order of vdsm and ovirt-ha-agent will prevent this since ovirt-ha-agnet has Wants=vdsmd.service and After=vdsmd.service and both are met. Change-Id: I2e5dd0cb3c6cbfec00286b063558d379ade1def4 Bug-Url: https://bugzilla.redhat.com/1349532 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-common/hosted-engine/packages.py M src/plugins/ovirt-host-deploy/vdsm/packages.py 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e5dd0cb3c6cbfec00286b063558d379ade1def4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Add Hosted Engine VM detection
by sbonazzo＠redhat.com 06 Jul '16

06 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Add Hosted Engine VM detection ...................................................................... packaging: Add Hosted Engine VM detection Add code to detect if we're running under Hosted Engine VM and abort the setup if the system is not currently in the Global Maintenance mode. An override key of 'OVESETUP_CONFIG/continueSetupOnHEVM' was added to allow skipping this test. Change-Id: I67d487c03f6791c3700f631977e6b4b4601f9f30 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1290073 --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/he.py 3 files changed, 122 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67d487c03f6791c3700f631977e6b4b4601f9f30 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Add Cockpit to firewall
by sbonazzo＠redhat.com 06 Jul '16

06 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Add Cockpit to firewall ...................................................................... packaging: setup: Add Cockpit to firewall Change-Id: I2795e821e761cbb5511b18e86410090fea7dc098 Bug-Url: https://bugzilla.redhat.com/1335426 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/gr-he-setup/network/firewall.py M templates/Makefile.am A templates/hosted-cockpit.xml.in 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified Ryan Barry: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2795e821e761cbb5511b18e86410090fea7dc098 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Conflict with python-daemon-2.1.0
by sbonazzo＠redhat.com 06 Jul '16

06 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Conflict with python-daemon-2.1.0 ...................................................................... core: Conflict with python-daemon-2.1.0 python-daemon-2.1.0 adds 'initgroups' parameter with default value True. That causes subsequential attempt of changing the process GID (in case the prameter is ommitted), which fails on insufficient privileges. This patch is an alternative approach to patch #58635 Change-Id: Icda9de9f58d0469f4217f12ddcfe40a7d56fab96 Bug-Url: https://bugzilla.redhat.com/1343155 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda9de9f58d0469f4217f12ddcfe40a7d56fab96 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Allow passing of scheduling policy name for Update ...
by dfediuck＠redhat.com 06 Jul '16

06 Jul '16

Doron Fediuck has submitted this change and it was merged. Change subject: restapi: Allow passing of scheduling policy name for Update Cluster ...................................................................... restapi: Allow passing of scheduling policy name for Update Cluster This patch will enable auto-completion for the scheduling policy name in the SDK. Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1315657 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Doron Fediuck: Passed CI tests Roy Golan: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0