- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Update to model 4.1.5 and metamodel 1.1.1
by juan.hernandez＠redhat.com 08 Jul '16

08 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update to model 4.1.5 and metamodel 1.1.1 ...................................................................... Update to model 4.1.5 and metamodel 1.1.1 The most relevant change in this version of the model is that the virtual machine and template "disks" collection has been replaced by the concept of "disk attachments", so the examples need to be modified accordingly. Change-Id: I13c6c4eebb92ef5758b972d7362586529d743c67 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml M sdk/examples/add_vm_disk.rb M sdk/examples/follow_vm_links.rb M sdk/examples/list_vm_disks.rb M sdk/lib/ovirtsdk4/http.rb M sdk/spec/connection_use_spec.rb M sdk/spec/vm_spec.rb 7 files changed, 42 insertions(+), 37 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c6c4eebb92ef5758b972d7362586529d743c67 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Clear the POST body before sending requests
by juan.hernandez＠redhat.com 08 Jul '16

08 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Clear the POST body before sending requests ...................................................................... Clear the POST body before sending requests Currently the SDK doesn't clear the cURL POST body before sending requests, as a result the body of a previous POST request can interfere with a current GET request, causing an error in the server side. This patch changes the SDK so that the POST body is cleared before every request. Change-Id: I9df5a89dec28f4f252dc99fcc774ede017707d30 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 98f40972498e13c11c1c20e2c07ad8ae02f862b7) --- M sdk/lib/ovirtsdk4/http.rb 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9df5a89dec28f4f252dc99fcc774ede017707d30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Use type name as the tag for method parameters
by juan.hernandez＠redhat.com 08 Jul '16

08 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use type name as the tag for method parameters ...................................................................... Use type name as the tag for method parameters Currently the name of the XML tag used to represent the input parameters of methods like "add" is the name of the parameter as described in the model. For example, for the operation to add a disk attachment the name of the parameter is "attachment", so the XML document generated and sent by the SDK is something like this: <attachment> ... </attachment> But the server doesn't expect this, it expects the name the XML tag corresponding to the type of the parameter, in this case this case "DiskAttachment", so the server expects the following: <disk_attachment> ... </disk_attachment> It would be more correct to use the name of the parameter, as described in the model, but it isn't factible to introduce such change in the server side at this point, so we need to change the SDK to generate what the server expects. That is what this patch does. In the future, we will probably change the server so that it ignores the root tag of the documents, then this patch can be reverted. Change-Id: I2861cf05cb0a39a7f2bdbbafb72dcf0e3b56823d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 52b7ff98ed4555019db93476afd03cd95a937bd7) --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2861cf05cb0a39a7f2bdbbafb72dcf0e3b56823d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: replace f23 with f24 builds
by eedri＠redhat.com 08 Jul '16

08 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: replace f23 with f24 builds ...................................................................... replace f23 with f24 builds - fixing 4.0 publisher - fixing master publisher Change-Id: Ib0c424a99fee4bbbe3cdd50461f8a0d3a1c707fe Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 2 files changed, 16 insertions(+), 10 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0c424a99fee4bbbe3cdd50461f8a0d3a1c707fe Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: db upgrade scripts must be unique
by piotr.kliczewski＠gmail.com 08 Jul '16

08 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: db upgrade scripts must be unique ...................................................................... core: db upgrade scripts must be unique Change-Id: Ice0119cb2203f3c32f2e32ced5e6a0935d7bee6a Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- R packaging/dbscripts/upgrade/04_00_0810_remove_hosted_engine_storage_domain_name_config_value.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice0119cb2203f3c32f2e32ced5e6a0935d7bee6a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-sdk-ruby[master]: Clear the POST body before sending requests
by juan.hernandez＠redhat.com 08 Jul '16

08 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Clear the POST body before sending requests ...................................................................... Clear the POST body before sending requests Currently the SDK doesn't clear the cURL POST body before sending requests, as a result the body of a previous POST request can interfere with a current GET request, causing an error in the server side. This patch changes the SDK so that the POST body is cleared before every request. Change-Id: I9df5a89dec28f4f252dc99fcc774ede017707d30 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/http.rb 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9df5a89dec28f4f252dc99fcc774ede017707d30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use type name as the tag for method parameters
by juan.hernandez＠redhat.com 08 Jul '16

08 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use type name as the tag for method parameters ...................................................................... Use type name as the tag for method parameters Currently the name of the XML tag used to represent the input parameters of methods like "add" is the name of the parameter as described in the model. For example, for the operation to add a disk attachment the name of the parameter is "attachment", so the XML document generated and sent by the SDK is something like this: <attachment> ... </attachment> But the server doesn't expect this, it expects the name the XML tag corresponding to the type of the parameter, in this case this case "DiskAttachment", so the server expects the following: <disk_attachment> ... </disk_attachment> It would be more correct to use the name of the parameter, as described in the model, but it isn't factible to introduce such change in the server side at this point, so we need to change the SDK to generate what the server expects. That is what this patch does. In the future, we will probably change the server so that it ignores the root tag of the documents, then this patch can be reverted. Change-Id: I2861cf05cb0a39a7f2bdbbafb72dcf0e3b56823d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2861cf05cb0a39a7f2bdbbafb72dcf0e3b56823d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Use the hosted storage domain id instead of name when ...
by piotr.kliczewski＠gmail.com 08 Jul '16

08 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Use the hosted storage domain id instead of name when importing it ...................................................................... core: Use the hosted storage domain id instead of name when importing it When importing hosted storage domain the system relied on a hardcoded name: "hosted_storage". Instead of using that constant to find and import the domain the code is now using the domain id that is reported by vdsm in the vm data. The system verifies that a hosted engine VM is running on a storage domain to determine if that domain is a hosted engine domain. Change-Id: Iad7c5f4e5557e4c861e5a2317c79bc3fae874e70 Bug-Url: https://bugzilla.redhat.com/1301105 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit 31d8036) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingBlockStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java A packaging/dbscripts/upgrade/04_00_0800_remove_hosted_engine_storage_domain_name_config_value.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 16 files changed, 106 insertions(+), 116 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/60255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad7c5f4e5557e4c861e5a2317c79bc3fae874e70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: remove missing fedora builds from 3.6 publisher
by eedri＠redhat.com 08 Jul '16

08 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: remove missing fedora builds from 3.6 publisher ...................................................................... remove missing fedora builds from 3.6 publisher ovirt-engine & mom 3.6 stopped being built for fedora removing so publisher will work again. we still need to remove other projects but first they need to stop building it and it requires a patch per project Change-Id: Ibba9999aca027962debd830b3922b3c1f524e148 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 1 file changed, 10 insertions(+), 22 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibba9999aca027962debd830b3922b3c1f524e148 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Include disk plugged status in DiskVmElement
by tnisan＠redhat.com 07 Jul '16

07 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Include disk plugged status in DiskVmElement ...................................................................... core: Include disk plugged status in DiskVmElement Change-Id: Iffac29dd8b075466356c4f2d116a8c7a3de1f32e Bug-Url: https://bugzilla.redhat.com/1352966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskVmElement.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/disk_vm_element_sp.sql 4 files changed, 36 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffac29dd8b075466356c4f2d116a8c7a3de1f32e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0