- Engine-commits - oVirt List Archives

Change in ovirt-iso-uploader[master]: ovirt-iso-uploader: port to SDK version 4
by rmartins＠redhat.com 31 May '16

31 May '16

Rafael Martins has submitted this change and it was merged. Change subject: ovirt-iso-uploader: port to SDK version 4 ...................................................................... ovirt-iso-uploader: port to SDK version 4 Please note that 'list' action behaviour changed, due to some limitations of ovirt-engine-sdk4: - Not showing the datacenter where the storage domain belongs - Status column isn't very reliable. Change-Id: I94e22eea5dcde995f4f109e90dd9921143cdab55 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in M src/__main__.py 3 files changed, 64 insertions(+), 119 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/58201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94e22eea5dcde995f4f109e90dd9921143cdab55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not compare hash of guest agent nics in vms monitoring
by ahadas＠redhat.com 31 May '16

31 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: do not compare hash of guest agent nics in vms monitoring ...................................................................... core: do not compare hash of guest agent nics in vms monitoring The hash of the network interfaces reported by the guest agent is computed by the engine (rather than reported by VDSM) and therefore should not be a part of the comparison of the dynamic data from the database and the data reported by VDSM in VMs monitoring that leads to redundant updates of the dynamic data of VMs. Change-Id: I01629b006525cd30be5d7cdf6e6ccd398131d50a Bug-Url: https://bugzilla.redhat.com/1340722 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Vinzenz Feenstra: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01629b006525cd30be5d7cdf6e6ccd398131d50a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor cleanup in VmHandler
by ahadas＠redhat.com 31 May '16

31 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in VmHandler ...................................................................... core: minor cleanup in VmHandler 1. Remove unused method 2. Add SupressWarning for unchecked cast Change-Id: I77d4493d7cd5e2f98e53359dd91bf8c049f398ec Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/58301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77d4493d7cd5e2f98e53359dd91bf8c049f398ec Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: centos-7: Added auto accept defaults option
by lveyde＠redhat.com 31 May '16

31 May '16

Lev Veyde has submitted this change and it was merged. Change subject: centos-7: Added auto accept defaults option ...................................................................... centos-7: Added auto accept defaults option An option to automatically accept defaults was added to the answer file. Change-Id: I7d3b8a1dcd8df4ce7f64973eba2078002a77579f Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58290 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d3b8a1dcd8df4ce7f64973eba2078002a77579f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: centos-7: Update VDSM bridge setup script for the new API
by lveyde＠redhat.com 31 May '16

31 May '16

Lev Veyde has submitted this change and it was merged. Change subject: centos-7: Update VDSM bridge setup script for the new API ...................................................................... centos-7: Update VDSM bridge setup script for the new API The bridge setup script was updated to use the new API, as there is a change both in the module name and the parameter types of some of the functions used. Change-Id: I498c379ac36a9fe17a238276fb9efcc0cdfa97f0 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/oVirtLiveFiles/root/usr/libexec/vdsm/hooks/before_vdsm_start/20-setupBridge.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I498c379ac36a9fe17a238276fb9efcc0cdfa97f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: centos-7: Remove nfs-server workaround
by lveyde＠redhat.com 31 May '16

31 May '16

Lev Veyde has submitted this change and it was merged. Change subject: centos-7: Remove nfs-server workaround ...................................................................... centos-7: Remove nfs-server workaround This seems no longer to be required in 4.0, and actually causes the nfs-server to fail to start. Change-Id: Id70d15f1a185c5279471528ba63a953444995af0 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id70d15f1a185c5279471528ba63a953444995af0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: kickstart: remove kernel plugin
by lveyde＠redhat.com 31 May '16

31 May '16

Lev Veyde has submitted this change and it was merged. Change subject: kickstart: remove kernel plugin ...................................................................... kickstart: remove kernel plugin Remove ovirt-host-deploy kernel plugins, as it fails to run under ovirt-live, and causes the host-deploy to fail. Change-Id: I387c50ff241df0b00f33b094f47a72584122501f Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I387c50ff241df0b00f33b094f47a72584122501f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: userportal: division by zero in resource allocation tab
by piotr.kliczewski＠gmail.com 31 May '16

31 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: userportal: division by zero in resource allocation tab ...................................................................... userportal: division by zero in resource allocation tab If the user has no VMs accessible in userportal, going to resource allocation tab fails on division by zero. Fixed the same way as in other parts of this tab, just setting 0. Change-Id: I7046457082ecd3099c31c4fc4c18f286a16a5c25 Bug-Url: https://bugzilla.redhat.com/1339649 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests Marek Libra: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7046457082ecd3099c31c4fc4c18f286a16a5c25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.7]: core: Fix audit event type ids in database
by piotr.kliczewski＠gmail.com 31 May '16

31 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix audit event type ids in database ...................................................................... core: Fix audit event type ids in database Patch Ife969c6a094ba8acf4b7b1544be017d8a034485f fixed duplicate event type ids in AuditLogType enum, but the patch didn't include update of existing audit log records. Fortunately we store both event type name and its id in audit_log table (although this creates data redundancy in our db), so this patch adds missing database upgrade script. Change-Id: I4f605530ad7f56d4a18f237cdcdacd6c3702f28a Bug-Url: https://bugzilla.redhat.com/1331186 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_2120_fix_duplicate_audit_log_type_ids.sql 1 file changed, 172 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f605530ad7f56d4a18f237cdcdacd6c3702f28a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix audit event type ids in database
by piotr.kliczewski＠gmail.com 31 May '16

31 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix audit event type ids in database ...................................................................... core: Fix audit event type ids in database Patch Ife969c6a094ba8acf4b7b1544be017d8a034485f fixed duplicate event type ids in AuditLogType enum, but the patch didn't include update of existing audit log records. Fortunately we store both event type name and its id in audit_log table (although this creates data redundancy in our db), so this patch adds missing database upgrade script. Change-Id: I4f605530ad7f56d4a18f237cdcdacd6c3702f28a Bug-Url: https://bugzilla.redhat.com/1331186 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_2120_fix_duplicate_audit_log_type_ids.sql 1 file changed, 172 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f605530ad7f56d4a18f237cdcdacd6c3702f28a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0