- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix audit event type ids in database
by piotr.kliczewski＠gmail.com 31 May '16

31 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix audit event type ids in database ...................................................................... core: Fix audit event type ids in database Patch Ife969c6a094ba8acf4b7b1544be017d8a034485f fixed duplicate event type ids in AuditLogType enum, but the patch didn't include update of existing audit log records. Fortunately we store both event type name and its id in audit_log table (although this creates data redundancy in our db), so this patch adds missing database upgrade script. Change-Id: I4f605530ad7f56d4a18f237cdcdacd6c3702f28a Bug-Url: https://bugzilla.redhat.com/1331186 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0720_fix_duplicate_audit_log_type_ids.sql 1 file changed, 172 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f605530ad7f56d4a18f237cdcdacd6c3702f28a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: provide CA in .vv file only if not overridden
by piotr.kliczewski＠gmail.com 31 May '16

31 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: provide CA in .vv file only if not overridden ...................................................................... core: provide CA in .vv file only if not overridden Detect that a custom CA has been provided. If provided, don't set it to the .vv file. Change-Id: I439306bd3c001cade83a31929d3aab3f98a641a0 Bug-Url: https://bugzilla.redhat.com/1313379 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java 4 files changed, 27 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Passed CI tests Tomas Jelinek: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I439306bd3c001cade83a31929d3aab3f98a641a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix audit event type ids in database
by mperina＠redhat.com 31 May '16

31 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix audit event type ids in database ...................................................................... core: Fix audit event type ids in database Patch Ife969c6a094ba8acf4b7b1544be017d8a034485f fixed duplicate event type ids in AuditLogType enum, but the patch didn't include update of existing audit log records. Fortunately we store both event type name and its id in audit_log table (although this creates data redundancy in our db), so this patch adds missing database upgrade script. Change-Id: I4f605530ad7f56d4a18f237cdcdacd6c3702f28a Bug-Url: https://bugzilla.redhat.com/1331186 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0730_fix_duplicate_audit_log_type_ids.sql 1 file changed, 172 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f605530ad7f56d4a18f237cdcdacd6c3702f28a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: engine doesn't trust externally-issued web certificate
by piotr.kliczewski＠gmail.com 31 May '16

31 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: engine doesn't trust externally-issued web certificate ...................................................................... aaa: engine doesn't trust externally-issued web certificate Engine should use configurable trustore for communication with sso module. New config variables have been added to pki conf file to let the user set custom trustsore for SSO<->Engine SSL communication. If the admin sets up custom apache certificates and loads the certificate into system wide trust store, the admin can add a new conf file to point the ENGINE_HTTPS_PKI_TRUST_STORE and ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD to the system truststore's location and password. Change-Id: I35788dea6fff2f4bf4b554f4457591c29db057ed Bug-Url: https://bugzilla.redhat.com/1336838 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/ca.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py 5 files changed, 15 insertions(+), 21 deletions(-) Approvals: Martin Peřina: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35788dea6fff2f4bf4b554f4457591c29db057ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging:pom: update requirements
by piotr.kliczewski＠gmail.com 31 May '16

31 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging:pom: update requirements ...................................................................... packaging:pom: update requirements Update pom requirements: otopi: 1.5.0 ovirt-host-deploy: 1.5.0 Change-Id: I2cb1cd9f766ccf4ee63053bfe96568ef41e0c647 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cb1cd9f766ccf4ee63053bfe96568ef41e0c647 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging:pom: update requirements
by mperina＠redhat.com 31 May '16

31 May '16

Martin Peřina has submitted this change and it was merged. Change subject: packaging:pom: update requirements ...................................................................... packaging:pom: update requirements Update pom requirements: otopi: 1.5.0 ovirt-host-deploy: 1.5.0 Change-Id: I2cb1cd9f766ccf4ee63053bfe96568ef41e0c647 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cb1cd9f766ccf4ee63053bfe96568ef41e0c647 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: provide CA in .vv file only if not overridden
by tjelinek＠redhat.com 31 May '16

31 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: provide CA in .vv file only if not overridden ...................................................................... core: provide CA in .vv file only if not overridden Detect that a custom CA has been provided. If provided, don't set it to the .vv file. Change-Id: I439306bd3c001cade83a31929d3aab3f98a641a0 Bug-Url: https://bugzilla.redhat.com/1313379 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java 4 files changed, 27 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved; Passed CI tests Martin Peřina: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I439306bd3c001cade83a31929d3aab3f98a641a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: engine doesn't trust externally-issued web certificate
by mperina＠redhat.com 31 May '16

31 May '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: engine doesn't trust externally-issued web certificate ...................................................................... aaa: engine doesn't trust externally-issued web certificate Engine should use configurable trustore for communication with sso module. New config variables have been added to pki conf file to let the user set custom trustsore for SSO<->Engine SSL communication. If the admin sets up custom apache certificates and loads the certificate into system wide trust store, the admin can add a new conf file to point the ENGINE_HTTPS_PKI_TRUST_STORE and ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD to the system truststore's location and password. Change-Id: I35788dea6fff2f4bf4b554f4457591c29db057ed Bug-Url: https://bugzilla.redhat.com/1336838 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/ca.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py 5 files changed, 15 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35788dea6fff2f4bf4b554f4457591c29db057ed Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: division by zero in resource allocation tab
by tjelinek＠redhat.com 31 May '16

31 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: division by zero in resource allocation tab ...................................................................... userportal: division by zero in resource allocation tab If the user has no VMs accessible in userportal, going to resource allocation tab fails on division by zero. Fixed the same way as in other parts of this tab, just setting 0. Change-Id: I7046457082ecd3099c31c4fc4c18f286a16a5c25 Bug-Url: https://bugzilla.redhat.com/1339649 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7046457082ecd3099c31c4fc4c18f286a16a5c25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Limit sonar analysis to master branch
by sbonazzo＠redhat.com 31 May '16

31 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Limit sonar analysis to master branch ...................................................................... Limit sonar analysis to master branch Sonar by default does not differentiate between different branches. Limit the analysis to master to get untainted reports. Change-Id: Icab31f0aaf98adc88214ed70d7276f13eac188ee Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M .travis.yml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icab31f0aaf98adc88214ed70d7276f13eac188ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0