- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: fixed vm lock icon positioning
by awels＠redhat.com 16 May '16

16 May '16

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: fixed vm lock icon positioning ...................................................................... userportal, webadmin: fixed vm lock icon positioning Fixed vm lock icon positioning. s/fixed/absolute/ Change-Id: Id9760a0905bc9ad2755b737fb88a46b12f69ed09 Bug-Url: https://bugzilla.redhat.com/1331079 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/57434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9760a0905bc9ad2755b737fb88a46b12f69ed09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fixed layout issue in Host dialogs
by awels＠redhat.com 16 May '16

16 May '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed layout issue in Host dialogs ...................................................................... webadmin: fixed layout issue in Host dialogs Fixed layout issue in Host and Install Host dialogs where textboxes were floating over radio buttons, making them unclickable. The problem only happened when the Bootstrap row wrapped (when the dialog was skinnier than usual). Change-Id: I65ec6aaedfcb906a97cf5e554f5787ce51437895 Bug-Url: https://bugzilla.redhat.com/1322435 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/57449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65ec6aaedfcb906a97cf5e554f5787ce51437895 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddStorageDomainCommon domain names
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddStorageDomainCommon domain names ...................................................................... core: AddStorageDomainCommon domain names Use Java 8's slick way of creating a list of domain names instead of re-implementing this boilerplate logic. Change-Id: Ifbf41c9f87ae86db15f8a2d42600759f228bc783 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommon.java 1 file changed, 2 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbf41c9f87ae86db15f8a2d42600759f228bc783 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not monitor pool with no prestarted vms
by ahadas＠redhat.com 16 May '16

16 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: do not monitor pool with no prestarted vms ...................................................................... core: do not monitor pool with no prestarted vms Apparently, VmPoolCommandBase#getNumOfPrestartedVmsInPool is a costly method. This patch reduces calls to this method by filtering VM-pools with no prestarted-VMs from being monitored in VmPoolMonitor. Change-Id: I9a0b8ce069fc24a32ca0beaffa93757e032d0181 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a0b8ce069fc24a32ca0beaffa93757e032d0181 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RunVmValidatorTest spying
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmValidatorTest spying ...................................................................... core: RunVmValidatorTest spying Use spying instead of anonymously extending RunVmValidatorTest in order to make the code easier to read and follow. Not only does this technique follow the generally accepted practices for testing code in the project, it also sets up the groundwork for some extra strictness, provided in the following patch. Change-Id: Ia6a228bacaf52981aea635122238fd2e3b59debe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 1 file changed, 7 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6a228bacaf52981aea635122238fd2e3b59debe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RunVmValidatorTest lists
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmValidatorTest lists ...................................................................... core: RunVmValidatorTest lists Use the standard Collections#singletonList for a list with a single hard-coded element instead of anonymously extending ArrayList in a difficult to understand way. Change-Id: I5bc3ad90ead11ceb69ab17676ec7398c2129b2da Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bc3ad90ead11ceb69ab17676ec7398c2129b2da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RunVmValidatorTest strictness
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmValidatorTest strictness ...................................................................... core: RunVmValidatorTest strictness Make the canRunVmAsStateless test stricter by making sure that the vmNotInPreview validation is indeed applied to the VM in question and not just any random guid. Change-Id: I7981d421f8c2f2dbc05e98e8c74be23511b43743 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7981d421f8c2f2dbc05e98e8c74be23511b43743 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RunVmValidatorTest#mockVmPropertiesUtils exceptions
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmValidatorTest#mockVmPropertiesUtils exceptions ...................................................................... core: RunVmValidatorTest#mockVmPropertiesUtils exceptions Test set-up methods should throw exceptions if they fail to set up the test, making it error out instead of silently catching the exception and having the test fail in some hard to debug way later. Moreover, a test (or any piece of reasonable software, for that matter), should certainly not just dump the stacktrace to stderr (instead of using some proper logging framework). Change-Id: I1c8560223dad4412e28ad7f7be5f33d7965e4b85 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c8560223dad4412e28ad7f7be5f33d7965e4b85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Optimization of DB access in REST GET vms
by ahadas＠redhat.com 16 May '16

16 May '16

Arik Hadas has submitted this change and it was merged. Change subject: restapi: Optimization of DB access in REST GET vms ...................................................................... restapi: Optimization of DB access in REST GET vms Number of DB queries for getting graphics devices within a REST GET VMS List call is constant (2). It was linear with the count of VMs before. New GetGraphicsDevicesMultipleQuery is added. The GetVmDeviceByTypeAndDevice stored procedure supports filtering and the result set is filtered on the given UUID[] vm_ids list. Index on vm_device 'type,device,alias' is added. Change-Id: I9040c0790f5b10860fbdfed6ba6e1667e5901d83 Bug-Url: https://bugzilla.redhat.com/1268216 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetGraphicsDevicesMultipleQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDaoImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/DisplayHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java A packaging/dbscripts/upgrade/04_00_0640_add_index_on_vm_device.sql M packaging/dbscripts/vm_device_sp.sql 9 files changed, 160 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9040c0790f5b10860fbdfed6ba6e1667e5901d83 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: kickstart: Register .vv files
by lveyde＠redhat.com 16 May '16

16 May '16

Lev Veyde has submitted this change and it was merged. Change subject: kickstart: Register .vv files ...................................................................... kickstart: Register .vv files Register .vv files so they'll be opened automatically. Change-Id: Ic8ab22e0a679ffa60c94d7810a2a3124439c13bd Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1307261 --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8ab22e0a679ffa60c94d7810a2a3124439c13bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0