- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix NPE while detecting external vm
by ahadas＠redhat.com 15 May '16

15 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix NPE while detecting external vm ...................................................................... core: fix NPE while detecting external vm A regression that was caused by recent refactoring in VMs-monitoring lead to a NPE when an external VM is detected. Therefore, adding a null-check to prevent this from happening. Change-Id: I71ca5639661e493d511a97928949624b183c3923 Bug-Url: https://bugzilla.redhat.com/1335186 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71ca5639661e493d511a97928949624b183c3923 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Change button name to import for unregistered disks.
by mlipchuk＠redhat.com 15 May '16

15 May '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Change button name to import for unregistered disks. ...................................................................... webadmin: Change button name to import for unregistered disks. Storage -> Import Disks Change the butoon name "Register" to "Import" for importing unregistered disks, so it will be the same button name we use also for importing VMs and Templates Change-Id: Idfe67a62e92e61418d42f454f96eb34449629219 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterDiskImageView.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfe67a62e92e61418d42f454f96eb34449629219 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : No debug log entry for user executing multiple actions
by masayag＠redhat.com 15 May '16

15 May '16

Moti Asayag has submitted this change and it was merged. Change subject: engine : No debug log entry for user executing multiple actions ...................................................................... engine : No debug log entry for user executing multiple actions Debug log entry needs to be added when the user executes a mutiple actions command. Change-Id: I64025fc448a4806f4cd58c60086a47f4bcc4381a Bug-Url: https://bugzilla.redhat.com/1314826 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunner.java 3 files changed, 31 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64025fc448a4806f4cd58c60086a47f4bcc4381a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove internal query for watchdog device
by ahadas＠redhat.com 15 May '16

15 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove internal query for watchdog device ...................................................................... core: remove internal query for watchdog device AddWatchdogCommand used to call GetWatchdog query. This is not the standard way to do it in the backend, but to use the DAO explicitly instead. Change-Id: Ie5f58b752a71b2d03a4c727d804335f220b72aa1 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/54146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5f58b752a71b2d03a4c727d804335f220b72aa1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Update to version 4.0.17 model and 1.0.11 of metamodel
by omachace＠redhat.com 15 May '16

15 May '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to version 4.0.17 model and 1.0.11 of metamodel ...................................................................... Update to version 4.0.17 model and 1.0.11 of metamodel The more relevant changes in this new version of the model is that the "Status" type has been removed, and replaced by enums or strings. So the tests and examples need to be updated to use "whatever.status" instead of "whatever.status.state". Change-Id: Id251ca889db9dc47221cd21e4e50191fc0430b52 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml M sdk/examples/add_host.py M sdk/examples/add_nfs_data_storage_domain.py M sdk/examples/add_nfs_iso_storage_domain.py M sdk/examples/add_vm_disk.py M sdk/examples/attach_nfs_data_storage_domain.py M sdk/examples/attach_nfs_iso_storage_domain.py M sdk/examples/remove_host.py M sdk/examples/start_vm.py M sdk/examples/stop_vm.py 10 files changed, 11 insertions(+), 19 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id251ca889db9dc47221cd21e4e50191fc0430b52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Update to version 4.0.17 model and 1.0.11 of metamodel
by omachace＠redhat.com 15 May '16

15 May '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to version 4.0.17 model and 1.0.11 of metamodel ...................................................................... Update to version 4.0.17 model and 1.0.11 of metamodel The more relevant changes in this new version of the model is that the "Status" type has been removed, and replaced by enums or strings. So the tests and examples need to be updated to use "whatever.status()" instead of "whatever.status().state()". The patch also fixes some things that didn't work correctly in some of the examples. Change-Id: Iadbfc4b76342ddff7fb62447ceaa0dc8a0db9ce2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml M sdk/src/test/java/org/ovirt/engine/sdk4/ActionReaderTest.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddHost.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddNfsDataStorageDomain.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddNfsIsoStorageDomain.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmDisk.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmNic.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AttachNfsDataStorageDomain.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AttachNfsIsoStorageDomain.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/FollowVmLinks.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListVms.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/RemoveHost.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/StartVm.java M sdk/src/test/java/org/ovirt/engine/sdk4/examples/StopVm.java 14 files changed, 102 insertions(+), 98 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadbfc4b76342ddff7fb62447ceaa0dc8a0db9ce2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: aaa: kerbldap: don't resolve groups in authn stage
by tnisan＠redhat.com 14 May '16

14 May '16

Tal Nisan has submitted this change and it was merged. Change subject: aaa: kerbldap: don't resolve groups in authn stage ...................................................................... aaa: kerbldap: don't resolve groups in authn stage Change-Id: I445e25e68c611e3d6e38656891a7a62463e17ba5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1335488 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapAuthenticateUserCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I445e25e68c611e3d6e38656891a7a62463e17ba5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: aaa: kerbldap: send special path to krb5.conf
by tnisan＠redhat.com 14 May '16

14 May '16

Tal Nisan has submitted this change and it was merged. Change subject: aaa: kerbldap: send special path to krb5.conf ...................................................................... aaa: kerbldap: send special path to krb5.conf Patch Ic36734c65793674fa0b37a7baf0f59b7fc27287b introduced regression. It removed special java parameter which sets path to krb5.conf specific to manage-domains, this patch is adding it back, because without that manage-domains don't work Change-Id: I10702c99b43b1d23c5c625293e3c072df53f3591 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1327041 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10702c99b43b1d23c5c625293e3c072df53f3591 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Manually add RSDL links impossible to generate
by tnisan＠redhat.com 14 May '16

14 May '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Manually add RSDL links impossible to generate ...................................................................... restapi: Manually add RSDL links impossible to generate Some of the links that should be part of the RSDL are currently impossible to generate automatically. The reason is that some of the JAX-RS interfaces are generic, and it is impossible for the RSDL generator to automatically infer what methods are available in the implementations of those interfaces. In the master branch this has been solved as part of the introduction of the new model and metamodel, but doing the same in the 3.6 branch is too complicated, and risky. To solve the issue in a less risky way this patch adds a new "rsdl_links.xml" file that contains manually generated links that will be added to the RSDL during the build process. Change-Id: I57a0ba2bbdf9ed4d72bb1c1f15b8af274799f092 Bug-Url: https://bugzilla.redhat.com/1331068 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java A backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_links.xml 2 files changed, 74 insertions(+), 25 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57a0ba2bbdf9ed4d72bb1c1f15b8af274799f092 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix system errata server
by juan.hernandez＠redhat.com 13 May '16

13 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix system errata server ...................................................................... restapi: Fix system errata server In version 3 of the engine the system errata resource was implemented using an empty interface as a placeholder for the required JAX-RS annotations. But in version 4 of the engine the classes that implement the V3 compatibility layer don't use inheritance, and as a result this resource is actually empty. This patch fixes that, removing the empty class and replacing it with the generic errata implementation. Change-Id: I1ef667d5e9a0e698a7f4bafb7a7843e61ced019d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3EngineKatelloErrataServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3SystemServer.java 2 files changed, 2 insertions(+), 31 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ef667d5e9a0e698a7f4bafb7a7843e61ced019d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0