- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix permissions for profiles created for new domain
by rgolan＠redhat.com 10 May '16

10 May '16

Roy Golan has submitted this change and it was merged. Change subject: core: Fix permissions for profiles created for new domain ...................................................................... core: Fix permissions for profiles created for new domain The AddDiskProfileCommand takes care of the permissions for newly added disk profiles and gives the users in Everyone group the DiskProfileUser role. AddStorageDomain command added the created disk profile directly to the DB without calling the command and so this role was not assigned. The fix was to call AddDiskProfileCommand directly from AddStorageDomain and also from AddStorageDomainToPoolCommand which creates a disk profile in case one doesn't exist for the storage domain. Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459 Bug-Url: https://bugzilla.redhat.com/1209505 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java 4 files changed, 30 insertions(+), 25 deletions(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, but someone else must approve Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/56573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin:add event msg for VM_MIGRATION_TO_SERVER_FAILED
by tjelinek＠redhat.com 10 May '16

10 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin:add event msg for VM_MIGRATION_TO_SERVER_FAILED ...................................................................... webadmin:add event msg for VM_MIGRATION_TO_SERVER_FAILED Add missing event message string for event VM_MIGRATION_TO_SERVER_FAILED , so that it will be displayed in UI properly. Change-Id: I13781b601c5551046fdb34695297490a1e054bda Bug-Url: https://bugzilla.redhat.com/1288089 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/57287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13781b601c5551046fdb34695297490a1e054bda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[sonar]: core: Build and analyze the project on travis
by rmohr＠redhat.com 10 May '16

10 May '16

Roman Mohr has submitted this change and it was merged. Change subject: core: Build and analyze the project on travis ...................................................................... core: Build and analyze the project on travis Do sonar code analysis on travis then uploads evertyhing to https://nemo.sonarqube.org/overview?id=org.ovirt.engine%3Aroot. Change-Id: I942f40c3d7597a6d417d5e44d1be4a0cb41e61ae Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- A .travis.yml 1 file changed, 15 insertions(+), 0 deletions(-) -- To view, visit https://gerrit.ovirt.org/57299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I942f40c3d7597a6d417d5e44d1be4a0cb41e61ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: sonar Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: Adapt to netinfo namespace change under network
by stirabos＠redhat.com 10 May '16

10 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: Adapt to netinfo namespace change under network ...................................................................... Adapt to netinfo namespace change under network netinfo library from vdsm was moved under network directory and broke the setup. TODO In the future we need to establish an API or a stable library to work with. Change-Id: I0f4a99c8562e947baa27ef0447df0b317a0b1e08 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/vds_info.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/57228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f4a99c8562e947baa27ef0447df0b317a0b1e08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: node: Temporarily disable cockpit-ovirt
by sbonazzo＠redhat.com 10 May '16

10 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Temporarily disable cockpit-ovirt ...................................................................... node: Temporarily disable cockpit-ovirt Until the dependency and naming issues of cockpit-ovirt are solved, disable it. Change-Id: I89da60514b5b60c8feea8f0d1371e84b5601f369 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M ovirt-release36.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Anatoly Litovsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89da60514b5b60c8feea8f0d1371e84b5601f369 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Adjusting the value of binding:host_id during openst...
by alkaplan＠redhat.com 10 May '16

10 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjusting the value of binding:host_id during openstack port allocation ...................................................................... engine: Adjusting the value of binding:host_id during openstack port allocation The value of binding:host_id must be the same value as was set during the automated neutron agent during host installation, or just the host name if the agent was installed manually. If the neutron agent was installed automatically during host deployment, the vds static data will contain the provider id. Based on this the value the host_id is determined. Change-Id: I6f0fd4c2398112c189b853c1294bf535b82dca9b Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f0fd4c2398112c189b853c1294bf535b82dca9b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Moving network provider id from paramters to paramte...
by alkaplan＠redhat.com 10 May '16

10 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Moving network provider id from paramters to paramters.vdsstaticdata ...................................................................... engine: Moving network provider id from paramters to paramters.vdsstaticdata The openstack network provider is moved from parameters to parameters.vdsstaticdata. This will alow to persist the openstack network provider as part of VdsStatic data. This is required to distinguish hosts which have the neutron agent configured during host installation. In this case the neutron agent has the property binding:host_id set to a custom value, and this needs to be reflected during openstack port allocation. In case the agent is installed manually, the property value must not be customized. Change-Id: I71c6ac97486a210d80da6e5b6e23386b32e538ff Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/hostdeploy/InstallVdsParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 5 files changed, 17 insertions(+), 18 deletions(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c6ac97486a210d80da6e5b6e23386b32e538ff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Display only openstack providers when adding host
by alkaplan＠redhat.com 10 May '16

10 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Display only openstack providers when adding host ...................................................................... webadmin: Display only openstack providers when adding host Only openstack providers should be displayed in the Network Provider tab during host installation. External network provider installation is not ready yet. Change-Id: I4a775fa0f60e713cd40739224bae2ace01e63d1d Bug-Url: https://bugzilla.redhat.com/1314375 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/HostNetworkProviderModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a775fa0f60e713cd40739224bae2ace01e63d1d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Apply tenant id for all networks providers
by alkaplan＠redhat.com 10 May '16

10 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Apply tenant id for all networks providers ...................................................................... engine: Apply tenant id for all networks providers Tenant id should be set for entities of both Openstack and external providers. Change-Id: Ib4cc5a4b538cab4b1c24f3635a599f45e7ba3c5f Bug-Url: https://bugzilla.redhat.com/1314375 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java 2 files changed, 5 insertions(+), 36 deletions(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4cc5a4b538cab4b1c24f3635a599f45e7ba3c5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Changing network provider read-only default value ...
by alkaplan＠redhat.com 10 May '16

10 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Changing network provider read-only default value to true ...................................................................... webadmin: Changing network provider read-only default value to true The read only checkbox for network providers should be true for new providers. Change-Id: Ibc1fbc582440aebecaf8a19fa9fe4d604be73532 Bug-Url: https://bugzilla.redhat.com/1314375 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc1fbc582440aebecaf8a19fa9fe4d604be73532 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0