- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Support events in CoCo
by masayag＠redhat.com 11 May '16

11 May '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Support events in CoCo ...................................................................... engine: Support events in CoCo Command coordinator infrastructure will support registration to events from commands, where the command's callback will be invoked upon receiving the event from vdsm. Change-Id: I6d5b8bc3d6f57e9da96f7983eb732f52821fc170 Bug-Url: https://bugzilla.redhat.com/1284903 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CallbackTiming.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoEventSubscriber.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 12 files changed, 308 insertions(+), 93 deletions(-) Approvals: Moti Asayag: Verified; Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5b8bc3d6f57e9da96f7983eb732f52821fc170 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: allow vdsm jobs to run also on f23 slaves
by eedri＠redhat.com 11 May '16

11 May '16

Eyal Edri has submitted this change and it was merged. Change subject: allow vdsm jobs to run also on f23 slaves ...................................................................... allow vdsm jobs to run also on f23 slaves Change-Id: I95840f0e4a16f216644384bafda25c1a88d81dd8 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Verified; Ready for merge Gil Shinar: Looks good to me Pavel Zhukov: Looks good to me Jenkins CI: Passed CI tests David Caro: Looks good to me -- To view, visit https://gerrit.ovirt.org/57316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95840f0e4a16f216644384bafda25c1a88d81dd8 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: Fix PEP8 issue during developer build
by sbonazzo＠redhat.com 11 May '16

11 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: Fix PEP8 issue during developer build ...................................................................... build: Fix PEP8 issue during developer build Change-Id: I8623b0e1328769a5180aadf619bd6794f744124e Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M build/helptag-oneline-check.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Martin Sivák: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8623b0e1328769a5180aadf619bd6794f744124e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Add option --reconfigure-dwh-scale
by sbonazzo＠redhat.com 11 May '16

11 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Add option --reconfigure-dwh-scale ...................................................................... packaging: setup: Add option --reconfigure-dwh-scale Change-Id: I76f66f26f22b448506ba0e9135c8b1d825c6fae8 Bug-Url: https://bugzilla.redhat.com/1328805 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/bin/ovirt-engine-setup 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/57303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76f66f26f22b448506ba0e9135c8b1d825c6fae8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in gerrit-admin[master]: Added docs
by eedri＠redhat.com 11 May '16

11 May '16

Eyal Edri has submitted this change and it was merged. Change subject: Added docs ...................................................................... Added docs * Documenting the bash scripts with doxygen * Documenting the python ones with sphinx * Bundling it all together in html with sphinx * Formatting the comments to be properly picked up * Added automation dir and scripts to build the docs on ci Change-Id: Iafc57df0c707ee1a06a3f9707a94968a3235cf60 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A Makefile A automation/build-artifacts.packages A automation/build-artifacts.sh A automation/check-merged.packages A automation/check-merged.sh A automation/check-patch.packages A automation/check-patch.sh A automation/common.sh A docs/Doxyfile A docs/Doxyfile_hooks A docs/Makefile A docs/requires.txt A docs/source/Adding_hooks.rst A docs/source/Bash_hooks.rst A docs/source/Bash_libs.rst A docs/source/Configuration.rst A docs/source/Hook_dispatcher.rst A docs/source/Installation.rst A docs/source/Python_hooks.rst A docs/source/Python_libs.rst A docs/source/conf.py A docs/source/index.rst M hooks/custom_hooks/change-merged.set_MODIFIED A hooks/custom_hooks/change-merged.set_MODIFIED.sh M hooks/custom_hooks/comment-added.propagate_review_values A hooks/custom_hooks/comment_added_propagate_review_values.py M hooks/custom_hooks/patchset-created.bz.0.has_bug_url A hooks/custom_hooks/patchset-created.bz.0.has_bug_url.sh M hooks/custom_hooks/patchset-created.bz.1.is_public A hooks/custom_hooks/patchset-created.bz.1.is_public.sh M hooks/custom_hooks/patchset-created.bz.2.correct_product A hooks/custom_hooks/patchset-created.bz.2.correct_product.sh M hooks/custom_hooks/patchset-created.bz.3.correct_target_milestone A hooks/custom_hooks/patchset-created.bz.3.correct_target_milestone.sh M hooks/custom_hooks/patchset-created.bz.3.correct_target_release A hooks/custom_hooks/patchset-created.bz.3.correct_target_release.sh M hooks/custom_hooks/patchset-created.bz.98.set_POST A hooks/custom_hooks/patchset-created.bz.98.set_POST.sh M hooks/custom_hooks/patchset-created.bz.99.review_ok A hooks/custom_hooks/patchset-created.bz.99.review_ok.sh M hooks/custom_hooks/patchset-created.warn_if_not_merged_to_previous_branch A hooks/custom_hooks/patchset_created_warn_if_not_merged_to_previous_branch.py M hooks/custom_hooks/update_tracker A hooks/custom_hooks/update_tracker.py M hooks/hook-dispatcher A hooks/hook_dispatcher.py M hooks/lib/bz.sh M hooks/lib/conf.sh M hooks/lib/config.py M hooks/lib/gerrit.sh M hooks/lib/tools.sh A scripts/doxygen-bash.sed 52 files changed, 6,504 insertions(+), 631 deletions(-) Approvals: Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Verified -- To view, visit https://gerrit.ovirt.org/56819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafc57df0c707ee1a06a3f9707a94968a3235cf60 Gerrit-PatchSet: 9 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix error message when unautherized access providers
by masayag＠redhat.com 10 May '16

10 May '16

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: fix error message when unautherized access providers ...................................................................... webadmin: fix error message when unautherized access providers Fix calling the translation twice on the validation messages which caused a disrapted message to appear. Change-Id: I0b88d146d5e7fe6cc4bbd88b9a403712a39fb489 Bug-Url: https://bugzilla.redhat.com/1303694 Signed-off-by: borod108 <bodnopoz(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Boris Odnopozov: Verified Daniel Erez: Looks good to me, approved Moti Asayag: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/57245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b88d146d5e7fe6cc4bbd88b9a403712a39fb489 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: change logic of validation of power management
by masayag＠redhat.com 10 May '16

10 May '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: change logic of validation of power management ...................................................................... engine: change logic of validation of power management This patch changes logic of validation of power management as follows: PM parameters are valid if: * user don't have pm enabled and fence agents are null. * user has pm enabled and send valid non-empty list of fence agents PM parameters aren't valid if: * user has pm enabled and send empty list of fence agents Change-Id: Ib7991fccfa544153c376707fb8b46abed8c77692 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1330209 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 3 files changed, 12 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7991fccfa544153c376707fb8b46abed8c77692 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use system wide CA certificates by default
by juan.hernandez＠redhat.com 10 May '16

10 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use system wide CA certificates by default ...................................................................... Use system wide CA certificates by default This patch changes the SDK so that when TLS is enabled and no CA certificate file is explicitly provided, it will use the system wide CA certificates. Change-Id: Ib93e46bb4343071f7567e1d95980c4c9f9a0039c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/README.adoc M sdk/lib/ovirtsdk4/http.rb M sdk/spec/connection_create_spec.rb 3 files changed, 11 insertions(+), 14 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93e46bb4343071f7567e1d95980c4c9f9a0039c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Adding type to OpenstackNetworkProvider
by juan.hernandez＠redhat.com 10 May '16

10 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Adding type to OpenstackNetworkProvider ...................................................................... restapi: Adding type to OpenstackNetworkProvider Change-Id: If6c861016195af28b5986adf7127a6432f40c6c2 Bug-Url: https://bugzilla.redhat.com/1314375 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkProviderResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkProvidersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackNetworkProviderMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackNetworkProviderMapperTest.java 4 files changed, 33 insertions(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6c861016195af28b5986adf7127a6432f40c6c2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: send all graphics device attrs as specParams
by ahadas＠redhat.com 10 May '16

10 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: send all graphics device attrs as specParams ...................................................................... core: send all graphics device attrs as specParams If Vdsm receives a graphic device, it doesn't look for global parameters, and checks only the device specParams. This patch makes sure we fill the specParams correctly, and that we don't send parameters in the global configuration anymore. This is safe because we already dropped compatibility with <= 3.4 Engines. Change-Id: I7fbde1568785228fc83fc5315a8491ca6d117692 Bug-Url: https://bugzilla.redhat.com/1331333 Backport-To: 3.6 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 3 files changed, 28 insertions(+), 38 deletions(-) Approvals: Francesco Romani: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fbde1568785228fc83fc5315a8491ca6d117692 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0