- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Adding AdPartnerMacSupported config property
by alkaplan＠redhat.com 08 May '16

08 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adding AdPartnerMacSupported config property ...................................................................... engine: Adding AdPartnerMacSupported config property Adding the AdPartnerMacSupported config property. THe property indicates if ad_partner_mac is reported by vdsm. Change-Id: Idc0472b5776ecefd9ba641c5a64a76ad6bfd7ee0 Bug-Url: https://bugzilla.redhat.com/1281666 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc0472b5776ecefd9ba641c5a64a76ad6bfd7ee0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Adding information about aggregate link status to Bond
by alkaplan＠redhat.com 08 May '16

08 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adding information about aggregate link status to Bond ...................................................................... engine: Adding information about aggregate link status to Bond Bonds in mode 4 (link aggregation) have an aggregate assigned when working properly. This mac is reported by vdsm. This was added by patch: https://gerrit.ovirt.org/#/c/53100/14 This patch adds the aggregate mac as property of Bond, and saves it to DB so it can be later used in the UI to alert the user about a possible error condition. Change-Id: I96e9d6f0dfeeaa98becb0768cff44d30f038154b Bug-Url: https://bugzilla.redhat.com/1281666 Signed-off-by: mirecki <mmirecki(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_00_0620_add_add_partner_mac_to_vds_interface.sql 6 files changed, 35 insertions(+), 10 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96e9d6f0dfeeaa98becb0768cff44d30f038154b Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor cleanup in MaintenanceVdsCommand
by ahadas＠redhat.com 08 May '16

08 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in MaintenanceVdsCommand ...................................................................... core: minor cleanup in MaintenanceVdsCommand - fix logs in switch-to-maintenance flow - simplify logical expression: !a || (a && b) is replaced with !a || b Change-Id: I0e9ce373542b12e81445693ffb1956edb33f734c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e9ce373542b12e81445693ffb1956edb33f734c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_3.6]: sdk: Use __module__ to check module membership
by juan.hernandez＠redhat.com 07 May '16

07 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Use __module__ to check module membership ...................................................................... sdk: Use __module__ to check module membership The SDK needs to check if the parameters given to constructors of classes in the "params" module are brokers, as they have a special treatment. In order to do that it checks if they belong to the brokers module, using the "ReflectionHelper.isModuleMember" function. This function iterates the members of the module in order to do the check. A side effect of that is that the module needs to be loaded, and an exception is generated if it isn't. To avoid that this patch changes the implementation of the "isModuleMember" function so that it uses a simpler check, using the "__module__" builtin to obtain and compare the module name. Change-Id: I1f10343659b1fd440e521b9981f1b359aa4fe050 Bug-Url: https://bugzilla.redhat.com/1333889 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/SuperAttributesTemplate M src/ovirtsdk/utils/parsehelper.py M src/ovirtsdk/utils/reflectionhelper.py M src/ovirtsdk/xml/params.py 4 files changed, 18 insertions(+), 31 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Fabrice Bacchella: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f10343659b1fd440e521b9981f1b359aa4fe050 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Fabrice Bacchella <fabrice.bacchella(a)orange.fr> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: added support to override migration policies
by mbetak＠redhat.com 06 May '16

06 May '16

Martin Betak has submitted this change and it was merged. Change subject: frontend: added support to override migration policies ...................................................................... frontend: added support to override migration policies Migration policy is a new field on VM/template/instance type/pool. Change-Id: I8baf644ca7f2c878800c206451ab75c1011007a0 Bug-Url: https://bugzilla.redhat.com/1252426 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/HwOnlyVmBaseToUnitBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/MigrationOptionsUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/MigrationOptionsVmBaseToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeAttachDetachManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 16 files changed, 287 insertions(+), 114 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8baf644ca7f2c878800c206451ab75c1011007a0 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: added support to override migration policies
by tjelinek＠redhat.com 06 May '16

06 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: added support to override migration policies ...................................................................... core: added support to override migration policies Added migration policy to VmBase. It is a field which will be taken from: - instance type, - from VM (per-VM custom value, template's value as default) - if not defined than the one from cluster Change-Id: I95e1774a25bca6bead2be22575fe6e9668177fa3 Bug-Url: https://bugzilla.redhat.com/1252426 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/InstanceType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDao.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CustomInstanceType.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0610_add_migration_policy_to_vm.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 17 files changed, 112 insertions(+), 19 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95e1774a25bca6bead2be22575fe6e9668177fa3 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Removed el6/fc22 from fabric-ovirt
by dcaro＠redhat.com 06 May '16

06 May '16

David Caro has submitted this change and it was merged. Change subject: Removed el6/fc22 from fabric-ovirt ...................................................................... Removed el6/fc22 from fabric-ovirt Change-Id: I52156d2a860f8f4b0b08af0b4a28ff3dfb9deedd Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/fabic-ovirt/fabric-ovirt_standard.yaml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/57150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52156d2a860f8f4b0b08af0b4a28ff3dfb9deedd Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: node: add requirement for cockpit-ovirt plugin
by sbonazzo＠redhat.com 06 May '16

06 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: add requirement for cockpit-ovirt plugin ...................................................................... node: add requirement for cockpit-ovirt plugin Adding require to fetch the cockpit-ovirt plugin bits. Change-Id: Idf92afbc9488871fb1cba28dd2ce46befae5a0ef Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-release36.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf92afbc9488871fb1cba28dd2ce46befae5a0ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: node: add requirement for cockpit-ovirt plugin
by sbonazzo＠redhat.com 06 May '16

06 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: add requirement for cockpit-ovirt plugin ...................................................................... node: add requirement for cockpit-ovirt plugin Adding require to fetch the cockpit-ovirt plugin bits. Change-Id: Idf92afbc9488871fb1cba28dd2ce46befae5a0ef Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-release40.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf92afbc9488871fb1cba28dd2ce46befae5a0ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: automation: add virt sig oVirt 4.0 candidate
by sbonazzo＠redhat.com 06 May '16

06 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: add virt sig oVirt 4.0 candidate ...................................................................... automation: add virt sig oVirt 4.0 candidate Change-Id: I15d503032908281aec5386a8f40dbbaecbac55fe Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit f901a032e5d90e9650bff8099ca1199c5a6f7d70) --- M automation/check-patch.repos 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15d503032908281aec5386a8f40dbbaecbac55fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0