- Engine-commits - oVirt List Archives

Change in ovirt-release[master]: node: add requirement for cockpit-ovirt plugin
by sbonazzo＠redhat.com 06 May '16

06 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: add requirement for cockpit-ovirt plugin ...................................................................... node: add requirement for cockpit-ovirt plugin Adding require to fetch the cockpit-ovirt plugin bits. Change-Id: Idf92afbc9488871fb1cba28dd2ce46befae5a0ef Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Ryan Barry: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf92afbc9488871fb1cba28dd2ce46befae5a0ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: automation: add virt sig oVirt 4.0 candidate
by sbonazzo＠redhat.com 06 May '16

06 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: add virt sig oVirt 4.0 candidate ...................................................................... automation: add virt sig oVirt 4.0 candidate Change-Id: I15d503032908281aec5386a8f40dbbaecbac55fe Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/check-patch.repos 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15d503032908281aec5386a8f40dbbaecbac55fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix mapping of boot devices
by juan.hernandez＠redhat.com 06 May '16

06 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix mapping of boot devices ...................................................................... restapi: Fix mapping of boot devices The following patch (commit ce9644c) introduced a regression in the mapping of boot devices: restapi: Use multiple "boot.devices.device" instead of multiple "boot" https://gerrit.ovirt.org/46744 The effect is that the boot devices returned by the API are only correct when the VM is running. This patch fixes that regression. Change-Id: I5e1f6ec4e8f64f94940d84a54a63275e5ef046fe Bug-Url: https://bugzilla.redhat.com/1333340 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e1f6ec4e8f64f94940d84a54a63275e5ef046fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add V3 adapters for custom properties
by juan.hernandez＠redhat.com 06 May '16

06 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add V3 adapters for custom properties ...................................................................... restapi: Add V3 adapters for custom properties The V3 to V4 adapter classes for custom properties didn't exist. As a result creating or retrieving a virtual machine with custom properties generated an exception. This patch adds the required adapters. Change-Id: Ifda77f2caf269d36f0be9f2c70d167deff1618c8 Bug-Url: https://bugzilla.redhat.com/1333354 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3CustomPropertiesInAdapter.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3CustomPropertiesOutAdapter.java 2 files changed, 64 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifda77f2caf269d36f0be9f2c70d167deff1618c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix V3 snapshot action links
by juan.hernandez＠redhat.com 06 May '16

06 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix V3 snapshot action links ...................................................................... restapi: Fix V3 snapshot action links In version 4 of the API all the URL segments are generated concatenating the words of the relevant name without separators. But in version 3 some URL segments didn't follow this rule, in particular the URL segments corresponding to snapshot actions used an underscore to separate words: preview_snapshot commit_snapshot undo_snapshot To preserve backwards compatibility this patch changes the V3 adapter so that it fixes the links to these actions, adding the required underscore. Change-Id: Idf1712f58dc29d6a91335f2c2f228e9fe9f746aa Bug-Url: https://bugzilla.redhat.com/1332986 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java 2 files changed, 39 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf1712f58dc29d6a91335f2c2f228e9fe9f746aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Don't allow removing a disk via the VM's disks API
by juan.hernandez＠redhat.com 06 May '16

06 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't allow removing a disk via the VM's disks API ...................................................................... restapi: Don't allow removing a disk via the VM's disks API Sending a DELETE to /vms/{vm:id}/disks/{disk:id} should just detach the disk from the VM, not potentially remove the disk from the system entirely (which should be done by sending a DELETE to /vms/disks/{disk:id}. Backwards compatibility is preserved, modifying the V3 layer so that when the operation is invoked without the "action.detach" parameter the disk is explicitly deleted using the top level disks service. Change-Id: I0805a919b60bbb3636a2173446b0104fb69cac01 Bug-Url: https://bugzilla.redhat.com/1332960 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.adoc M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java 5 files changed, 41 insertions(+), 53 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0805a919b60bbb3636a2173446b0104fb69cac01 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move snapshot ID fields from VmDisk params to AttachDe...
by tnisan＠redhat.com 06 May '16

06 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Move snapshot ID fields from VmDisk params to AttachDeatch params ...................................................................... core: Move snapshot ID fields from VmDisk params to AttachDeatch params The snapshot ID is only used in the attach/detach commands, it has nothing to do with the general disk to VM parameters Change-Id: Id25350af6fed50bc91b789bc739eeda77c183144 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDetachVmDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmDiskOperationParameterBase.java 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id25350af6fed50bc91b789bc739eeda77c183144 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introducing DiskHandler
by tnisan＠redhat.com 06 May '16

06 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Introducing DiskHandler ...................................................................... core: Introducing DiskHandler Introducing the DiskHandler class which contains general disk handling commands Change-Id: Ibd8c0f88cb4aaa4a2f215b3fbff2bfdd542baed0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DiskHandler.java 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd8c0f88cb4aaa4a2f215b3fbff2bfdd542baed0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Unify addVmImages method in AddVm and AddVmFromTemplat...
by tnisan＠redhat.com 06 May '16

06 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Unify addVmImages method in AddVm and AddVmFromTemplate commands ...................................................................... core: Unify addVmImages method in AddVm and AddVmFromTemplate commands Both commands are using the same boilerplate code with little difference only in the action type and way of locking the VM, both methods were unified to one method to avoid maintaining the same code in two places Change-Id: I29a1cc22dbca57c212a68bbd7fe52c0154cfa6fa Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 2 files changed, 26 insertions(+), 37 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29a1cc22dbca57c212a68bbd7fe52c0154cfa6fa Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move VDS ID field from VmDisk params to AddDisk params
by tnisan＠redhat.com 06 May '16

06 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Move VDS ID field from VmDisk params to AddDisk params ...................................................................... core: Move VDS ID field from VmDisk params to AddDisk params The VDS ID field is only used in AddDisk command and has nothing to do with general disk to VM parameters Change-Id: I4e4fc96c9bdc59ec92205e38b9c47db1fce14c71 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmDiskOperationParameterBase.java 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e4fc96c9bdc59ec92205e38b9c47db1fce14c71 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0