- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: storage: correctly evaluate glusterfs SD canonical path
by sbonazzo＠redhat.com 02 May '16

02 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: correctly evaluate glusterfs SD canonical path ...................................................................... storage: correctly evaluate glusterfs SD canonical path In the past we let the user specify a path for file based (NFS or gluster) storage domains which includes a trailing '/'. This caused other issues (double mount point when the engine import it) and so we had a patch to evaluate the canonical path and eventually fix the mount point in the configuration file before trying again to connect it. Due to a bug in the evaluation of the canonical path for gluster volumes, it was looping forever on gluster deployed systems. Improoving the the logging to make it more evident. Change-Id: Ic7a877bb4386214044cf85de18f99b1b443222eb Bug-Url: https://bugzilla.redhat.com/1327516 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/env/constants.py.in M ovirt_hosted_engine_ha/env/path.py M ovirt_hosted_engine_ha/lib/storage_server.py 3 files changed, 34 insertions(+), 17 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7a877bb4386214044cf85de18f99b1b443222eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Publish version 3.6 of the CLI to the master repository
by sbonazzo＠redhat.com 02 May '16

02 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Publish version 3.6 of the CLI to the master repository ...................................................................... Publish version 3.6 of the CLI to the master repository There won't be a version 4 of the CLI, at least not for release 4.0 of the project. This patch changes the master publisher job so that it publishes version 3.6 of the CLI instead of the currently frozen master branch. Change-Id: Ie14fc06dacbc5d9ca18b4abdc6e5c809ebed6bd8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie14fc06dacbc5d9ca18b4abdc6e5c809ebed6bd8 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix NPE raised in ProviderDaoTest
by alkaplan＠redhat.com 02 May '16

02 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: Fix NPE raised in ProviderDaoTest ...................................................................... core: Fix NPE raised in ProviderDaoTest Fixes NPE raised in ProviderDaoTest which was caused by commit I24004be008c766478179084cb8e292b15a83b597. Change-Id: Idcb521a801d1bafbbdc0b1172a3c627705e90912 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/provider/ProviderDaoTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcb521a801d1bafbbdc0b1172a3c627705e90912 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Fail nicely on unknown option
by sbonazzo＠redhat.com 02 May '16

02 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Fail nicely on unknown option ...................................................................... packaging: engine-backup: Fail nicely on unknown option Change-Id: I96e0ee4d377aa72ae1dafd07e095f8a7baa0a004 Bug-Url: https://bugzilla.redhat.com/1329383 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96e0ee4d377aa72ae1dafd07e095f8a7baa0a004 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-scheduler-proxy[master]: automation: fix el6 and fc22 check-patch
by msivak＠redhat.com 02 May '16

02 May '16

Martin Sivák has submitted this change and it was merged. Change subject: automation: fix el6 and fc22 check-patch ...................................................................... automation: fix el6 and fc22 check-patch master branch is used for both 3.6 and 4.0. In 4.0 el6 and fc22 are not supported anymore so for testing this package on 3.6 we need 3.6 repos. Change-Id: I92ac3977f231365905537b1130cda1e1b8de5979 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/check-patch.repos.el6 A automation/check-patch.repos.fc22 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92ac3977f231365905537b1130cda1e1b8de5979 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Frontend: add VM name to console title of noVNC, SPICE HTML5
by tjelinek＠redhat.com 02 May '16

02 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: Frontend: add VM name to console title of noVNC,SPICE HTML5 ...................................................................... Frontend: add VM name to console title of noVNC,SPICE HTML5 In case of opening a console to VM using either noVNC client or SPICE HTML5 clients (both consoles running inside the browser) - the VM name wasn't displayed in title. before this fix: for noVNC - the console title was "noVNC". for SPICE HTML5 - the console title was "Spice Javascript Client". This patch added the VM name to the title for both protocols. Bug-Url: https://bugzilla.redhat.com/1313295 Change-Id: If3897b7932e2fa5bd0567c091c47751c32e07675 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java M backend/manager/modules/services/src/main/webapp/spicehtml5-main.html M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/WebClientConsoleInvoker.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 7 files changed, 25 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/56878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3897b7932e2fa5bd0567c091c47751c32e07675 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: common: VmReplicateDiskParameters - override appendAttributes()
by laravot＠redhat.com 02 May '16

02 May '16

Liron Aravot has submitted this change and it was merged. Change subject: common: VmReplicateDiskParameters - override appendAttributes() ...................................................................... common: VmReplicateDiskParameters - override appendAttributes() Change-Id: I633c48778e4504578cffa6bbd6fab491585f6491 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmReplicateDiskParameters.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Arik Hadas: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I633c48778e4504578cffa6bbd6fab491585f6491 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SerialChildExecutingCommand - handleFailure() default ...
by laravot＠redhat.com 02 May '16

02 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: SerialChildExecutingCommand - handleFailure() default implementation ...................................................................... core: SerialChildExecutingCommand - handleFailure() default implementation Change-Id: I817677b6b342cbce0a39c582799730681d6aeb28 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildExecutingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderVolumeParentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java 3 files changed, 1 insertion(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/56822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I817677b6b342cbce0a39c582799730681d6aeb28 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: support for convergence schedule
by tjelinek＠redhat.com 02 May '16

02 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: support for convergence schedule ...................................................................... core: support for convergence schedule Support for setting the migration policies. The list of policies is set in the vdc_options under MigrationPolicies. It is a JSON formatted string. >From the point of view of the user it is exposed only as a list of well described policies. The following fields are defined in this patch: - convergenceItems: list of actions which will be executed as a reaction to stalling - initialItems: list of actions executed before the migration starts - lastItems: list of actions executed as last ones (e.g. the very last item should always be something which finishes the migration one way or the other (e.g. abort or turn to postcopy) The maxDowntimeLimit can be overridden on the VM level (custom migration downtime). Change-Id: I389e202b81b01cc6891d6e5cea1a995525769987 Bug-Url: https://bugzilla.redhat.com/1252426 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllMigrationPoliciesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/migration/ConvergenceConfigProvider.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/migration/ConvergenceSchedule.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/migration/NoConvergenceSchedule.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/migration/ConvergenceConfigProviderTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/migration/ConvergenceScheduleTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/ConvergenceConfig.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/ConvergenceItem.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/ConvergenceItemWithStallingLimit.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/MigrationPolicy.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/NoConvergenceConfig.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/NoMigrationPolicy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/JsonHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/dbscripts/clusters_sp.sql A packaging/dbscripts/upgrade/04_00_0580_add_migration_policy_to_cluster.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 39 files changed, 840 insertions(+), 23 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49253 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I389e202b81b01cc6891d6e5cea1a995525769987 Gerrit-PatchSet: 41 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: missing the --all param for some reason
by eedri＠redhat.com 01 May '16

01 May '16

Eyal Edri has submitted this change and it was merged. Change subject: missing the --all param for some reason ...................................................................... missing the --all param for some reason Change-Id: Id519e8c19ea625c65b9837fbbabc3a299e7ba5da Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id519e8c19ea625c65b9837fbbabc3a299e7ba5da Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0