- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Updating CpuProfileCreator to admin role
by rgolan＠redhat.com 01 May '16

01 May '16

Roy Golan has submitted this change and it was merged. Change subject: core: Updating CpuProfileCreator to admin role ...................................................................... core: Updating CpuProfileCreator to admin role Updated the CpuProfileCreator role to admin. Since, user shouldn't be able to use it from the userportal. Change-Id: Ic4bf67168bc56b90074fc53a32b57a414131c1f3 Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0570_updating_cpu_profile_creator_role.sql 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4bf67168bc56b90074fc53a32b57a414131c1f3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: changing to run on projects instead of specified list
by eedri＠redhat.com 01 May '16

01 May '16

Eyal Edri has submitted this change and it was merged. Change subject: changing to run on projects instead of specified list ...................................................................... changing to run on projects instead of specified list - reverting back to higher levels of abandon/warn to allow patch owners to act on old patches for new projects Change-Id: I68aadf58e9b16901e1e06d3e84ca3c56a97af64d Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Nadav Goldin: Looks good to me Eyal Edri: Verified; Ready for merge Anton Marchukov: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68aadf58e9b16901e1e06d3e84ca3c56a97af64d Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Externalized default value in policy
by rgolan＠redhat.com 01 May '16

01 May '16

Roy Golan has submitted this change and it was merged. Change subject: engine: Externalized default value in policy ...................................................................... engine: Externalized default value in policy Default value of 1 was externalized for the weight scheduling policy of vm affinity group. Change-Id: I244ac0cd9cb41833c7a5357264ddca99e489de94 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnit.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244ac0cd9cb41833c7a5357264ddca99e489de94 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update number of prestarted VMs after detaching a VM f...
by ahadas＠redhat.com 01 May '16

01 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Update number of prestarted VMs after detaching a VM from Pool ...................................................................... core: Update number of prestarted VMs after detaching a VM from Pool Added a field to RemoveVmFromPoolParameters to update the number of prestarted VMs in the VM Pool, if it becomes larger than number of assigned VMs after detaching one of them. To update the number RemoveVmFromPoolCommand takes a shared lock on the VM Pool. This feature is activated only when a VM is detached from a Pool via UI or REST API. It is not used (and the lock is not taken), when: * VM Pool is removed, because prestartedVms is set to 0 at the beginning of RemoveVmPoolCommand. * Version of the template used for the Pool is updated, because all VMs that are removed will be added again soon. Change-Id: Ib864d6def677e24aa2624877e50e2ff8a8b7d1a7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1282218 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromPoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolVmListModel.java M packaging/dbscripts/vm_pools_sp.sql 12 files changed, 92 insertions(+), 14 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib864d6def677e24aa2624877e50e2ff8a8b7d1a7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Jenkins jobs for system tests for appliance and node
by eedri＠redhat.com 01 May '16

01 May '16

Eyal Edri has submitted this change and it was merged. Change subject: Jenkins jobs for system tests for appliance and node ...................................................................... Jenkins jobs for system tests for appliance and node Change-Id: I66f3c60bdc7e4be45169838f567f56962415b5ea Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml M jobs/confs/shell-scripts/system_tests.collect_logs.sh M jobs/confs/shell-scripts/system_tests.sh M jobs/confs/yaml/builders/system_tests_builders.yaml M jobs/confs/yaml/templates/system_tests_templates.yaml 5 files changed, 87 insertions(+), 4 deletions(-) Approvals: Eyal Edri: Looks good to me Jenkins CI: Passed CI tests Anatoly Litovsky: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/53378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66f3c60bdc7e4be45169838f567f56962415b5ea Gerrit-PatchSet: 11 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: set ovirtmgmt net as display and migration
by alkaplan＠redhat.com 01 May '16

01 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: set ovirtmgmt net as display and migration ...................................................................... engine: set ovirtmgmt net as display and migration Set ovirtmgmt network as display and migration in the initailly created default cluster. Change-Id: I278fec6e6ef0540b6487a70216f8b01006fa8b1e Bug-Url: https://bugzilla.redhat.com/1322515 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M packaging/dbscripts/data/01000_insert_network_cluster.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Alona Kaplan: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/56645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I278fec6e6ef0540b6487a70216f8b01006fa8b1e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Introduce Network Filter Dao
by alkaplan＠redhat.com 01 May '16

01 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Introduce Network Filter Dao ...................................................................... engine: Introduce Network Filter Dao Adding network_filter table to schema. Currently, the table is designated to be immutable. The NetworkFilterDao API is exposing the following methods: 1. getAllNetworkFilters 2. getAllSupportedNetworkFiltersByVersion 3. getNetworkFilterById 4. getMinimalSupportedVersionByNetworkFilterName 5. getNetworkFilterByName Bug-Url: https://bugzilla.redhat.com/1317441 Change-Id: I189ca3c702d406778d64266c749acaa85215724e Signed-off-by: Eliraz Levi <elevi(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllNetworkFiltersQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllSupportedNetworkFiltersByVersionQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMinimalSupportedVersionByNetworkFilterNameQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNetworkFilterByIdQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VersionQueryParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkFilter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkFilterDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkFilterDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkFilterDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_00_0560_add_netwrok_filter_table.sql 14 files changed, 584 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51184 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I189ca3c702d406778d64266c749acaa85215724e Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Introduce VersionRowMapper
by alkaplan＠redhat.com 01 May '16

01 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Introduce VersionRowMapper ...................................................................... engine: Introduce VersionRowMapper Change-Id: Ifc3ee36da3ef11c10b0003ad2f3179aa54da2bad Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VersionRowMapper.java 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc3ee36da3ef11c10b0003ad2f3179aa54da2bad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: jsonrpc: version bump
by oourfali＠redhat.com 01 May '16

01 May '16

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Change-Id: I6edc49f59d14dbc58508b46ef88314e98f355d7d Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1320128 --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6edc49f59d14dbc58508b46ef88314e98f355d7d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Return emptyList to avoid possible NPE
by rgolan＠redhat.com 01 May '16

01 May '16

Roy Golan has submitted this change and it was merged. Change subject: core: Return emptyList to avoid possible NPE ...................................................................... core: Return emptyList to avoid possible NPE Found possible null pointer exception in the Affinity Rules Enforcement Manager. The NPE is caused when findVmViolatingPositiveAg returns null and then the method isEmpty (From the List Interface) is invoked on that value. This bug was fixed by Returning empty list instead of null. Change-Id: I92a7df2771bba55db485fc0c265dcb367c092102 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92a7df2771bba55db485fc0c265dcb367c092102 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0