- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Enable symlink following in all web applications
by sbonazzo＠redhat.com 26 Apr '16

26 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Enable symlink following in all web applications ...................................................................... core: Enable symlink following in all web applications The web container included in WildFly doesn't follow symlinks in exploded web applications by default. We need that for the branding mechanism, as it is implemented with a symlink to the "branding.jar" in the "WEB-INF/lib" directory of the applications. In order to support that this patch adds to all the web applications a WildFly specific deployment descriptor (the "jboss-web.xml" file) that enables following of symlinks. Change-Id: Ieff80a8eac50e25c1d30e3e17c6d01cd5bc70e89 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/docs/src/main/webapp/WEB-INF/jboss-web.xml A backend/manager/modules/enginesso/src/main/webapp/WEB-INF/jboss-web.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/jboss-web.xml A backend/manager/modules/root/src/main/webapp/WEB-INF/jboss-web.xml A backend/manager/modules/services/src/main/webapp/WEB-INF/jboss-web.xml A backend/manager/modules/welcome/src/main/webapp/WEB-INF/jboss-web.xml A frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/jboss-web.xml A frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/jboss-web.xml 8 files changed, 193 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieff80a8eac50e25c1d30e3e17c6d01cd5bc70e89 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Unify CPU Family naming
by tjelinek＠redhat.com 26 Apr '16

26 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Unify CPU Family naming ...................................................................... webadmin: Unify CPU Family naming Unify labeling of CPU Family in REST API and UI Change-Id: I7c9d77850706bf4d563b2cae788e039ab94b86f2 Bug-Url: https://bugzilla.redhat.com/1187752 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/56375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c9d77850706bf4d563b2cae788e039ab94b86f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove Entities#upcast
by amureini＠redhat.com 26 Apr '16

26 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove Entities#upcast ...................................................................... core: Remove Entities#upcast Entities#upcast is a O(n) operation to convert a List<Subclass> to a List<Superclass>. This is really unnecessary in Java, and just comes to cover up sloppy generic declarations. This patch fixes the aforementioned declarations and removes this useless method. Change-Id: Iede112257afe7de09691ce594bfc551ac2b23a91 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 7 files changed, 9 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iede112257afe7de09691ce594bfc551ac2b23a91 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Reuse ImportValidator in ImportVmTemplate
by amureini＠redhat.com 26 Apr '16

26 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Reuse ImportValidator in ImportVmTemplate ...................................................................... core: Reuse ImportValidator in ImportVmTemplate [Re]use ImportValidator instead of copy pasting the same code between it and ImportVmTemplateCommand There a VERY slight performance benefit here too, as it saves the compilation of the same regex in two places instead of just one. Change-Id: I2e351dca07e21211dda36c83f7b4bbd03c168868 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 1 file changed, 2 insertions(+), 45 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e351dca07e21211dda36c83f7b4bbd03c168868 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Change SSO classes to CamelCase
by mperina＠redhat.com 25 Apr '16

25 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Change SSO classes to CamelCase ...................................................................... engine : Change SSO classes to CamelCase Change the SSO class names to CamelCase Change-Id: Iaa6b23079549330646701f3b2322db77934e7453 Bug-Url: https://bugzilla.redhat.com/1092744 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/exclude-filters.xml R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SsoLoginFilter.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SsoRestApiAuthFilter.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SsoRestApiNegotiationFilter.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLoginServlet.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLogoutServlet.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java M backend/manager/modules/auth-plugin/src/main/java/org/ovirt/engine/core/jboss_auth_plugin/OvirtAuthPlugIn.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableNamespacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByPrincipalQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEngineSessionIdForSsoTokenQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupsForUserQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryUserByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SsoSessionUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionsForTokenCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BaseCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/CommonTestMocks.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetEngineSessionIdForSsoTokenQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/enginesso/exclude-filters.xml R backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/context/SsoContextListener.java R backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/context/SsoSessionListener.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectorySearch.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveBasicAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveBasicEnforceServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveChangePasswdServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveNegotiateAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveNextAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveRedirectToModuleServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthRevokeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenInfoServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/StatusServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthnMessageMapper.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/DBUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/InteractiveAuth.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/NegotiateAuthUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/NonInteractiveAuth.java R backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java R backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoContext.java R backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoExtensionsManager.java R backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoLocalConfig.java R backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java R backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/TokenCleanupUtility.java M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/SsoCallbackServlet.java R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/SsoLogoutServlet.java M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LogoutServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/OAuthCallbackServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/SwitchUserServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M frontend/webadmin/modules/frontend/exclude-filters.xml R frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/SsoTokenChange.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/SsoTokenData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml 80 files changed, 645 insertions(+), 645 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa6b23079549330646701f3b2322db77934e7453 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Enable tooltip on greyed out LUNs
by derez＠redhat.com 25 Apr '16

25 Apr '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Enable tooltip on greyed out LUNs ...................................................................... webadmin: Enable tooltip on greyed out LUNs When editing an ISCSI/FC storage domain, if a LUN is already in use it will be greyed out. If the user hovers over the LUN a tooltip appears with the reason why it is disabled. In this patch, the tooltip is added to the whole row, not only the checkbox cell. It will always appear on the left of the row. Bug-Url: https://bugzilla.redhat.com/1329906 Change-Id: I4ea714768c4e427cf82a8b062fd49dcaf127335b Signed-off-by: Fred Rolland <frolland(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/56570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ea714768c4e427cf82a8b062fd49dcaf127335b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VGA as default for VNC
by ahadas＠redhat.com 25 Apr '16

25 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: VGA as default for VNC ...................................................................... core: VGA as default for VNC This is a follow-up patch for 3dfd0680620dbe6dfc9db16b6678ca423ec14c6e. Because of QXL issues (like BZ 1072350), let's use VGA as VNC default to work properly on older versions. The Cirrus is still listed among allowed display types to provide workaround for potential production issues. Change-Id: If160060086a8c0456033ca3285ea3c1c9f8cde24 Bug-Url: https://bugzilla.redhat.com/1302657 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportUtils.java M packaging/conf/osinfo-defaults.properties 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Marek Libra: Verified Arik Hadas: Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If160060086a8c0456033ca3285ea3c1c9f8cde24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Mark MultipleActionCommands as internal when appropriate
by alkaplan＠redhat.com 25 Apr '16

25 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: Mark MultipleActionCommands as internal when appropriate ...................................................................... core: Mark MultipleActionCommands as internal when appropriate During refactoring a line got lost which marks commands as internal. Change-Id: I0580a2af8bf058d0d18587ebeef11c0fa06b4771 Bug-Url: https://bugzilla.redhat.com/1329979 Bug-Url: https://bugzilla.redhat.com/1142880 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/NestedCommandFactory.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Roman Mohr: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0580a2af8bf058d0d18587ebeef11c0fa06b4771 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engein: fix false log message when putting host in maintenance
by masayag＠redhat.com 25 Apr '16

25 Apr '16

Moti Asayag has submitted this change and it was merged. Change subject: engein: fix false log message when putting host in maintenance ...................................................................... engein: fix false log message when putting host in maintenance Now handling case when the host was taken down to maintenance without a reason given by the admin. Added an audit log type to support this usecase. Change-Id: Ibeb94f6d7a3bbeed894e5bc817ee6ec946d53750 Bug-Url: https://bugzilla.redhat.com/1301031 Signed-off-by: Boris Od <bodnopoz(a)redhat.com> Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 19 insertions(+), 2 deletions(-) Approvals: Boris Odnopozov: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibeb94f6d7a3bbeed894e5bc817ee6ec946d53750 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Revoke access token at the end of session
by juan.hernandez＠redhat.com 25 Apr '16

25 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Revoke access token at the end of session ...................................................................... Revoke access token at the end of session The SSO acess token needs to be revoked to terminate the session on SSO and clean up the engine session. Change-Id: Iaa67d845783cd1e6c1fce57907702c80e76e3ff4 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M sdk/lib/ovirtsdk4/http.rb M sdk/spec/spec_helper.rb 2 files changed, 94 insertions(+), 36 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa67d845783cd1e6c1fce57907702c80e76e3ff4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0