- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Refactor CreateCinderSnapshotCommand CB
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Refactor CreateCinderSnapshotCommand CB ...................................................................... engine: Refactor CreateCinderSnapshotCommand CB Refactor CreateCinderSnapshotCommandCallback to inherit from ConcurrentChildCommandsExecutionCallback to minimize code duplication and ease future refactors. Change-Id: I553fc65816827d0729049a2845bd0f46e46883d4 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommandCallback.java 1 file changed, 20 insertions(+), 65 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I553fc65816827d0729049a2845bd0f46e46883d4 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor CloneSingleCinderDiskCommand CB
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Refactor CloneSingleCinderDiskCommand CB ...................................................................... engine: Refactor CloneSingleCinderDiskCommand CB Refactor CloneSingleCinderDiskCommandCallBack to inherit from ConcurrentChildCommandsExecutionCallback to minimize code duplication and ease future refactors. Change-Id: I830eb4069c77ad8310ad042d741a37b290738598 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CloneSingleCinderDiskCommandCallback.java 1 file changed, 17 insertions(+), 45 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54122 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I830eb4069c77ad8310ad042d741a37b290738598 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add timeout wrappers in all u/s jobs
by eedri＠redhat.com 24 Apr '16

24 Apr '16

Eyal Edri has submitted this change and it was merged. Change subject: Add timeout wrappers in all u/s jobs ...................................................................... Add timeout wrappers in all u/s jobs - Set timeout to 360 minutes (6 hours) in defaults.yaml file, under "defaults" section Change-Id: I133d95d4c7834947f5c73197161f04758e554b9f Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M jobs/confs/projects/defaults.yaml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Shlomo Ben David: Verified; Ready for review Eyal Edri: Ready for merge Jenkins CI: Passed CI tests David Caro: Looks good to me -- To view, visit https://gerrit.ovirt.org/56161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I133d95d4c7834947f5c73197161f04758e554b9f Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor AddCinderDiskCommandCallback
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Refactor AddCinderDiskCommandCallback ...................................................................... engine: Refactor AddCinderDiskCommandCallback Refactor AddCinderDiskCommandCallback to inherit from ConcurrentChildCommandsExecutionCallback to minimize code duplication and ease future refactors. Change-Id: I97f54ce9f2afe290f7bf38d503706dd57f7a182a Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AddCinderDiskCommandCallback.java 1 file changed, 22 insertions(+), 53 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97f54ce9f2afe290f7bf38d503706dd57f7a182a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: RemoveSnapshotCommandCallback refactor
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: RemoveSnapshotCommandCallback refactor ...................................................................... engine: RemoveSnapshotCommandCallback refactor Use the generic callback for RemoveSnapshotCommand. Change-Id: I6a5e4578b58b94afb7e71b85a89bdf96c77d3060 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandCallback.java 2 files changed, 1 insertion(+), 68 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Freddy Rolland: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a5e4578b58b94afb7e71b85a89bdf96c77d3060 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: audit console's client ip change in vm-analyzer
by ahadas＠redhat.com 24 Apr '16

24 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: audit console's client ip change in vm-analyzer ...................................................................... core: audit console's client ip change in vm-analyzer There is no reason not to audit a change in console's client ip in VmAnalyzer. We do not call bll command so no need to put it in VdsEventListener. We do not do anything in a batch for all VMs reported on the same host so no need to do it in VmsMonitoring. Thus, moving it to VmAnalyzer. Change-Id: I5a9aafa9820582f11c6b70c1fb7e048c030f5591 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 5 files changed, 10 insertions(+), 33 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/56361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a9aafa9820582f11c6b70c1fb7e048c030f5591 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: introduce VmJob#toString
by ahadas＠redhat.com 24 Apr '16

24 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: introduce VmJob#toString ...................................................................... core: introduce VmJob#toString Adding toString method to VmJob in order to have it displayed the same way in all log printings. Change-Id: I75f6e24311060b0cbd912897679da1cca1b8f3e6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJob.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/56247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75f6e24311060b0cbd912897679da1cca1b8f3e6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix unsatisfied dependency in SchedulingManagerTest
by mperina＠redhat.com 22 Apr '16

22 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix unsatisfied dependency in SchedulingManagerTest ...................................................................... core: Fix unsatisfied dependency in SchedulingManagerTest Fixes unsatisfied dependency issue raised by patch I070c68d9377b8266f193c118c8b6dbfa979bd865. Change-Id: I1f3edc91699c1605171e1b4236d79a9f293f6448 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/CommonTestMocks.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f3edc91699c1605171e1b4236d79a9f293f6448 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in samples-uiplugins[master]: Cockpit UI Plugin for webadmin
by vszocs＠redhat.com 22 Apr '16

22 Apr '16

Vojtech Szocs has submitted this change and it was merged. Change subject: Cockpit UI Plugin for webadmin ...................................................................... Cockpit UI Plugin for webadmin With this plugin, the host main-tab shows new subtab embedding Cockpit which is running on the selected host. The host's right-click menu is enriched for new 'Cockpit' action leading to opening new browser window/tab with the host's Cockpit. When Cockpit is not running on the selected host, the menu action is disabled and the embedding subtab shows content of noCockpit.html page. See the README for more information. See cockpit.json for configuration. Change-Id: If70347aadcb30c14a0db05d9e9c4398cba09a05b Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- A cockpit-plugin/README.cockpit A cockpit-plugin/cockpit-resources/index.html A cockpit-plugin/cockpit-resources/noCockpit.html A cockpit-plugin/cockpit.json 4 files changed, 152 insertions(+), 0 deletions(-) Approvals: Marek Libra: Verified Vojtech Szocs: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If70347aadcb30c14a0db05d9e9c4398cba09a05b Gerrit-PatchSet: 2 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix NPE in SessionDataContainer during logout
by mperina＠redhat.com 22 Apr '16

22 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix NPE in SessionDataContainer during logout ...................................................................... core: Fix NPE in SessionDataContainer during logout Fixes NPE in SessionDataContainder during logout, which was caused by direct instantiation of SSOSessionUtils which contains CDI injected instance of JobDao. Change-Id: I070c68d9377b8266f193c118c8b6dbfa979bd865 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I070c68d9377b8266f193c118c8b6dbfa979bd865 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0