- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: ClusterManageNetworkPopupView type inference
by Code Review 27 Aug '17

27 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81071 ) Change subject: webadmin: ClusterManageNetworkPopupView type inference ...................................................................... webadmin: ClusterManageNetworkPopupView type inference Change-Id: I260ce77a6154da83203187c947c28ff3bd54461d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/81071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I260ce77a6154da83203187c947c28ff3bd54461d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ClusterManageNetworkPopupView diamond opetator
by Code Review 27 Aug '17

27 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81072 ) Change subject: webadmin: ClusterManageNetworkPopupView diamond opetator ...................................................................... webadmin: ClusterManageNetworkPopupView diamond opetator Change-Id: Ied603f8c08490f6fa234e828091c0d78fee27007 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/81072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied603f8c08490f6fa234e828091c0d78fee27007 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add support for env var requests in mock_runner
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80350 ) Change subject: Add support for env var requests in mock_runner ...................................................................... Add support for env var requests in mock_runner This patch adds support to specify "${stage}.environment.yaml" file, which includes requests for environmental vars (YAML) to be available inside mock's env. The vars are processed by 'secrets_client' so the request may contain a request for secret, or a request for a specified value. Example for such file: - name: VAR_NAME valueFrom: secretKeyRef: name: 'required secret name' key: 'required key from the secret specified above' - name: ANOTHER_VAR value: 'some custom value' Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-894 Change-Id: I89518d337a6c58a3f1952b82953b264e491a2634 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 43 insertions(+), 1 deletion(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified -- To view, visit https://gerrit.ovirt.org/80350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89518d337a6c58a3f1952b82953b264e491a2634 Gerrit-PatchSet: 12 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Staging Jenkins Server

1 0

Change in jenkins[master]: Migrate manual OST to a proper template
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80863 ) Change subject: Migrate manual OST to a proper template ...................................................................... Migrate manual OST to a proper template In order to use the manual job in D/S, we need to separate the job to a proper pair of template and project. Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1604 Change-Id: I113216f948ebb434c60a13556cd3b33a1f5aef98 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml A jobs/confs/yaml/parmeters/ost-input-customizations.yaml A jobs/confs/yaml/parmeters/ost-suite-selector-ovirt.yaml R jobs/confs/yaml/parmeters/ost-version-selector-ovirt.yaml M jobs/confs/yaml/templates/system_tests_templates.yaml 5 files changed, 99 insertions(+), 74 deletions(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I113216f948ebb434c60a13556cd3b33a1f5aef98 Gerrit-PatchSet: 17 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Fix docker login to match all versions of docker
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80966 ) Change subject: Fix docker login to match all versions of docker ...................................................................... Fix docker login to match all versions of docker Change-Id: Ib86c4218eb7e3ebe3cef112ab31cd50b8a61ba09 --- M jobs/confs/shell-scripts/collect_artifacts.sh 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib86c4218eb7e3ebe3cef112ab31cd50b8a61ba09 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>

1 0

Change in jenkins[master]: Modify cleanup_slave.sh not to remove docker DMs
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80806 ) Change subject: Modify cleanup_slave.sh not to remove docker DMs ...................................................................... Modify cleanup_slave.sh not to remove docker DMs This patch supposed to fix a bug where after removal of all device mappings that loop devices, docker fails to detect that it's device was removed. Instead of removing all device mappings and loop devices, we test if the device pool docker uses actually known by devicemapper. If it was deleted, we need to restart docker after removing /var/lib/docker. Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1600 Change-Id: If72c360bd717d001cd24d9e9514ea83ef812936e Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/shell-scripts/cleanup_slave.sh 1 file changed, 55 insertions(+), 3 deletions(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72c360bd717d001cd24d9e9514ea83ef812936e Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Correct label alignment in quota popups
by Code Review 26 Aug '17

26 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80983 ) Change subject: webadmin: Correct label alignment in quota popups ...................................................................... webadmin: Correct label alignment in quota popups This patch corrects the spacing of the "Limit to" labels and corresponding textboxes in the data center quota popups to prevent wrapping of the text in the de_DE locale. It also uppercases the first letter of the radio button label for consistency. ------------------- Screenshots: Before: Storage quota: http://imgur.com/a/MI36e CPU/Mem quota: http://imgur.com/a/TDREO After: Storage quota: http://imgur.com/a/VCuJO CPU/Mem quota: http://imgur.com/a/18A8I Change-Id: Ic7254587347398604cfd5d5880ad5b659822a2cf Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaStoragePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 3 files changed, 15 insertions(+), 7 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/80983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7254587347398604cfd5d5880ad5b659822a2cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: remove vms_check_no_timezone_set.sql
by Code Review 25 Aug '17

25 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81067 ) Change subject: inventory: remove vms_check_no_timezone_set.sql ...................................................................... inventory: remove vms_check_no_timezone_set.sql This is generic sql and duplicate: check_vms_windows_with_incorrect_timezone check_vms_linux_and_others_with_incorrect_timezone Change-Id: I0bb3f21056f34418c7fe5d18e6ea761d002f6c8c Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh D src/inventory_report/produceReport/sqls/vms_check_no_timezone_set.sql 4 files changed, 5 insertions(+), 41 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bb3f21056f34418c7fe5d18e6ea761d002f6c8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Improve table display for windows os without time...
by Code Review 25 Aug '17

25 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81066 ) Change subject: inventory: Improve table display for windows os without timezone ...................................................................... inventory: Improve table display for windows os without timezone - Added headers - Added entity_type='VM' Change-Id: I879f02650f6dee220634a57b20fde34d2885c322 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/sqls/vms_query_windows_vms_with_incorrect_timezone.sql 2 files changed, 38 insertions(+), 35 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I879f02650f6dee220634a57b20fde34d2885c322 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Improve table display for linux os without timezone
by Code Review 25 Aug '17

25 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81065 ) Change subject: inventory: Improve table display for linux os without timezone ...................................................................... inventory: Improve table display for linux os without timezone - Added headers - Added entity_type='VM' Change-Id: Id6f4d47c0e2006b513d73dd630a6385aebc3505e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/sqls/vms_query_linux_and_others_vms_with_incorrect_timezone.sql 2 files changed, 49 insertions(+), 47 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6f4d47c0e2006b513d73dd630a6385aebc3505e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0