- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: Load 'virtio-scsi' controller from OVF as 'scsi' controller.
by Code Review 25 Aug '17

25 Aug '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/80854 ) Change subject: Load 'virtio-scsi' controller from OVF as 'scsi' controller. ...................................................................... Load 'virtio-scsi' controller from OVF as 'scsi' controller. The engine stores 'virtio-scsi' controller to OVF, but vdsm and libvirt recognize only 'scsi' controller. The name is changed when loading from OVF. Change-Id: I9cd9ac11c77ac34bd5c647d0661289263bff74c0 Bug-Url: https://bugzilla.redhat.com/1479776 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml M ovirt_hosted_engine_ha/lib/ovf/ovf_test_max_vcpu.xml 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/80854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cd9ac11c77ac34bd5c647d0661289263bff74c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Fix return statement when starting the VM.
by Code Review 25 Aug '17

25 Aug '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/79320 ) Change subject: Fix return statement when starting the VM. ...................................................................... Fix return statement when starting the VM. Previously, the function would return None, which is convertible to False, but it should return True. This patch fixes it. Change-Id: I2dc4ebb6e133d2c52372158ca6574be758a1c5e0 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/79320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dc4ebb6e133d2c52372158ca6574be758a1c5e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: host-node: add ovirt-vmconsole-host-sshd to the preset
by Code Review 25 Aug '17

25 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/81016 ) Change subject: host-node: add ovirt-vmconsole-host-sshd to the preset ...................................................................... host-node: add ovirt-vmconsole-host-sshd to the preset Running RPM %post scripts on Node update means that we are hitting ovirt-vmconsole running 'systemctl preset ...' Add it to the preset as enabled so this works and it stays enabled on updates Change-Id: I8094111b6d0eaa25dea66ccb1614b31186ec0f14 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1484610 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M host-node/systemd/system-preset/98-ovirt-host-node.preset 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8094111b6d0eaa25dea66ccb1614b31186ec0f14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: host-node: add ovirt-vmconsole-host-sshd to the preset
by Code Review 25 Aug '17

25 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/81015 ) Change subject: host-node: add ovirt-vmconsole-host-sshd to the preset ...................................................................... host-node: add ovirt-vmconsole-host-sshd to the preset Running RPM %post scripts on Node update means that we are hitting ovirt-vmconsole running 'systemctl preset ...' Add it to the preset as enabled so this works and it stays enabled on updates Change-Id: I8094111b6d0eaa25dea66ccb1614b31186ec0f14 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1484610 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M host-node/systemd/system-preset/98-ovirt-host-node.preset 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8094111b6d0eaa25dea66ccb1614b31186ec0f14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix memory disks description
by Code Review 25 Aug '17

25 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80909 ) Change subject: core: Fix memory disks description ...................................................................... core: Fix memory disks description The creation memory disks description sets the 'desription' property which is not persisted in the DB and only used for retrieving the disk description from the storage Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: I21d6e448d09d6c037e8392e358a33762067d4e35 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21d6e448d09d6c037e8392e358a33762067d4e35 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Eyal Shenitzky <eshenitz(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Set memory disks description to include VM and snapsho...
by Code Review 25 Aug '17

25 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80977 ) Change subject: core: Set memory disks description to include VM and snapshot info ...................................................................... core: Set memory disks description to include VM and snapshot info Change-Id: I6abbdf34ed21c5adec8f3260ac19239865fcc372 Bug-Url: https://bugzilla.redhat.com/1483500 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java A packaging/dbscripts/upgrade/04_02_0530_update_memory_disks_description.sql 5 files changed, 33 insertions(+), 20 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6abbdf34ed21c5adec8f3260ac19239865fcc372 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Eyal Shenitzky <eshenitz(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Remove RPM build dependencies not needed
by Code Review 25 Aug '17

25 Aug '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. ( https://gerrit.ovirt.org/81032 ) Change subject: Remove RPM build dependencies not needed ...................................................................... Remove RPM build dependencies not needed This patch removes some build dependencies that aren't used during the RPM build process. Change-Id: Ida85427b7286ad8f0aeee6a7690845e4ce3340c9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit b9d456a1ba493dae68a310eb855a4f332eaa2e21) --- M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in M packaging/spec.fc25.in 4 files changed, 0 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/81032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida85427b7286ad8f0aeee6a7690845e4ce3340c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Remove RPM build dependencies not needed
by Code Review 25 Aug '17

25 Aug '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. ( https://gerrit.ovirt.org/81030 ) Change subject: Remove RPM build dependencies not needed ...................................................................... Remove RPM build dependencies not needed This patch removes some build dependencies that aren't used during the RPM build process. Change-Id: Ida85427b7286ad8f0aeee6a7690845e4ce3340c9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/spec.el7.in M packaging/spec.fc24.in M packaging/spec.fc25.in 3 files changed, 0 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida85427b7286ad8f0aeee6a7690845e4ce3340c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: check if postgres data exist in the sos
by Code Review 24 Aug '17

24 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81026 ) Change subject: inventory: check if postgres data exist in the sos ...................................................................... inventory: check if postgres data exist in the sos In case the sosreport doesn't contain the postgres data, exit and provide a message to users. Change-Id: Ia01aa082a8dbb777b872b992fc050ab7ac7ebf1d Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/unpackAndPrepareDump.sh 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81026 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia01aa082a8dbb777b872b992fc050ab7ac7ebf1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: spec: remove experimental repo
by Code Review 24 Aug '17

24 Aug '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/81020 ) Change subject: spec: remove experimental repo ...................................................................... spec: remove experimental repo Experimental repo is now deprecated, thus we're removing it. Change-Id: Ib2b3316aec886460225f3e4268186357383486cb Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M Makefile.am M configure.ac D ovirt-experimental.repo.in M ovirt-release-master.spec.in 4 files changed, 0 insertions(+), 63 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Sandro Bonazzola: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/81020 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2b3316aec886460225f3e4268186357383486cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0