- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Console related VmDynamic properties changed together
by ahadas＠redhat.com 19 Apr '16

19 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Console related VmDynamic properties changed together ...................................................................... core: Console related VmDynamic properties changed together VmDynamic business entity has 3 properties identifying: consoleCurrentUserName, consoleUserId and clientIp. Client IP address is updated when the user connects to and disconnects from console, "consoleUserId" is updated in SetVmTicketCommand and when VM is started. I.e. it survives console disconnection. Before this patch "consoleCurrentUserName" was set similarly as "consoleUserId" but also set to `null` during user disconnection form console. Thus after console disconnect "consoleCurrentUserName" did not correspond to "consoleUserId" This patch unifies behavior of "consoleCurrentUserName" and "consoleUserId" so that they both survives console disconnect. Frontend is altered to to behave the same way as before i.e. "Console User" is only showed if the user is actually connected. Change-Id: Iff69ffd09a252f24bd66981ffbde80830ef74e5b Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateVmView.java 6 files changed, 19 insertions(+), 15 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff69ffd09a252f24bd66981ffbde80830ef74e5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Host devices - driver column - backend
by ahadas＠redhat.com 19 Apr '16

19 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Host devices - driver column - backend ...................................................................... core: Host devices - driver column - backend * New column 'driver' in 'host_device' table + appropriate changes in DAO mappers, stored procedures, business entity and DAO tests. * Data are written in RefreshHostDevicesCommand and shown in 'Host Devices' subtabs - following frontend patch. Change-Id: I5cc4cdcbc5c54078d02d03a056fba62e390f3b5a Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDevice.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/host_device_sp.sql A packaging/dbscripts/upgrade/04_00_0500_hostdevice_add_column_driver.sql 8 files changed, 70 insertions(+), 7 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cc4cdcbc5c54078d02d03a056fba62e390f3b5a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: initialize DWHCoreEnv.ENABLE
by sbonazzo＠redhat.com 19 Apr '16

19 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: initialize DWHCoreEnv.ENABLE ...................................................................... packaging: setup: initialize DWHCoreEnv.ENABLE So that dev env does not fail without dwh installed. Change-Id: Ic9ba6d9a7982371721dabd4c599b455d94efcb5d Bug-Url: https://bugzilla.redhat.com/1318665 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/dwh_database.py 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9ba6d9a7982371721dabd4c599b455d94efcb5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix of exception while getting vv file
by tjelinek＠redhat.com 19 Apr '16

19 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: Fix of exception while getting vv file ...................................................................... restapi: Fix of exception while getting vv file "IllegalArgumentException: No enum constant org.ovirt.engine.api.model.GraphicsType.spice" was throw when vv file was requsted using REST api. The case was that conversion of string "spice" (decoded console id - 7370696365) was converted to actual instance of GraphicsType enum using #valueOf() isntead of custom #valueFrom(). Change-Id: I36ffbb0dea8b2d7c994718663ecebc508cce966f Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36ffbb0dea8b2d7c994718663ecebc508cce966f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Error hangling in BackendVmGraphicsConsoleResource
by tjelinek＠redhat.com 19 Apr '16

19 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: Error hangling in BackendVmGraphicsConsoleResource ...................................................................... restapi: Error hangling in BackendVmGraphicsConsoleResource The patch handles possible failure of ConfigureConsoleOptionsQuery called from method #generateDescriptor(). It may fail due to insufficient permissions. Standard error reporting can't be used here because it produces an explanatory reponse body and there is no MessageBodyWriter for 'application/x-virt-viewer' content type. Thus it would procude a HTML stacktrace about missing MessageBodyWriter. The error is logged and reported to client only using status code 500. Response body is empty. Change-Id: I1a22ba4f998dd317348393e6292614aedae3b8ec Bug-Url: https://bugzilla.redhat.com/1305600 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a22ba4f998dd317348393e6292614aedae3b8ec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: versionlock tools-backup
by tnisan＠redhat.com 19 Apr '16

19 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: versionlock tools-backup ...................................................................... packaging: setup: versionlock tools-backup To avoid an error when tyring to run 'yum update'. Bug-Url: https://bugzilla.redhat.com/1321249 Change-Id: I9c19cbf4d903f7871ee78b2e16e900cabdffeeee Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 0e3798e44abc3d84627cdb70e9e08637aca5e235) --- M packaging/setup/ovirt_engine_setup/constants.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c19cbf4d903f7871ee78b2e16e900cabdffeeee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: open Cockpit port in firewall
by tnisan＠redhat.com 19 Apr '16

19 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: open Cockpit port in firewall ...................................................................... core: open Cockpit port in firewall Cockpit will be the default administration interface in Node 4.0. The cockpit port (9090/tcp) should be added to the list of default ports to be opened, when the user decides to let engine manage the firewall fo the host. Change-Id: Ieef7fa196ae3459fb5d0697687d46b4747ce7860 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1314781 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieef7fa196ae3459fb5d0697687d46b4747ce7860 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal: use the default host that was set in vm in template
by tnisan＠redhat.com 19 Apr '16

19 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: use the default host that was set in vm in template ...................................................................... userportal: use the default host that was set in vm in template When creating a template from a vm that has a default host specified the host was not passed to the created template. The fix was in two layers: 1. UI - UserPortalListModel - populate the default host in the newly created template. 2. Backend - AddVmTemplateCommand - changed the permission check so that the user will be able to create a template from a vm with default host. Added tests. Change-Id: I65c7735e59b2056c341b35eaa9d6b840dc6608d7 Bug-Url: https://bugzilla.redhat.com/1284472 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit d2f5165) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 3 files changed, 53 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/56250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65c7735e59b2056c341b35eaa9d6b840dc6608d7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.6]: build: ovirt-engine-dwh-3.6.6
by Shirly Radco 19 Apr '16

19 Apr '16

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.6.6 ...................................................................... build: ovirt-engine-dwh-3.6.6 updated release notes Change-Id: I7a454f0e74559e3b8981c283d459cb5b8d6b6f52 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a454f0e74559e3b8981c283d459cb5b8d6b6f52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.6 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: update vm statistics through vm-manager
by ahadas＠redhat.com 19 Apr '16

19 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: update vm statistics through vm-manager ...................................................................... core: update vm statistics through vm-manager Changed places that updated VmStatistics directly using the DAO with calls to VmManager, to enable caching of the statistics in the VmManager instance. Change-Id: I827fc2929082467a52139e51c226fa3249e093b2 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java 2 files changed, 2 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56319 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I827fc2929082467a52139e51c226fa3249e093b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0