- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: moved the updateChangeability back to the Model
by tjelinek＠redhat.com 19 Apr '16

19 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: moved the updateChangeability back to the Model ...................................................................... frontend: moved the updateChangeability back to the Model It has been removed as a part of the cleanup of support for 3.5- versions but this method is useful by itself Change-Id: Ia24c4e1ecc616b869210691614f93d7f35f2527d Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia24c4e1ecc616b869210691614f93d7f35f2527d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant String initialization in VmDeviceComm...
by tnisan＠redhat.com 18 Apr '16

18 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant String initialization in VmDeviceCommonUtilsTest ...................................................................... core: Remove redundant String initialization in VmDeviceCommonUtilsTest Remove redundant new String("...") declaration as per Java's good practice Change-Id: Ieff6fd17c220ac1a0e52ba5e772210400c7776c2 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtilsTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieff6fd17c220ac1a0e52ba5e772210400c7776c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Only support VDSM 4.17
by sbonazzo＠redhat.com 18 Apr '16

18 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Only support VDSM 4.17 ...................................................................... core: Only support VDSM 4.17 Since we no longer support clusters older than 3.6, there's no point in supporting any VDSM version that isn't able to participate in such clusters. This patch removes support for all the old VDSM versions since 4.9 up to 4.16 (inclusive). Change-Id: Iffa247b763998832635b870a04602068c5fb13cc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffa247b763998832635b870a04602068c5fb13cc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: show temporary directory location
by sbonazzo＠redhat.com 18 Apr '16

18 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: show temporary directory location ...................................................................... show temporary directory location In case we fail on not enough disk space, we now show the location of the temporary directory as part of the message. Change-Id: If0abf9a1e599dc8d17468e1bbff2a24e3d537406 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1228149 --- M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0abf9a1e599dc8d17468e1bbff2a24e3d537406 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add maven profiles to build rpm on different systems
by juan.hernandez＠redhat.com 18 Apr '16

18 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add maven profiles to build rpm on different systems ...................................................................... Add maven profiles to build rpm on different systems This patch add new maven profiles, which will compile SDK based on httpclient version. Change-Id: Ibc291f6023ed4ab91b1c1aceec07afd61582de97 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- D packaging/ovirt-engine-sdk-java-4.0-el7support.patch M packaging/spec.el7.in M sdk/pom.xml M sdk/src/main/java/org/ovirt/engine/sdk4/ConnectionBuilder.java A sdk/src/main/java/org/ovirt/engine/sdk4/HttpClient.java A sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder42.java A sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder45.java A sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpClient42.java A sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpClient45.java M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java 10 files changed, 532 insertions(+), 529 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc291f6023ed4ab91b1c1aceec07afd61582de97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Added SearchQuery.searchImageTypes() method
by ahadas＠redhat.com 18 Apr '16

18 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Added SearchQuery.searchImageTypes() method ...................................................................... core: Added SearchQuery.searchImageTypes() method Search of ImageType entities in SearchQuery now uses a separate method searchImageTypes() instead of searchVmTemplates(). While it is identical to it now, this may be changed (like it was changed some time ago) and affect unintentially search of other entitites. Change-Id: I8150eb09086cf00281e6d46b3e2375293b43f73f Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56290 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8150eb09086cf00281e6d46b3e2375293b43f73f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use an existing unreg disk for copied template disks.
by mlipchuk＠redhat.com 18 Apr '16

18 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use an existing unreg disk for copied template disks. ...................................................................... core: Use an existing unreg disk for copied template disks. Add only an image storage domain map for a copied template disk if there is already a copied unregistered disk in the destination Storage Domain. Change-Id: Id6d3ebd65b427dfc6c3c01140bd39920aa22dac2 Bug-Url: https://bugzilla.redhat.com/1302780 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java 1 file changed, 39 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/56244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6d3ebd65b427dfc6c3c01140bd39920aa22dac2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Add links to SSH public keys
by tnisan＠redhat.com 18 Apr '16

18 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add links to SSH public keys ...................................................................... restapi: Add links to SSH public keys Currently the SSH public keys added to users don't have their links populated. This patch fixes that issue. Change-Id: I6d4cf76efa85e3acab6ab8d61c910de5cfb999fb Bug-Url: https://bugzilla.redhat.com/1324935 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d4cf76efa85e3acab6ab8d61c910de5cfb999fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: can not migrate vm using REST
by tjelinek＠redhat.com 18 Apr '16

18 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: can not migrate vm using REST ...................................................................... core: can not migrate vm using REST The regression introduced by 7d5f94d4c79ebc93cdfe08a7709a6411dda8fce7 The issue is that if the getParameters().getTargetClusterId() is null it means that the target cluster id is not set meaning the cluster did not change. In this case the additional permission does not have to be added. The problem was that if the getTargetClusterId was null the Objects.equals returned false so the additional permission has been added in a way that you need permission to create_vm on the cluster: null which did not pass. Change-Id: Ia0d6201c3d095beebffb47a6fb6beab5e5684b6f Bug-Url: https://bugzilla.redhat.com/1328011 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0d6201c3d095beebffb47a6fb6beab5e5684b6f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Backup ovirt-vmconsole conf and pki
by sbonazzo＠redhat.com 18 Apr '16

18 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Backup ovirt-vmconsole conf and pki ...................................................................... packaging: engine-backup: Backup ovirt-vmconsole conf and pki Change-Id: I8512db986297fb463b2643602a430a2d654a1774 Bug-Url: https://bugzilla.redhat.com/1328036 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8512db986297fb463b2643602a430a2d654a1774 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0