- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: cleanup old event notification history
by tnisan＠redhat.com 12 Apr '16

12 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: cleanup old event notification history ...................................................................... core: cleanup old event notification history Description of the problem: Customer is recording each login/logout from the system and sends notifications on those events, in the database there are more than 0.5 Million of records for both audit_log and event_notification_hist tables. engine_357=# select count(*) from public.event_notification_hist; count -------- 540260 (1 row) engine_357=# select count(*) from public.audit_log; count -------- 540250 (1 row) The validatedb.sh script validates that there is no data that violates Foreign Keys. As part of this validation, the following query is generated and executed : select (audit_log_id) from public.event_notification_hist where (audit_log_id) IS NOT NULL and (audit_log_id) not in ( select audit_log_id from public.audit_log); This is a very heavy query considering table sizes above and I can understand why it expands from 1.5 hours to 7 hours, simply because both tables keep on growing One reason for this slow query is luck of suitable index on event_notification_hist Engine has a scheduler job that cleans records older than 30 days. By checking why the audit_log and event_notification_history have records older than 30 days I found that the cleanup mechanism skips records that their audit_log_id exists in event_notification_history. This caused the audit_log to include records older than 30 days and event_notification_history not to be cleaned ever, making the upgrade heavier from version to version as records grows. This patch 1) Adds the missing index on event_notification_history so the FK validation will use index and not do a table scan on such large tables. 2) Modify the cleanup mechanism to delete all old records, since event_notification_history has a FK with DELETE CASCADE on audit_log, it will be cleaned up as well. 3) Fix some broken tests Patch was validated on the customer problematic DB and solved the problem. Change-Id: Ib93c1a37b0838d9020ca4f8a300346b3fe3b87f0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1324733 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/audit_log_sp.sql A packaging/dbscripts/upgrade/03_06_2100_add_index_event_notification_hist.sql 4 files changed, 160 insertions(+), 155 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93c1a37b0838d9020ca4f8a300346b3fe3b87f0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Adding UI read-only feature for external networks
by alkaplan＠redhat.com 12 Apr '16

12 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Adding UI read-only feature for external networks ...................................................................... webadmin: Adding UI read-only feature for external networks Change-Id: Ia7f5cddf01acebfa3379cffc4ae237fb6d6cbef4 Signed-off-by: mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1314375 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml 4 files changed, 38 insertions(+), 7 deletions(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7f5cddf01acebfa3379cffc4ae237fb6d6cbef4 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Adding UI read-only feature for external networks
by alkaplan＠redhat.com 12 Apr '16

12 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adding UI read-only feature for external networks ...................................................................... engine: Adding UI read-only feature for external networks Change-Id: Ib123d1f326c347fed676cadf6a25b1ce3839f773 Bug-Url: https://bugzilla.redhat.com/1314375 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalNetworkProviderProperties.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoImpl.java M packaging/dbscripts/providers_sp.sql A packaging/dbscripts/upgrade/04_00_0440_add_read_only_in_providers.sql 4 files changed, 31 insertions(+), 7 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib123d1f326c347fed676cadf6a25b1ce3839f773 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: build: post ovirt-host-deploy-1.5.0_alpha1
by sbonazzo＠redhat.com 12 Apr '16

12 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-host-deploy-1.5.0_alpha1 ...................................................................... build: post ovirt-host-deploy-1.5.0_alpha1 Change-Id: I6e19e5b2a306e42850f193316326b0ce45b3bd94 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56017 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e19e5b2a306e42850f193316326b0ce45b3bd94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: build: ovirt-host-deploy-1.5.0_alpha1
by sbonazzo＠redhat.com 12 Apr '16

12 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-host-deploy-1.5.0_alpha1 ...................................................................... build: ovirt-host-deploy-1.5.0_alpha1 Change-Id: I1d8ff17d86148746bce85eb27ba68137dc414b6f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d8ff17d86148746bce85eb27ba68137dc414b6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Use proper method to render primitive types
by juan.hernandez＠redhat.com 12 Apr '16

12 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use proper method to render primitive types ...................................................................... Use proper method to render primitive types Previously we render primitive types to string with String.valueOf method, but it's not correct. Now we use XmlWriter.render to properly render those strings. Change-Id: I7f9acd54e665eb1df82bfef25468e88d008eb7a4 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java M pom.xml 2 files changed, 45 insertions(+), 43 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f9acd54e665eb1df82bfef25468e88d008eb7a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Add External Network Provider to list of providers
by alkaplan＠redhat.com 12 Apr '16

12 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add External Network Provider to list of providers ...................................................................... webadmin: Add External Network Provider to list of providers External Network provider is a new type of external provider is oVirt. The UI must be modified to accomodate it, and an appropriate model must be added. Several classes in this patch are still empty (like ExternalNetworkProviderProperties), they will be filled with content when subsequent features for external networks will be added. Change-Id: I66e6898b273afab2333af950e186e2d970e89875 Signed-off-by: mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1314375 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java 6 files changed, 42 insertions(+), 17 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66e6898b273afab2333af950e186e2d970e89875 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: improve repo images sort
by amureini＠redhat.com 12 Apr '16

12 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: improve repo images sort ...................................................................... webadmin: improve repo images sort This patch improves the sort of repo images to take into consideration file names that contain version numbers. This way, a file named RHEV_3.5.10.iso will come after a file named RHEV_3.5.5.iso and not before it. Change-Id: Ifbe73d968c93924309f55ec05b42f9b6f363cc56 Bug-Url: https://bugzilla.redhat.com/1279398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/55948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbe73d968c93924309f55ec05b42f9b6f363cc56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: fix group's permissions removal
by mperina＠redhat.com 12 Apr '16

12 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: fix group's permissions removal ...................................................................... aaa: fix group's permissions removal Commit - Ica8610e4cf613629c0fbc0a8d7414598a8bbd899 introduced regression which disabled removal of permission assigned to a group. This patch fixes it. Change-Id: I621dcf89e71062c7bc5b315f085135805d39f1b9 Bug-Url: https://bugzilla.redhat.com/1302034 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I621dcf89e71062c7bc5b315f085135805d39f1b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use method parameter of storage domain id
by mlipchuk＠redhat.com 12 Apr '16

12 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use method parameter of storage domain id ...................................................................... core: Use method parameter of storage domain id Use storageDomainId parameter instead of calling getStorageDomainId() Change-Id: I01f5218a219cea543b77b69dda5b266b67681246 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/55959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01f5218a219cea543b77b69dda5b266b67681246 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0