- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove redundant method in AbstractDiskVmCommand
by tnisan＠redhat.com 11 Apr '16

11 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant method in AbstractDiskVmCommand ...................................................................... core: Remove redundant method in AbstractDiskVmCommand The method getLUNStorageType was only used in tests and thus removed Change-Id: Ib281871a0873c204a71ce93bec46f825c0842e92 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 2 files changed, 0 insertions(+), 46 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib281871a0873c204a71ce93bec46f825c0842e92 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change method name in AbstractDiskVmCommand
by tnisan＠redhat.com 11 Apr '16

11 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change method name in AbstractDiskVmCommand ...................................................................... core: Change method name in AbstractDiskVmCommand The method isDiskExist name is misleading since we are testing not only the disk existence but also whether it's attached to the VM, the method name was changed to reflect that Change-Id: Icf6f40d43a6b9eac44eb51234e3f53296f96e56e Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf6f40d43a6b9eac44eb51234e3f53296f96e56e Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add VM name and disk name to disk attachment to VM val...
by tnisan＠redhat.com 11 Apr '16

11 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add VM name and disk name to disk attachment to VM validation ...................................................................... core: Add VM name and disk name to disk attachment to VM validation Change-Id: I1af97fc3c54fa240a97aca9940dbbbb6f5d65f91 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 17 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1af97fc3c54fa240a97aca9940dbbbb6f5d65f91 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: QXL as default for VNC
by ahadas＠redhat.com 11 Apr '16

11 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: QXL as default for VNC ...................................................................... core: QXL as default for VNC >From 4.0, the default VNC driver is QXL (cirrus for a <v4.0 cluster). With this patch, the osinfo-defaults is updated for 4.0 leading to: - displaying VNC / [QXL|VGA] in Edit VM dialog - QXL as a default for VNC in Add Vm REST action The VNC driver is automatically updated from Cirrus to QXL on: - cluster upgrade (i.e. from 3.6 to 4.0, UpdateClusterCommand) by calling UpdateVmCommand for all cluster VMs - import from OVF originating in previous cluster version There's no change for cluster compatibility version < 4.0. Change-Id: I5a98e38476d855a1a684750d7af10f9159618280 Bug-Url: https://bugzilla.redhat.com/1302657 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M packaging/conf/osinfo-defaults.properties 6 files changed, 73 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a98e38476d855a1a684750d7af10f9159618280 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use streaming API in DiskValidator isDiskAttachedToVm
by tnisan＠redhat.com 11 Apr '16

11 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Use streaming API in DiskValidator isDiskAttachedToVm ...................................................................... core: Use streaming API in DiskValidator isDiskAttachedToVm Change-Id: I099087d429af40ab1d9e84d44f40a65967cfe2e2 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I099087d429af40ab1d9e84d44f40a65967cfe2e2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change validation message on disk attachment to VM val...
by tnisan＠redhat.com 11 Apr '16

11 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change validation message on disk attachment to VM validation ...................................................................... core: Change validation message on disk attachment to VM validation The validation on whether a disk is attached to a VM returned a message saying that the disk does not exist when it was not attached to the VM since this message is confusing and not accurate a new message was added for this scenario Change-Id: I4713bc155d098a627d768f37180c12c78d480fa2 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4713bc155d098a627d768f37180c12c78d480fa2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Extract disk attached to VM check to disk validator
by tnisan＠redhat.com 11 Apr '16

11 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Extract disk attached to VM check to disk validator ...................................................................... core: Extract disk attached to VM check to disk validator Change-Id: I461dedd5dbe282e520e01acaf1868dc1202884e0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java 4 files changed, 33 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I461dedd5dbe282e520e01acaf1868dc1202884e0 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Extract disk existence check to disk validator
by tnisan＠redhat.com 11 Apr '16

11 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Extract disk existence check to disk validator ...................................................................... core: Extract disk existence check to disk validator Change-Id: If70a0edc1fd566347275627101ad28a98953fa60 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If70a0edc1fd566347275627101ad28a98953fa60 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Pull down method in AbstractDiskVmCommand
by tnisan＠redhat.com 11 Apr '16

11 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Pull down method in AbstractDiskVmCommand ...................................................................... core: Pull down method in AbstractDiskVmCommand The method isVmNotLocked is only used in AddDiskCommand and thus pulled down, the null check was removed since the VM cannot be null when the method is invoked Change-Id: I592050a458f7c4af9856c674c2dc28a9751a7933 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java 2 files changed, 2 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I592050a458f7c4af9856c674c2dc28a9751a7933 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Extract check for floating disk in AddDiskCommand
by tnisan＠redhat.com 11 Apr '16

11 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Extract check for floating disk in AddDiskCommand ...................................................................... core: Extract check for floating disk in AddDiskCommand The check whether a disk is floating (i.e. will not be attached to a VM) is repeated 3 times within the class and was extracted to a method for better readability The method isVmExist() was inlined as well as the terminology there is confusing since the method checks whether the VM exists only in case of a non floating disk Change-Id: Ib836b82389f45de2b206fbf67e1ea8e7e36935c8 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib836b82389f45de2b206fbf67e1ea8e7e36935c8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0