- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: TransportFactory generics
by amureini＠redhat.com 10 Apr '16

10 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: TransportFactory generics ...................................................................... core: TransportFactory generics Remove explicit generics specifications, as Java 8 is able to infer the return types, making the code easier to read. Change-Id: I25d704cd7995315e14fc4406b45c68255c589237 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/TransportFactory.java 1 file changed, 18 insertions(+), 18 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25d704cd7995315e14fc4406b45c68255c589237 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Pull up close to IIrsServer
by amureini＠redhat.com 10 Apr '16

10 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Pull up close to IIrsServer ...................................................................... core: Pull up close to IIrsServer JsonRpcIIrsServer already has a close() method, while IrsServerWrapper does not, forcing IrsProxyData to use run time type recognition and downcasting to understand how to shut its connection down. This patch pulls up the close() method to the IIrsServer interface in order to allow IrsProxyData to close it in a more Java-ish fashion. As a side effect of this refactoring, the getHttpClient() can now be removed (as it indeed was), as it's no longer needed externally. This fact strengthens the conviction that adding the close() method was the right thing to do, as now IrsServerWrapper no longer needs to expose its internal implementation details beyond receiving an HttpClient instance when its constructed. Change-Id: Ia7335536bdcf1ec51b4e941f710f46994043172f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 4 files changed, 8 insertions(+), 10 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7335536bdcf1ec51b4e941f710f46994043172f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Don't overwrite local domain's format
by amureini＠redhat.com 10 Apr '16

10 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't overwrite local domain's format ...................................................................... core: Don't overwrite local domain's format ensureStorageFormatInitialized(), called from AddStorageDomainCommand#validate() already takes care of calculating the correct format for the domain. Overwriting in in AddLocalStorageDomainCommand is at best just redundant (for data domains) and at worst just plain wrong (for export and iso domains). Change-Id: Iead537b06ce234f41ccb399d757eff442c5342e4 Bug-Url: https://bugzilla.redhat.com/1323462 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/55836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iead537b06ce234f41ccb399d757eff442c5342e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: restructuring proceedDownVm
by ahadas＠redhat.com 10 Apr '16

10 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: restructuring proceedDownVm ...................................................................... core: restructuring proceedDownVm 1. Early return if the status of the VM is not down to reduce nested levels 2. Do the destroy first, then continue with other processing 3. This method handles 3 cases: - hibernation (SavingState -> Down) - failure in migration source (MigratingFrom -> Down) - other cases (* -> Down) A switch-case representation is more declarative for that. Change-Id: Ib4377a0bafbbfc32dd5b3b7ccc0f843d462be8e6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 33 insertions(+), 25 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4377a0bafbbfc32dd5b3b7ccc0f843d462be8e6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor refactoring in vm-analyze
by ahadas＠redhat.com 10 Apr '16

10 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in vm-analyze ...................................................................... core: minor refactoring in vm-analyze 1. Replace if-else statements with easier to read syntax in the proceedDisappearedVm. 2. Remove redundant variables in handleVmOnDown 3. Remove the arguments of auditVmOnDownEvent 4. Remove redundant check: if dbVm == null in inMigrationTo method, then its run_on_vds in the database is definitely different than the monitored host, no need to check that. Change-Id: I040a5561e96d07d2fb625852ad51a51a9376cf8a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 22 insertions(+), 18 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I040a5561e96d07d2fb625852ad51a51a9376cf8a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: dropped <= 3.4 compatibility
by sbonazzo＠redhat.com 08 Apr '16

08 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: dropped <= 3.4 compatibility ...................................................................... packaging: spec: dropped <= 3.4 compatibility Change-Id: If95df692a874d808bd997787d3ab82b9b6b7f074 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 0 insertions(+), 41 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If95df692a874d808bd997787d3ab82b9b6b7f074 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: UI plugin API - engineBaseUrl
by vszocs＠redhat.com 08 Apr '16

08 Apr '16

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: UI plugin API - engineBaseUrl ...................................................................... webadmin: UI plugin API - engineBaseUrl Added new UI plugin API function to obtain Engine base URL. API signature: engineBaseUrl() Example usage: // returns something like: // https://example.com:8443/ovirt-engine/ api.engineBaseUrl() UI plugins can use this function to construct Engine URLs. Change-Id: I9d2258d646bf93e81b15ce7ca9f03bebc89a6696 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/55694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d2258d646bf93e81b15ce7ca9f03bebc89a6696 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Avoid C90 warnings
by juan.hernandez＠redhat.com 08 Apr '16

08 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Avoid C90 warnings ...................................................................... Avoid C90 warnings Compiling the C extension with the C90 standard generates some warnings due to the use of declaration and assignment in the same statement. This patch changes the code to avoid them. Change-Id: Ifce6ed0a58e36c0e71836b0d675889e841e99a56 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ext/ovirtsdk4c/ov_xml_reader.c M sdk/ext/ovirtsdk4c/ov_xml_writer.c 2 files changed, 72 insertions(+), 41 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifce6ed0a58e36c0e71836b0d675889e841e99a56 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Use httpclient version 4.5
by juan.hernandez＠redhat.com 08 Apr '16

08 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use httpclient version 4.5 ...................................................................... Use httpclient version 4.5 This patch add support for httpclient version 4.5. Also clean some parts of unused code Change-Id: Ie6695191621edf25535a7ca027e3ac1650af7f58 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M sdk/pom.xml M sdk/src/main/java/org/ovirt/engine/sdk/ConnectionBuilder.java M sdk/src/main/java/org/ovirt/engine/sdk/internal/HttpConnection.java 4 files changed, 17 insertions(+), 74 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6695191621edf25535a7ca027e3ac1650af7f58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add rake-compiler to the .gemspec file
by juan.hernandez＠redhat.com 08 Apr '16

08 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add rake-compiler to the .gemspec file ...................................................................... Add rake-compiler to the .gemspec file This patch adds the requirement for the "rake-compiler" gem to the .gemspec file, as that gem is required to build the C extension. Change-Id: Ic44432183d008c3e7283e05da3e015e7e8d0ba03 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ovirt-engine-sdk.gemspec 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic44432183d008c3e7283e05da3e015e7e8d0ba03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0