- Engine-commits - oVirt List Archives

Change in ovirt-host-deploy[master]: deploy: rename OVIRT_NODE to OVIRT_VINTAGE_NODE
by sbonazzo＠redhat.com 07 Apr '16

07 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: deploy: rename OVIRT_NODE to OVIRT_VINTAGE_NODE ...................................................................... deploy: rename OVIRT_NODE to OVIRT_VINTAGE_NODE Rename OVIRT_NODE to OVIRT_VINTAGE_NODE in order to add NGN as OVIRT_NODE Change-Id: If3afd28467bb65b19a8d79f91cb94fa21e68cb6b Signed-off-by: emesika <emesika(a)redhat.com> --- M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-deploy/gluster/packages.py M src/plugins/ovirt-host-deploy/kdump/packages.py M src/plugins/ovirt-host-deploy/node/detect.py M src/plugins/ovirt-host-deploy/node/persist.py M src/plugins/ovirt-host-deploy/tune/tuned.py M src/plugins/ovirt-host-deploy/vdsm/bridge.py M src/plugins/ovirt-host-deploy/vdsm/config.py 8 files changed, 28 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3afd28467bb65b19a8d79f91cb94fa21e68cb6b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Added permissions on AddProfileBase
by rgolan＠redhat.com 07 Apr '16

07 Apr '16

Roy Golan has submitted this change and it was merged. Change subject: core: Added permissions on AddProfileBase ...................................................................... core: Added permissions on AddProfileBase When adding Disk/Cpu Profile there is always a need to add permissions on the profile. For that reason, I added an abstract method addPermissions() that will run each time add profile command is executed. This method will be implemented by the add Disk/CPU profile commands with the necessary permissions. The developer may cancel the automatic call of addPermissions by giving false in the constructor. Also, Create/Update/Remove and 'Assign' permissions are given to the user that created the profile and 'Assign' permissions to everyone else. Also, this patch changes the way the CPU Profile is added when running the 'AddClusterCommand'. Instead of adding the CPU Profile directly to the Database which bypasses all the necessary validations, this patch uses the 'AddCpuProfileCommand'. Change-Id: I6f65daf1e46be9521e8541932ce84710175a6c66 Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddClusterCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CpuProfileParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProfileParametersBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfilesResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/CpuProfileBaseModel.java A packaging/dbscripts/upgrade/04_00_0410_updating_cpu_profile_roles.sql 13 files changed, 427 insertions(+), 21 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f65daf1e46be9521e8541932ce84710175a6c66 Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Fix pyflakes error (image variable shadows imported module)
by msivak＠redhat.com 07 Apr '16

07 Apr '16

Martin Sivák has submitted this change and it was merged. Change subject: Fix pyflakes error (image variable shadows imported module) ...................................................................... Fix pyflakes error (image variable shadows imported module) Change-Id: I48898ec895ab3bdf3fc56ac1119acab60c940a09 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48898ec895ab3bdf3fc56ac1119acab60c940a09 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to version 4.0.12 of model and 1.0.7 of meta...
by juan.hernandez＠redhat.com 07 Apr '16

07 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to version 4.0.12 of model and 1.0.7 of metamodel ...................................................................... restapi: Update to version 4.0.12 of model and 1.0.7 of metamodel This patch updates the engine so that it uses the latest released versions of the model and the metamodel. Change-Id: I2d193cf5a80c8bd01099570904e05f2815269fd1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M pom.xml 3 files changed, 27 insertions(+), 34 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d193cf5a80c8bd01099570904e05f2815269fd1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-reports: move master to standard ci
by sbonazzo＠redhat.com 07 Apr '16

07 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-reports: move master to standard ci ...................................................................... ovirt-reports: move master to standard ci Change-Id: Ie841938abd8acf44f8a67fde9a9a2d52ec85640b Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Shirly Radco: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie841938abd8acf44f8a67fde9a9a2d52ec85640b Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: IrsProxyData.proceedStorageDomain() - clearer names
by laravot＠redhat.com 07 Apr '16

07 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: core: IrsProxyData.proceedStorageDomain() - clearer names ...................................................................... core: IrsProxyData.proceedStorageDomain() - clearer names The code of IrsProxyData.proceedStorageDomain() is complex, the confusing variable names doesn't make it easier to go over it. This patch renames to variables to hopefuly clearer names. Change-Id: I6e0c6ebc486a87b89a4bc9072d2e159ba8e0b064 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 34 insertions(+), 34 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/55793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e0c6ebc486a87b89a4bc9072d2e159ba8e0b064 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: IrsProxyData.proceedStorageDomain() - assignment
by laravot＠redhat.com 07 Apr '16

07 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: core: IrsProxyData.proceedStorageDomain() - assignment ...................................................................... core: IrsProxyData.proceedStorageDomain() - assignment There's no need for the separation of the decleration/assignment of domainFromDb/domainPoolMap. Change-Id: Ic775c145f51fcfaa4542770cb7245792baea90bb Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/55792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic775c145f51fcfaa4542770cb7245792baea90bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: BackendTemplateDiskResource.copy() - pass the disk id
by tnisan＠redhat.com 07 Apr '16

07 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: BackendTemplateDiskResource.copy() - pass the disk id ...................................................................... restapi: BackendTemplateDiskResource.copy() - pass the disk id Currently the callers of MoveOrCopyDisk command always pass the disk id to the command, an exception is BackendTemplateDiskResource.copy(). This patch set the disk id on the passed parameters. Change-Id: Ia99e06feb7d67769c2d831a140e869d8d7116744 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1324363 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Passed CI tests Ori Liel: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/55727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia99e06feb7d67769c2d831a140e869d8d7116744 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove redundant unlock call in image upload failure.
by derez＠redhat.com 07 Apr '16

07 Apr '16

Daniel Erez has submitted this change and it was merged. Change subject: core: remove redundant unlock call in image upload failure. ...................................................................... core: remove redundant unlock call in image upload failure. In BaseImagesCommand, Calling unLockImage() only calls setImageStatus(ImageStatus.OK). since in image upload failure handling we are calling setImageStatus(ImageStatus.ILLEGAL) right after unLockImage(), there is no point calling unLockImage(). Change-Id: I12f9dc64e1ef14d655120251334ea1dc0be74c77 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/55624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12f9dc64e1ef14d655120251334ea1dc0be74c77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.5]: webadmin: fix memory leak in alerts / events footer
by tnisan＠redhat.com 07 Apr '16

07 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix memory leak in alerts / events footer ...................................................................... webadmin: fix memory leak in alerts / events footer Fixed a large memory leak in alerts and events footer. Each table has a 'dismiss' column and cell. The cells were holding references to ModelProviders, which created a circular reference. These tables also update every 5 seconds, so that was a ton of DOM nodes that were detached and not GC-able. Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33 Bug-Url: https://bugzilla.redhat.com/1294678 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> (cherry picked from commit c6c6a37c0cfbf7aaa770a4bba03ceddaa26c1cc0) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java 5 files changed, 54 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0