- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Remove GenericApiGWTService.getLoggedIn...
by vszocs＠redhat.com 06 Apr '16

06 Apr '16

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Remove GenericApiGWTService.getLoggedInUser ...................................................................... webadmin,userportal: Remove GenericApiGWTService.getLoggedInUser Removed unused getLoggedInUser() method from GWT RPC interface. Change-Id: Ie4dd72a6b91557757f2b237b145ace818c2556e2 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 2 files changed, 9 insertions(+), 32 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/53138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4dd72a6b91557757f2b237b145ace818c2556e2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix memory leak in alerts / events footer
by gshereme＠redhat.com 06 Apr '16

06 Apr '16

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: fix memory leak in alerts / events footer ...................................................................... webadmin: fix memory leak in alerts / events footer Fixed a large memory leak in alerts and events footer. Each table has a 'dismiss' column and cell. The cells were holding references to ModelProviders, which created a circular reference. These tables also update every 5 seconds, so that was a ton of DOM nodes that were detached and not GC-able. Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33 Bug-Url: https://bugzilla.redhat.com/1294678 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java 5 files changed, 54 insertions(+), 37 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mordechai Lehrer <mlehrer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: frontend Optional<T>
by mbetak＠redhat.com 06 Apr '16

06 Apr '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: frontend Optional<T> ...................................................................... webadmin: frontend Optional<T> Lightweight imimation of Java 8 java.util.Optional Change-Id: I690c20da8f44f10b0c7ef3965e31414e9db11244 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/Optional.java 1 file changed, 73 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I690c20da8f44f10b0c7ef3965e31414e9db11244 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: MigrationPoliciesSupported config value added
by ahadas＠redhat.com 06 Apr '16

06 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: MigrationPoliciesSupported config value added ...................................................................... core: MigrationPoliciesSupported config value added Configuration value enabling advanced migration settings: bandwidth, policies. Enabled since 4.0. Change-Id: I87a19679bcda0cb65f82834e2c85f9652676fd95 Bug-Url: https://bugzilla.redhat.com/1252426 Feature-Page: http://www.ovirt.org/Features/Migration_Enhancements Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 16 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87a19679bcda0cb65f82834e2c85f9652676fd95 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[master]: Make ovirt-engine-cli more portable: - replace sys.platform ...
by juan.hernandez＠redhat.com 06 Apr '16

06 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Make ovirt-engine-cli more portable: - replace sys.platform with os.name posix ...................................................................... Make ovirt-engine-cli more portable: - replace sys.platform with os.name posix Tested on OpenBSD. Change-Id: I721c51df0ec5f1ccb78b621535d87185c15ce799 Bug-Url: https://bugzilla.redhat.com/1304643 Signed-off-by: Jiri Belka <jbelka(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/cli/platform/__init__.py M src/ovirtcli/platform/__init__.py M src/ovirtcli/platform/windows/__init__.py 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I721c51df0ec5f1ccb78b621535d87185c15ce799 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Jiri Belka <jbelka(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging:added ant to automation
by Shirly Radco 06 Apr '16

06 Apr '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging:added ant to automation ...................................................................... packaging:added ant to automation Change-Id: I679f73699048d2f5310068965193285c23ba94b1 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M automation/build-artifacts.packages M automation/check-merged.packages M automation/check-patch.packages 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I679f73699048d2f5310068965193285c23ba94b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.5]: core: Added permissions to Power User
by tnisan＠redhat.com 06 Apr '16

06 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Added permissions to Power User ...................................................................... core: Added permissions to Power User Added permission to 'Attach Disk Profile' to Power User. Change-Id: If17d5bc09c60e3ab6b22e40260f82222ded25c3d Bug-Url: https://bugzilla.redhat.com/1311052 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> (cherry picked from commit be9724556fbc82de3a171acc5a2df335ce5b22e2) --- A packaging/dbscripts/upgrade/03_06_2090_add_attach_disk_profile_permissions_to_power_user_role.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If17d5bc09c60e3ab6b22e40260f82222ded25c3d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase - end step for commands with callbacks
by laravot＠redhat.com 06 Apr '16

06 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - end step for commands with callbacks ...................................................................... core: CommandBase - end step for commands with callbacks After command with callback endAction() is executed its execution and finalizing steps should end to reflect the actual status. Change-Id: I64d78be669e4ce08981dff15691f76af236ab2e3 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64d78be669e4ce08981dff15691f76af236ab2e3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: reducing race - avoid syncing the storage domain statu...
by tnisan＠redhat.com 06 Apr '16

06 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: reducing race - avoid syncing the storage domain status when its in process ...................................................................... core: reducing race - avoid syncing the storage domain status when its in process This patch reduce the chance of encountering a race condition, currently we have a chance of encountring concurrent modifications to the storage domain status [1] - Operation on the domain [2] - Timer that executes every few seconds GetStoragePoolInfo on the SPM host and updates the domain data/pool metadata in the DB to match the data retrieved from the SPM. Those two process aren't synchronized which is problematic. The problem increased when different statuses were added to indicate the operation performed on the domain but the code in the timer ([2]) wasn't update. As a first step for this patch makes [2] aware of this status which should reduce drastically the chance for the race condition which is the condition we lived with so far, looking forward we should look into improve that code and check the necessity of it (as in V4 we'll no longer support any DC version with the pool metadata on storage). Change-Id: I7080b74770e1b192ea03798f4afb7143a5f5a796 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1311121 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/55726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7080b74770e1b192ea03798f4afb7143a5f5a796 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup old event notification history
by emesika＠redhat.com 06 Apr '16

06 Apr '16

Eli Mesika has submitted this change and it was merged. Change subject: core: cleanup old event notification history ...................................................................... core: cleanup old event notification history Description of the problem: Customer is recording each login/logout from the system and sends notifications on those events, in the database there are more than 0.5 Million of records for both audit_log and event_notification_hist tables. engine_357=# select count(*) from public.event_notification_hist; count -------- 540260 (1 row) engine_357=# select count(*) from public.audit_log; count -------- 540250 (1 row) The validatedb.sh script validates that there is no data that violates Foreign Keys. As part of this validation, the following query is generated and executed : select (audit_log_id) from public.event_notification_hist where (audit_log_id) IS NOT NULL and (audit_log_id) not in ( select audit_log_id from public.audit_log); This is a very heavy query considering table sizes above and I can understand why it expands from 1.5 hours to 7 hours, simply because both tables keep on growing One reason for this slow query is luck of suitable index on event_notification_hist Engine has a scheduler job that cleans records older than 30 days. By checking why the audit_log and event_notification_history have records older than 30 days I found that the cleanup mechanism skips records that their audit_log_id exists in event_notification_history. This caused the audit_log to include records older than 30 days and event_notification_history not to be cleaned ever, making the upgrade heavier from version to version as records grows. This patch 1) Adds the missing index on event_notification_history so the FK validation will use index and not do a table scan on such large tables. 2) Modify the cleanup mechanism to delete all old records, since event_notification_history has a FK with DELETE CASCADE on audit_log, it will be cleaned up as well. Patch was validated on the customer problematic DB and solved the problem. Change-Id: Ib93c1a37b0838d9020ca4f8a300346b3fe3b87f0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1323826 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/audit_log_sp.sql A packaging/dbscripts/upgrade/04_00_0420_add_index_event_notification_hist.sql 2 files changed, 5 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93c1a37b0838d9020ca4f8a300346b3fe3b87f0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0