- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Inline MoveOrCopyTemplateCommand#getImagesActionType
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Inline MoveOrCopyTemplateCommand#getImagesActionType ...................................................................... core: Inline MoveOrCopyTemplateCommand#getImagesActionType As MoveOrCopyTemplateCommand#getImagesActionType now returns a constant VdcActionType.CopyImageGroup, there's no reason to have it as a method. This patch inlines this method and replaces it with its implementation in order to clean up the code and make it easier to read. Change-Id: I7fd646d87a46ba9c0b141c8df36b161e1b9ee132 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java 3 files changed, 4 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fd646d87a46ba9c0b141c8df36b161e1b9ee132 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove MoveOrCopyTemplateCommand#getImages()
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove MoveOrCopyTemplateCommand#getImages() ...................................................................... core: Remove MoveOrCopyTemplateCommand#getImages() MoveOrCopyTemplateCommand#getImages() was used by ImportVmTemplateCommand and ImportVmTemplateFromConfigurationCommand. However, both these commands override it, so there's no reason to have a dummy implementation in MoveOrCopyTemplateCommand. This patch removes this useless implementation. Change-Id: I691e4dc0a9e7943941c9dab52e2a8ed3fe2235b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java 2 files changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I691e4dc0a9e7943941c9dab52e2a8ed3fe2235b8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ExportVmTemplateCommand#createDiskDummiesForSpaceValid...
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ExportVmTemplateCommand#createDiskDummiesForSpaceValidations ...................................................................... core: ExportVmTemplateCommand#createDiskDummiesForSpaceValidations MoveOrCopyTemplateCommand#createDiskDummiesForSpaceValidations was only used by ExportVmTemplateCommand. This patch pulls it down to its rightful place. Change-Id: I352a078c0d612291a42d3bebebbe3820e7aa49d6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java 2 files changed, 15 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I352a078c0d612291a42d3bebebbe3820e7aa49d6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ExportVmTemplateCommand#checkIfDisksExist
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ExportVmTemplateCommand#checkIfDisksExist ...................................................................... core: ExportVmTemplateCommand#checkIfDisksExist MoveOrCopyTemplateCommand#checkIfDisksExist was only used by ExportVmTemplateCommand. This patch pulls it down to its rightful place. Change-Id: Iecd9bae1c16b010a49c58073e7bbca16920e9cbe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java 2 files changed, 31 insertions(+), 32 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecd9bae1c16b010a49c58073e7bbca16920e9cbe Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove MoveVmParameters
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove MoveVmParameters ...................................................................... engine: Remove MoveVmParameters MoveVmParameters just extended MoveOrCopyParameters and didn't add any other data members or methods. As such, it's just useless, and should be removed. Change-Id: I67b238cbe8a9a2fae9c3e3b0f4577bad4796b82c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveVmParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 7 files changed, 15 insertions(+), 31 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67b238cbe8a9a2fae9c3e3b0f4577bad4796b82c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Pull down MoverOrCopyTemplateCommand#validateMacAddress
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Pull down MoverOrCopyTemplateCommand#validateMacAddress ...................................................................... core: Pull down MoverOrCopyTemplateCommand#validateMacAddress This method is only used by ImportVmTemplateCommand, so that's where it should be defined. Change-Id: I437c31a5edca0cc729eb1eee06f329ef2701a303 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java 2 files changed, 44 insertions(+), 47 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I437c31a5edca0cc729eb1eee06f329ef2701a303 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ImportVmTemplateCommand audit log
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmTemplateCommand audit log ...................................................................... core: ImportVmTemplateCommand audit log Fixed audit log type in case the command reaches the END_FAILURE status. Change-Id: I09524c9434a85008c44635e0073f859d3a497024 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09524c9434a85008c44635e0073f859d3a497024 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ExportVmTemplateCommand audit log
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ExportVmTemplateCommand audit log ...................................................................... core: ExportVmTemplateCommand audit log Fixed audit log type in case the command reaches the END_FAILURE status. Change-Id: Id1b486f4f5d557fe1056ae8624da63751cec9a88 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmTemplateCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1b486f4f5d557fe1056ae8624da63751cec9a88 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Pull down MoverOrCopyTemplateCommand#setImagesWithStor...
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Pull down MoverOrCopyTemplateCommand#setImagesWithStoragePoolId ...................................................................... core: Pull down MoverOrCopyTemplateCommand#setImagesWithStoragePoolId This method is only used by ImportVmTemplateFromConfigurationCommand, so that's where it should be defined. Change-Id: I793794207a27e503a08970e53c3fea06a92451f0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I793794207a27e503a08970e53c3fea06a92451f0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Make MoveOrCopyTemplateCommand abstract
by amureini＠redhat.com 30 Mar '16

30 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Make MoveOrCopyTemplateCommand abstract ...................................................................... core: Make MoveOrCopyTemplateCommand abstract As a step to remove this unused (and useless) command, this patch makes it abstract and removes the methods that are overriden by all the classes that extend it. The test was also removed (as this class can no longer be instantiated), as well as audit log constants that are no longer used anywhere in the codebase one the respective methods this patch cleans up were removed. Change-Id: Id6267cb8f13e0f395b8737862dbe86768f4941ab Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A packaging/dbscripts/upgrade/04_00_0400_delete_copy_template_auditlog.sql 5 files changed, 10 insertions(+), 259 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6267cb8f13e0f395b8737862dbe86768f4941ab Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0