- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.5]: construct jsonrpc with identifier name.
by piotr.kliczewski＠gmail.com 01 Apr '16

01 Apr '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: construct jsonrpc with identifier name. ...................................................................... construct jsonrpc with identifier name. this patch help to identifiy host by http connect header, in order to support multiple access for same ip address, specially for vdsmfake. moving to use setter and getter instead of constrctors. adding ConfigValue in order to control this. deafualt is false. update db configuratoin. this patch depndes on https://gerrit.ovirt.org/#/c/39835/ Bug-Url: https://bugzilla.redhat.com/1317248 Change-Id: Ic423322de3f1e0d1862d147a3b529f5c047d8b02 Signed-off-by: emarcian <emarcian(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 24 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Eldad Marciano: Verified -- To view, visit https://gerrit.ovirt.org/55501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic423322de3f1e0d1862d147a3b529f5c047d8b02 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: HE: Enable hosted engine vNIC editing
by piotr.kliczewski＠gmail.com 01 Apr '16

01 Apr '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: HE: Enable hosted engine vNIC editing ...................................................................... HE: Enable hosted engine vNIC editing This patch enabled vNIC management for the hosted engine VM, But the management interface (ovirtmgmt) can't be deactivated for the HE VM. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769 Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 39 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Martin Sivák: Verified Martin Mucha: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: HE: Make the unmanaged hosted engine error a bit more generic
by piotr.kliczewski＠gmail.com 01 Apr '16

01 Apr '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: HE: Make the unmanaged hosted engine error a bit more generic ...................................................................... HE: Make the unmanaged hosted engine error a bit more generic This updates the ACTION_TYPE_FAILED_UNMANAGED_HOSTED_ENGINE error message to include the full action and type to make it ready for more actions than just VM activation. The message is changed from: Cannot ${action} unmanaged hosted engine VM. Please upgrade the cluster level to 3.6 and wait for the hosted engine storage domain to be properly imported. To: Cannot ${action} ${type}. You are using an unmanaged hosted engine VM. Please upgrade the cluster level to 3.6 and wait for the hosted engine storage domain to be properly imported. Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Martin Sivák: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix formatting in JsonRpcUtils
by mperina＠redhat.com 31 Mar '16

31 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix formatting in JsonRpcUtils ...................................................................... core: Fix formatting in JsonRpcUtils Fixes formatting issues introduced in patch Ic423322de3f1e0d1862d147a3b529f5c047d8b02. Change-Id: I11bb03986dc94fc5e5a9b4df01d7699e49cd4532 Bug-Url: https://bugzilla.redhat.com/1317248 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Eldad Marciano: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11bb03986dc94fc5e5a9b4df01d7699e49cd4532 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AsyncDataProvider#isCommandCompatible default
by amureini＠redhat.com 31 Mar '16

31 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AsyncDataProvider#isCommandCompatible default ...................................................................... webadmin: AsyncDataProvider#isCommandCompatible default If a command is not present in the action version map, it's assumed to be supported for any DC/cluster level, and thus shouldn't even be checked by this method. However, as an infrastructure, this method cannot assume it will be used correctly, and needs to return the proper default (true) if used improperly in this way. Change-Id: Ifdf1d75f59f2eec353c4a7f879994ca2fddba42e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf1d75f59f2eec353c4a7f879994ca2fddba42e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: spec: remove %license call
by tnisan＠redhat.com 31 Mar '16

31 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: spec: remove %license call ...................................................................... packaging: spec: remove %license call Change-Id: If543c9f32371d8da62d5f0a3a0be09ffdce2df4a Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Anton Marchukov: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If543c9f32371d8da62d5f0a3a0be09ffdce2df4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: construct jsonrpc with identifier name.
by tnisan＠redhat.com 31 Mar '16

31 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: construct jsonrpc with identifier name. ...................................................................... construct jsonrpc with identifier name. this patch help to identifiy host by http connect header, in order to support multiple access for same ip address, specially for vdsmfake. moving to use setter and getter instead of constrctors. adding ConfigValue in order to control this. deafualt is false. update db configuratoin. this patch depndes on https://gerrit.ovirt.org/#/c/39835/ Bug-Url: https://bugzilla.redhat.com/1317248 Change-Id: Ic423322de3f1e0d1862d147a3b529f5c047d8b02 Signed-off-by: emarcian <emarcian(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 24 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Eldad Marciano: Verified -- To view, visit https://gerrit.ovirt.org/55502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic423322de3f1e0d1862d147a3b529f5c047d8b02 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VmSnaphotListModel: Cloning supported
by amureini＠redhat.com 31 Mar '16

31 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: VmSnaphotListModel: Cloning supported ...................................................................... webadmin: VmSnaphotListModel: Cloning supported Since the engine only supports DCs of compatibility version of 3.5 and above, cloning a VM from a sanpshot should always be supported, and there's no need to check it. Change-Id: I3033a797bd0690f484162c81536b1f851792b958 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 3 files changed, 1 insertion(+), 73 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3033a797bd0690f484162c81536b1f851792b958 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Fix Run Once Boot Menu checkbox on Firefox
by mbetak＠redhat.com 31 Mar '16

31 Mar '16

Martin Betak has submitted this change and it was merged. Change subject: frontend: Fix Run Once Boot Menu checkbox on Firefox ...................................................................... frontend: Fix Run Once Boot Menu checkbox on Firefox Fixed checkbox style caused by longer label. Change-Id: I00f214b74137edba4125e33cb969c7f821f76bd3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054070 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00f214b74137edba4125e33cb969c7f821f76bd3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix updateVmRunTimeInfo
by ahadas＠redhat.com 31 Mar '16

31 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix updateVmRunTimeInfo ...................................................................... core: fix updateVmRunTimeInfo 1. Rename VmAnalyzer#updateVmRunTimeInfo to updateVmDynamicData as it updates the runtime information in VmDynamic part of the VM. 2. Extract the code that fetches the VM from the DB (it might be that the VM is not running on the monitored host but exists in the DB) as it should not be part of this method. 3. Set the dynamic data to save in this method as it should be part of its responsibility and change the method to be void. Change-Id: I792b1467c011abade985fce6ba1d618903ef5804 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 17 insertions(+), 22 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792b1467c011abade985fce6ba1d618903ef5804 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0