- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: Use type safe enums
by juan.hernandez＠redhat.com 30 Mar '16

30 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use type safe enums ...................................................................... Use type safe enums Currently the SDK implements enum values as constants with string values. This means that it isn't possible to check their type. To improve that, this patch changes the SDK to use type safe enums instead of strings. Change-Id: I581ff287a37682ae2955808bc71fa25a38432517 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M automation/build-artifacts.packages.el7 M automation/build-artifacts.packages.fc23 M automation/check-patch.packages.el7 M automation/check-patch.packages.fc23 M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/python/TypesGenerator.java M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java M packaging/spec.el7.in M packaging/spec.fc23.in M pom.xml M sdk/examples/add_host.py M sdk/examples/add_nfs_data_storage_domain.py M sdk/examples/add_nfs_iso_storage_domain.py M sdk/examples/add_vm_disk.py M sdk/examples/attach_nfs_data_storage_domain.py M sdk/examples/attach_nfs_iso_storage_domain.py M sdk/examples/remove_host.py M sdk/examples/start_vm.py M sdk/examples/stop_vm.py M sdk/setup.py 20 files changed, 88 insertions(+), 34 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I581ff287a37682ae2955808bc71fa25a38432517 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor refactoring in VmAnalyzer
by ahadas＠redhat.com 30 Mar '16

30 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in VmAnalyzer ...................................................................... core: minor refactoring in VmAnalyzer 1. import ObjectIdentityChecker.getChangedFields as static method instead of referencing it through the ObjectIdentityChecker class 2. rename proceedDownVms to proceedDownVm and remove its inaccurate documentation 3. early return in updateVmStatistics Change-Id: I04eebab98b1d9a74a7e997fe9c947a732c24f88a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 15 insertions(+), 17 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55319 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04eebab98b1d9a74a7e997fe9c947a732c24f88a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Support configurable mixed RHEL 6, 7 check
by tnisan＠redhat.com 30 Mar '16

30 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Support configurable mixed RHEL 6, 7 check ...................................................................... core: Support configurable mixed RHEL 6, 7 check Today we ban adding a host with RHEL 7 to a cluster with RHEL 6 or vice versa. This patch will make that check configurable leaving the default behaviour as is for 3.5 and disabling it onward. Change-Id: I1d99473ed8a068fbafde3f11605a942f6a8f989c Bug-Url: https://bugzilla.redhat.com/1241149 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 5 files changed, 34 insertions(+), 1 deletion(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d99473ed8a068fbafde3f11605a942f6a8f989c Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal: Fixed New Template dialog size
by tnisan＠redhat.com 30 Mar '16

30 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Fixed New Template dialog size ...................................................................... userportal: Fixed New Template dialog size Changed the size of the New Template dialog in the user portal so elements won't slide off it when "Create as a Template Sub Version" widget is open. Change-Id: I366f19dc7bb6efd8a2b4b96f539a80d269de5e1b Bug-Url: https://bugzilla.redhat.com/1190142 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> (cherry picked from commit 459e70783d11793284d5efe013ef91943a35c11c) --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/54456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I366f19dc7bb6efd8a2b4b96f539a80d269de5e1b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix name of notifier service
by tnisan＠redhat.com 30 Mar '16

30 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix name of notifier service ...................................................................... webadmin: Fix name of notifier service Fixes name of ovirt-engine-notifier service. Change-Id: I58cda9591b782169a3c4df0f1134782a3a204f5b Bug-Url: https://bugzilla.redhat.com/1321583 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58cda9591b782169a3c4df0f1134782a3a204f5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move and rename updateRunTimeStatisticsData
by ahadas＠redhat.com 30 Mar '16

30 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: move and rename updateRunTimeStatisticsData ...................................................................... core: move and rename updateRunTimeStatisticsData This method was in VM class although all it does it to update the statistics data that was reported by VDSM. Therefore, moving it to VmStatistics class and rename it to updateRuntimeData. Change-Id: If5ea639705223689bc47238a8584466d5a4df7f8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 3 files changed, 35 insertions(+), 33 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5ea639705223689bc47238a8584466d5a4df7f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move and rename updateRunTimeDynamicData
by ahadas＠redhat.com 30 Mar '16

30 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: move and rename updateRunTimeDynamicData ...................................................................... core: move and rename updateRunTimeDynamicData This method was in VM class although all it does is to update the dynamic data that was reported by VDSM. Therefore, moving it to VmDynamic class and rename it to updateRuntimeData. Change-Id: Iec5e0baa920be91d30ec15ad75ab8a5771101038 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 3 files changed, 53 insertions(+), 53 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec5e0baa920be91d30ec15ad75ab8a5771101038 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not set run-on-vds name in monitoring
by ahadas＠redhat.com 30 Mar '16

30 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: do not set run-on-vds name in monitoring ...................................................................... core: do not set run-on-vds name in monitoring VM#runOnVdsName that stores the name of the VDS on which the VM run should not be updated by the monitoring (no need to - it is not persisted in the database and not being used afterwards). Change-Id: Ib767c362acf11ecc8b32adf29dcc43eedf833499 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib767c362acf11ecc8b32adf29dcc43eedf833499 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Dont show unregistered subtab if SD is unattached.
by mlipchuk＠redhat.com 30 Mar '16

30 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Dont show unregistered subtab if SD is unattached. ...................................................................... webadmin: Dont show unregistered subtab if SD is unattached. When SD is unattached there is not reason to show the unregistered entities it contains Change-Id: I19cc30b2dc4265083b459286bf3adf419b6c96e1 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19cc30b2dc4265083b459286bf3adf419b6c96e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dal: Fix fetch of unregistered disks to update attached vms.
by mlipchuk＠redhat.com 30 Mar '16

30 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: dal: Fix fetch of unregistered disks to update attached vms. ...................................................................... dal: Fix fetch of unregistered disks to update attached vms. Fix the DaoImpl class of unregistered disks so the attached vms will be propoerly updated at each unregistered disks when fetched. Change-Id: Ic3aa9afdf0621585a7dc3983f3b2d886d1494d5a Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoImpl.java 1 file changed, 3 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3aa9afdf0621585a7dc3983f3b2d886d1494d5a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0