- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: VmDiskListModel: extend disk supported
by amureini＠redhat.com 29 Mar '16

29 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: VmDiskListModel: extend disk supported ...................................................................... webadmin: VmDiskListModel: extend disk supported Since the engine only supports DCs of compatibility version of 3.5 and above, extending a disk should always be supported, and there's no need to check it. Change-Id: I3a989e07eaeaca7ad5fab9f1263dd2f1d95ef588 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 1 insertion(+), 28 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a989e07eaeaca7ad5fab9f1263dd2f1d95ef588 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: HE: Enable hosted engine vNIC editing
by rgolan＠redhat.com 29 Mar '16

29 Mar '16

Roy Golan has submitted this change and it was merged. Change subject: HE: Enable hosted engine vNIC editing ...................................................................... HE: Enable hosted engine vNIC editing This patch enabled vNIC management for the hosted engine VM, But the management interface (ovirtmgmt) can't be deactivated for the HE VM. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769 Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 36 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AsyncDataProvider commented out code
by amureini＠redhat.com 29 Mar '16

29 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AsyncDataProvider commented out code ...................................................................... webadmin: AsyncDataProvider commented out code Remove old, outdated, commented out code from AsyncDataProvider. Change-Id: Ifacd711cbfd32464730af39fd0e4e76df93b42ec Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifacd711cbfd32464730af39fd0e4e76df93b42ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AsyncDataProvider unboxing
by amureini＠redhat.com 29 Mar '16

29 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AsyncDataProvider unboxing ...................................................................... webadmin: AsyncDataProvider unboxing Let Java handle unboxing instead of doing it explicitly, in order to clean up the code. Change-Id: Ide17693d775dd0d77bc352218adfadd1615b5021 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 17 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide17693d775dd0d77bc352218adfadd1615b5021 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove unused AsyncDataProvider methods
by amureini＠redhat.com 29 Mar '16

29 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove unused AsyncDataProvider methods ...................................................................... webadmin: Remove unused AsyncDataProvider methods Change-Id: Ib7d6dac40fd472e51b1e784b57a754fc622c72ae Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 0 insertions(+), 291 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7d6dac40fd472e51b1e784b57a754fc622c72ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove useless comments in Regex
by amureini＠redhat.com 29 Mar '16

29 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove useless comments in Regex ...................................................................... webadmin: Remove useless comments in Regex Change-Id: Ifac3cf04c3b71863545a959da284223666022297 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Regex.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/55370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifac3cf04c3b71863545a959da284223666022297 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: HE: fixed the vm nic changing it's status to unplugged.
by rgolan＠redhat.com 29 Mar '16

29 Mar '16

Roy Golan has submitted this change and it was merged. Change subject: HE: fixed the vm nic changing it's status to unplugged. ...................................................................... HE: fixed the vm nic changing it's status to unplugged. The fix is to use the nic device id that is reported from the hosted engine vm when importing it and not to generate a random id. Added unitests. Organized imports. Change-Id: I0987418d33b61009cbd443e5b6c82872b20242d5 Bug-Url: https://bugzilla.redhat.com/1311151 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java 2 files changed, 42 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/55290 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0987418d33b61009cbd443e5b6c82872b20242d5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: HE: Make the unmanaged hosted engine error a bit more generic
by rgolan＠redhat.com 29 Mar '16

29 Mar '16

Roy Golan has submitted this change and it was merged. Change subject: HE: Make the unmanaged hosted engine error a bit more generic ...................................................................... HE: Make the unmanaged hosted engine error a bit more generic This updates the ACTION_TYPE_FAILED_UNMANAGED_HOSTED_ENGINE error message to include the full action and type to make it ready for more actions than just VM activation. The message is changed from: Cannot ${action} unmanaged hosted engine VM. Please upgrade the cluster level to 3.6 and wait for the hosted engine storage domain to be properly imported. To: Cannot ${action} ${type}. You are using an unmanaged hosted engine VM. Please upgrade the cluster level to 3.6 and wait for the hosted engine storage domain to be properly imported. Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Looks good to me, but someone else must approve Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: vm must exist in db at VmAnalyzer#updateVmRunTimeInfo
by ahadas＠redhat.com 29 Mar '16

29 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: vm must exist in db at VmAnalyzer#updateVmRunTimeInfo ...................................................................... core: vm must exist in db at VmAnalyzer#updateVmRunTimeInfo Now that we immediately return at VmAnalyzer#analyze in case of external VMs, we can be sure that the VM exists in the database when we get to VmAnalyzer#updateVmRunTimeInfo. Change-Id: I71678041ae6d61803a8f589a51bf9e6d0f18345c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71678041ae6d61803a8f589a51bf9e6d0f18345c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine: drop 3.6.4 jobs
by sbonazzo＠redhat.com 29 Mar '16

29 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine: drop 3.6.4 jobs ...................................................................... ovirt-engine: drop 3.6.4 jobs dropping 3.6.4 jobs since 3.6.4 has been released. Change-Id: I5ec46f040c52ae315e08ee5824c75fad70d4c2f7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-db.yaml 2 files changed, 0 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ec46f040c52ae315e08ee5824c75fad70d4c2f7 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0