- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove redundant shouldLogToAudit method
by masayag＠redhat.com 15 Mar '16

15 Mar '16

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove redundant shouldLogToAudit method ...................................................................... core: Remove redundant shouldLogToAudit method The shouldLogToAudit method in GetAllVmStatsVDSCommand class is redundant as it has same implementation as its parent class. Change-Id: Ic08ceb464c1787035bd5f3a1b4525c25c2b5c004 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54276 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic08ceb464c1787035bd5f3a1b4525c25c2b5c004 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: add_host: don't ask for cluster name if there is just one
by sbonazzo＠redhat.com 14 Mar '16

14 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: add_host: don't ask for cluster name if there is just one ...................................................................... add_host: don't ask for cluster name if there is just one No need to ask the user for cluster name if there is just one available. It also may confuse the user on the initial install, making him think he can enter any cluster name. Change-Id: Ibff4cd48e08b41c305a90d200ec7d7e9f0d4f692 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1186388 --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 12 insertions(+), 11 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53840 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibff4cd48e08b41c305a90d200ec7d7e9f0d4f692 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: remove unused removeVmDisksMsg from UIConstants
by derez＠redhat.com 14 Mar '16

14 Mar '16

Daniel Erez has submitted this change and it was merged. Change subject: frontend: remove unused removeVmDisksMsg from UIConstants ...................................................................... frontend: remove unused removeVmDisksMsg from UIConstants Change-Id: Ifdd002085db4e6934f3e4a122a4cc1f9282b975c Related-To: https://bugzilla.redhat.com/1271698 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/54712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdd002085db4e6934f3e4a122a4cc1f9282b975c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Call super to get Backend instance
by amureini＠redhat.com 14 Mar '16

14 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Call super to get Backend instance ...................................................................... engine: Call super to get Backend instance Fix getBackend() to call super.getBackend(). This patch addresses Coverity CID 1348295. Change-Id: Ieb6bf7fe1cc0967da27af181c0ddd4f096fe9a75 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Sahina Bose: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/54704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb6bf7fe1cc0967da27af181c0ddd4f096fe9a75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add V3 action adapters
by juan.hernandez＠redhat.com 14 Mar '16

14 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add V3 action adapters ...................................................................... restapi: Add V3 action adapters This patch adds the V3 input and output adapters for the "Action" type. Change-Id: Id295672e72a40959abb98cf20728ab21bec970ef Bug-Url: https://bugzilla.redhat.com/1317279 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ActionInAdapter.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ActionOutAdapter.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3FaultInAdapter.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3GracePeriodInAdapter.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3GracePeriodOutAdapter.java 5 files changed, 492 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id295672e72a40959abb98cf20728ab21bec970ef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Release 4.0.0.alpha11
by juan.hernandez＠redhat.com 14 Mar '16

14 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Release 4.0.0.alpha11 ...................................................................... Release 4.0.0.alpha11 Change-Id: Ida7a416168c985d5bb348432a152f8a225c20fc7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/build.sh M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida7a416168c985d5bb348432a152f8a225c20fc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[ovirt-3.6]: windows: More defensive code for windows VirtIO handling
by vfeenstr＠redhat.com 14 Mar '16

14 Mar '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: windows: More defensive code for windows VirtIO handling ...................................................................... windows: More defensive code for windows VirtIO handling To avoid continous exceptions to eat 100% of the CPU we're now sleeping at least for 1 second after an exception and we're logging the exception in debug mode, so we can investigate potential problems. To avoid spamming the logs this is on debug log for now. Change-Id: I0cb7c1108a579bf55f9340cb1c211b65d6cd8f5b Bug-Url: https://bugzilla.redhat.com/1257835 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/WinFile.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cb7c1108a579bf55f9340cb1c211b65d6cd8f5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: windows: More defensive code for windows VirtIO handling
by vfeenstr＠redhat.com 14 Mar '16

14 Mar '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: windows: More defensive code for windows VirtIO handling ...................................................................... windows: More defensive code for windows VirtIO handling To avoid continous exceptions to eat 100% of the CPU we're now sleeping at least for 1 second after an exception and we're logging the exception in debug mode, so we can investigate potential problems. To avoid spamming the logs this is on debug log for now. Change-Id: I0cb7c1108a579bf55f9340cb1c211b65d6cd8f5b Bug-Url: https://bugzilla.redhat.com/1257835 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/WinFile.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cb7c1108a579bf55f9340cb1c211b65d6cd8f5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: simplify the logic within vm-jobs monitoring
by ahadas＠redhat.com 14 Mar '16

14 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: simplify the logic within vm-jobs monitoring ...................................................................... core: simplify the logic within vm-jobs monitoring Instead of filtering the existing jobs from the reported jobs and then iterating the reported jobs to find the jobs to update and afterwards iterating the existing jobs to find the jobs to remove, we now iterating only the existing jobs and find the jobs to update and the jobs to remove in one cycle. Change-Id: I71d3a6be42193a717a3c68b7c4dbe9966e1e080d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java 1 file changed, 18 insertions(+), 31 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/54314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d3a6be42193a717a3c68b7c4dbe9966e1e080d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: removing ovirt register jobs
by tlitovsk＠redhat.com 14 Mar '16

14 Mar '16

Anatoly Litovsky has submitted this change and it was merged. Change subject: removing ovirt register jobs ...................................................................... removing ovirt register jobs Change-Id: I9397e733aefae077925d5a41c7c196e21c4a57f0 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- D jobs/confs/projects/ovirt-register/ovirt-register.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml D jobs/confs/yaml/scms/ovirt-register-scms.yaml 3 files changed, 0 insertions(+), 29 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Jenkins CI: Passed CI tests Anatoly Litovsky: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/54708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9397e733aefae077925d5a41c7c196e21c4a57f0 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0