- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: hostdev: Fix cleanup treatment in RefreshHostDevicesCommand
by tjelinek＠redhat.com 15 Mar '16

15 Mar '16

Tomas Jelinek has submitted this change and it was merged. Change subject: hostdev: Fix cleanup treatment in RefreshHostDevicesCommand ...................................................................... hostdev: Fix cleanup treatment in RefreshHostDevicesCommand The host device refresh logic that clears up vm_devices for host_devices that disappear from host incorrectly assumed that only one device with given name will exist in the vm_device table, which was incorrect for multiple reasons (one host_device attached to multiple VMs or device with same name from different host). Fixed by explicitly querying vm_device attachments only for current host and removing all with given name. Change-Id: I8f39599928195e9c485bf0e0a206caf6b821f580 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1312879 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java M packaging/dbscripts/host_device_sp.sql 4 files changed, 51 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Shmuel Leib Melamud: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f39599928195e9c485bf0e0a206caf6b821f580 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Clarify unauthorized_client error message
by mperina＠redhat.com 15 Mar '16

15 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Clarify unauthorized_client error message ...................................................................... aaa: Clarify unauthorized_client error message When installed from rpms it is required to access engine using the the FQDN instead of ip address. The unauthorized_client exception is raised when accessed using ip address. Add "It's required to access the system using FQDN." to the unauthorized client error message. Change-Id: I4e887b6f38254d34d732c0dc077a9046582ae2a5 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e887b6f38254d34d732c0dc077a9046582ae2a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: post ovirt-hosted-engine-ha-1.3.5
by msivak＠redhat.com 15 Mar '16

15 Mar '16

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.3.5 ...................................................................... build: post ovirt-hosted-engine-ha-1.3.5 Change-Id: I64065a04ea8021827f2d42099060beffd0d335a0 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64065a04ea8021827f2d42099060beffd0d335a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: ovirt-hosted-engine-ha-1.3.5
by msivak＠redhat.com 15 Mar '16

15 Mar '16

Martin Sivák has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-1.3.5 ...................................................................... build: ovirt-hosted-engine-ha-1.3.5 Change-Id: I9e5cfc6433f380fac928d5b1fc06af0cde354fa3 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 12 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e5cfc6433f380fac928d5b1fc06af0cde354fa3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: call refreshCapabilities upon "|net|host_conn|no_id" e...
by alkaplan＠redhat.com 15 Mar '16

15 Mar '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: call refreshCapabilities upon "|net|host_conn|no_id" event ...................................................................... core: call refreshCapabilities upon "|net|host_conn|no_id" event • added method org.ovirt.engine.core.vdsbroker.VdsManager#refreshHost() so that calling code does not have to have VDS to refresh VDS. Change-Id: Ide27a805b412cb3ae005a0ad2ba66cb25b60ecb7 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostConnectionRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 76 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide27a805b412cb3ae005a0ad2ba66cb25b60ecb7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove deadcode
by masayag＠redhat.com 15 Mar '16

15 Mar '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove deadcode ...................................................................... engine: Remove deadcode This patch removes unreachable and addresses Coverity CID 1068808. Change-Id: Id0ab34e3a4f8f28a67ac36d3ef07d30882f5f4ec Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/RpmVersionUtils.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0ab34e3a4f8f28a67ac36d3ef07d30882f5f4ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: build: post ovirt-hosted-engine-setup-1.3.4.0
by stirabos＠redhat.com 15 Mar '16

15 Mar '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-1.3.4.0 ...................................................................... build: post ovirt-hosted-engine-setup-1.3.4.0 Change-Id: Ice6b231b96d51e0c0fca84693e3a744854120ace Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice6b231b96d51e0c0fca84693e3a744854120ace Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: build: ovirt-hosted-engine-setup-1.3.4.0
by stirabos＠redhat.com 15 Mar '16

15 Mar '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.3.4.0 ...................................................................... build: ovirt-hosted-engine-setup-1.3.4.0 Change-Id: I82abfb4db156d99436359eaf6b67f50d74d7007c Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 13 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82abfb4db156d99436359eaf6b67f50d74d7007c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: open Cockpit port in firewall
by emesika＠redhat.com 15 Mar '16

15 Mar '16

Eli Mesika has submitted this change and it was merged. Change subject: core: open Cockpit port in firewall ...................................................................... core: open Cockpit port in firewall Cockpit will be the default administration interface in Node 4.0. The cockpit port (9090/tcp) should be added to the list of default ports to be opened, when the user decides to let engine manage the firewall fo the host. Change-Id: Ieef7fa196ae3459fb5d0697687d46b4747ce7860 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1314781 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieef7fa196ae3459fb5d0697687d46b4747ce7860 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: filetransaction: Convert sequences toStr
by didi＠redhat.com 15 Mar '16

15 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: filetransaction: Convert sequences toStr ...................................................................... filetransaction: Convert sequences toStr Bug-Url: https://bugzilla.redhat.com/1295887 Bug-Url: https://bugzilla.redhat.com/1316908 Change-Id: I66946b833a69ad503097f7c91a101280145dda62 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/filetransaction.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66946b833a69ad503097f7c91a101280145dda62 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0