- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Get version string in "show_summary" example
by juan.hernandez＠redhat.com 08 Mar '16

08 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Get version string in "show_summary" example ...................................................................... Get version string in "show_summary" example This patch improves the "show_summary" example so that it also demonstrates how to get the version number of the product. Change-Id: If19fefb10035b6067aa8b2f0b309a5b8e879222a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/show_summary.rb 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If19fefb10035b6067aa8b2f0b309a5b8e879222a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Do not fetch disk info together with VM templates
by tnisan＠redhat.com 08 Mar '16

08 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Do not fetch disk info together with VM templates ...................................................................... webadmin: Do not fetch disk info together with VM templates In GetVmTemplatesByStoragePoolId and GetVmTemplatesFromStorageDomain queries, the disk info fetched by them is not used in most situations. However, fetching the excessive data takes time and slows down the UI. This patch gets rid of disk info where it is not needed. In particular, in 'New VM' and similar dialogs the disk info for the currently selected template is queried separately, while the disk info fetched previously for every template in the list is not used at all. Change-Id: I6fa007c1cc7b49efb3d9d4e1c01a852aa8a3cf62 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1308478 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesFromStorageDomainQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesFromStorageDomainParameters.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageTemplateListModel.java 7 files changed, 40 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fa007c1cc7b49efb3d9d4e1c01a852aa8a3cf62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Get version string in "show_summary" example
by juan.hernandez＠redhat.com 08 Mar '16

08 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Get version string in "show_summary" example ...................................................................... Get version string in "show_summary" example This patch improves the "show_summary" example so that it also demonstrates how to get the version number of the product. Change-Id: Iefd1a0ed9bd60f4268873a1845d9d3b5ec52c6f7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/show_summary.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefd1a0ed9bd60f4268873a1845d9d3b5ec52c6f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use Yard for documentation
by juan.hernandez＠redhat.com 08 Mar '16

08 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use Yard for documentation ...................................................................... Use Yard for documentation Currently the documentation of the SDK is generating using "rdoc", but it doesn't support AsciiDoc, which is the format used in the API model. This patch changes the SDK to use Yard, as it does support AsciiDoc. Change-Id: I1b2137cf1a2afba9b5b5b9a740a53fbbc6c4b551 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java A generator/src/main/java/org/ovirt/sdk/ruby/YardDoc.java M packaging/spec.el7.in M packaging/spec.fc23.in D sdk/.rdoc_options A sdk/.yardopts M sdk/README.adoc M sdk/lib/ovirtsdk4/http.rb M sdk/lib/ovirtsdk4/reader.rb M sdk/lib/ovirtsdk4/service.rb M sdk/lib/ovirtsdk4/type.rb M sdk/lib/ovirtsdk4/writer.rb M sdk/lib/ovirtsdk4/xml.rb M sdk/ovirt-engine-sdk.gemspec 15 files changed, 254 insertions(+), 216 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b2137cf1a2afba9b5b5b9a740a53fbbc6c4b551 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add PKI resources
by juan.hernandez＠redhat.com 08 Mar '16

08 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add PKI resources ...................................................................... Add PKI resources This patch adds a set of private keys and certificates intended to implement (in later patches) unit tests that connect to an embedded web server. Change-Id: I6279f19d42490d1820f44efb15603f6843e5ede7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/spec/pki/README.adoc A sdk/spec/pki/ca.crt A sdk/spec/pki/localhost.crt A sdk/spec/pki/localhost.key A sdk/spec/pki/server.crt A sdk/spec/pki/server.key A sdk/spec/pki/ugly.crt A sdk/spec/pki/ugly.key 8 files changed, 296 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6279f19d42490d1820f44efb15603f6843e5ede7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use AsciiDoc for the documentation
by juan.hernandez＠redhat.com 08 Mar '16

08 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use AsciiDoc for the documentation ...................................................................... Use AsciiDoc for the documentation This patch changes the documentation files to use AsciiDoc insteadod of Markdown, as that is the format used by the API server and by the other SDKs. Change-Id: I119070ec805d74db9cb5cf49adb732184bae9f5f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- R README.adoc A automation/README.adoc D automation/README.md A generator/README.adoc D generator/README.md R packaging/README.adoc M sdk/.rdoc_options R sdk/README.adoc M sdk/ovirt-engine-sdk.gemspec 9 files changed, 51 insertions(+), 56 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I119070ec805d74db9cb5cf49adb732184bae9f5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Fix names of ignored generated files
by juan.hernandez＠redhat.com 08 Mar '16

08 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix names of ignored generated files ...................................................................... Fix names of ignored generated files The .gitignore file should contain the names of generated source files, like "types.rb", but it is currently wrong. This patch fixes that issue. Change-Id: I74f075283632c95b59448f0dccbfa6eb1bef432f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M .gitignore 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74f075283632c95b59448f0dccbfa6eb1bef432f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: packaging: drop ovirt-host-deploy-offline
by sbonazzo＠redhat.com 08 Mar '16

08 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: drop ovirt-host-deploy-offline ...................................................................... packaging: drop ovirt-host-deploy-offline ovirt-host-deploy-offline package was used mostly only by oVirt Node. In Next Generation Node it's not used anymore. Kept the functionality provided by the offline packager and documented it in the README file but dropped the packaging of the configuration file. Change-Id: I1d0d68e91a85004e1309adbb6cb927f707ac9961 Bug-Url: https://bugzilla.redhat.com/1314790 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M Makefile.am M README D conf.d/50-offline-packager.conf D conf.d/Makefile.am M configure.ac D ovirt-host-deploy-offline.spec.in 6 files changed, 16 insertions(+), 132 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d0d68e91a85004e1309adbb6cb927f707ac9961 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Fix potential NPE in MoveOrCopyTemplate
by mlipchuk＠redhat.com 07 Mar '16

07 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Fix potential NPE in MoveOrCopyTemplate ...................................................................... engine: Fix potential NPE in MoveOrCopyTemplate In order to prevent a potential NPE in MoveOrCopyTemplateCommand, the function getImages returns emptyList instead of null. This patch addresses Coverity CID 1348251 Change-Id: Iacb2e411ce4b8d6474935058d08f034fa590d6d9 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacb2e411ce4b8d6474935058d08f034fa590d6d9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: maven: documented sonatype repository
by sbonazzo＠redhat.com 07 Mar '16

07 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: maven: documented sonatype repository ...................................................................... packaging: maven: documented sonatype repository Fixed the comment for the sonatype repository explaining why it's there. Change-Id: I9208e75beda88093377415f66f0564e0d7270758 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9208e75beda88093377415f66f0564e0d7270758 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0