- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Check dispatcher in version filter
by juan.hernandez＠redhat.com 07 Mar '16

07 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Check dispatcher in version filter ...................................................................... restapi: Check dispatcher in version filter Currently the version filter doesn't check the result of the "getRequestDispatcher" method, which may be null when there is no such dispatcher. If this happens that will generate a NPE. That isn't a serious problem, as it will result in an HTTP 500 (internal server error) code sent to the client for a request that is incorrect anyhow. But it is better to check it, write a message in the log, and send to the client a HTTP 404 (not found) code. Change-Id: Ib73a6ef557f079f667bbddca6596799a08c5ddad Coverity-Id: 1352163 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/VersionFilter.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib73a6ef557f079f667bbddca6596799a08c5ddad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Tranform correctly arrays of bytes
by juan.hernandez＠redhat.com 07 Mar '16

07 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Tranform correctly arrays of bytes ...................................................................... restapi: Tranform correctly arrays of bytes Some of the methods of the system resource return arrays of bytes instead of objects. For example, the "?schema" requests returns the XML schema as an array of bytes. Currently this produces an exception because the V3 output adapter doesn't know how to handle arrays of bytes. This patch fixes that issue. Change-Id: Id9476bd0ac0da315af27d9f63fa41bbb9fe1b7dd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3OutAdapters.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9476bd0ac0da315af27d9f63fa41bbb9fe1b7dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove getTaskType() check
by laravot＠redhat.com 07 Mar '16

07 Mar '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Remove getTaskType() check ...................................................................... core: Remove getTaskType() check In the rebase of I2251dd808734f297c5e3907b9f106d6cf87fbd18 the task type check was mistakenly left, this patch removes it. Change-Id: I07d489edaeabe0db74ef71db06b40e1af73195ae Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07d489edaeabe0db74ef71db06b40e1af73195ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: removing ChildCommandsCallbackBase
by laravot＠redhat.com 07 Mar '16

07 Mar '16

Liron Aravot has submitted this change and it was merged. Change subject: core: removing ChildCommandsCallbackBase ...................................................................... core: removing ChildCommandsCallbackBase Currently there is no need to keep ConcurrentChildCommandsExecutionCallback and ChildCommandsCallbackBase as separate classes, therefore this patch removes ChildCommandsCallbackBase. Change-Id: I5e6a7b24bcf4a5e27b0455c82b5bbbf194c18680 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConcurrentChildCommandsExecutionCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildCommandsExecutionCallback.java 3 files changed, 142 insertions(+), 164 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e6a7b24bcf4a5e27b0455c82b5bbbf194c18680 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move command end status determination to ChildCommands...
by laravot＠redhat.com 07 Mar '16

07 Mar '16

Liron Aravot has submitted this change and it was merged. Change subject: core: move command end status determination to ChildCommandsCallbackBase ...................................................................... core: move command end status determination to ChildCommandsCallbackBase Currently the command end status determination code is repeated in ConcurrentChildCommandsExecutionCallback and SerialChildCommandsExecutionCallback, this change moves it to ChildCommandsCallbackBase. Change-Id: I0d046ea68cac4a6d917029d003453d60ffea43cd Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConcurrentChildCommandsExecutionCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildCommandsExecutionCallback.java 3 files changed, 17 insertions(+), 24 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d046ea68cac4a6d917029d003453d60ffea43cd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Set unmanaged commands status on engine start
by laravot＠redhat.com 07 Mar '16

07 Mar '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Set unmanaged commands status on engine start ...................................................................... core: Set unmanaged commands status on engine start When the engine is shutdown when there are running commands, when the engine starts again the status of those commands will remain as 'ACTIVE' forever as they aren't managed by the ATM or by the Coco framework. This may cause to their parent commands to never end. This patch adds that responsibllity to the CommandsRepository, as soon as its initiated it'll update the status of those commands to be ENDED_WITH_FAILURE. Change-Id: Ib1da52c611fc4171b31d9109b599e4688e7e2b62 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java 2 files changed, 30 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1da52c611fc4171b31d9109b599e4688e7e2b62 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase - avoid setting end status prematurely
by laravot＠redhat.com 07 Mar '16

07 Mar '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - avoid setting end status prematurely ...................................................................... core: CommandBase - avoid setting end status prematurely In change I49b7f506dc1142c3a559d0e6f64813e2ade02254 the code checking whether the command should status should be updated after execution was updated. As some of the commands are adding the tasks to the internal task id list instead of using the getTaskIdList() method it'll cause those commands to be marked as ended although the tasks are still running. This patch adds a check to the internal list as well to avoid that issue. Change-Id: I2251dd808734f297c5e3907b9f106d6cf87fbd18 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310390 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2251dd808734f297c5e3907b9f106d6cf87fbd18 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add tests for vm jobs monitoring
by ahadas＠redhat.com 06 Mar '16

06 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: add tests for vm jobs monitoring ...................................................................... core: add tests for vm jobs monitoring Change-Id: I75545d7cfe081f67623c73117390c1f597f46280 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoringTest.java 1 file changed, 134 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75545d7cfe081f67623c73117390c1f597f46280 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactor vm jobs monitoring
by ahadas＠redhat.com 06 Mar '16

06 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refactor vm jobs monitoring ...................................................................... core: refactor vm jobs monitoring 1. Rename occurrences of vm-jobs to jobs. In this context, all the jobs are supposed to be of type VmJob. 2. Rename updateVmJobs methods to processVmJobs - this name was ok in VmAnalyzer but not in this context. 3. Split saveVmJobsToDb to two methods: updateJobs and removeJobs. 4. Make processVmJobs private so it will not be called from outside of this class. 5. Extract (and simplify) the fetch of existing vm-jobs from the database into a separate method that can be mocked. Change-Id: I0833d2106ff88b7529166bb004234ac6b83c80be Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java 1 file changed, 29 insertions(+), 27 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0833d2106ff88b7529166bb004234ac6b83c80be Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Fix example in README.md
by juan.hernandez＠redhat.com 06 Mar '16

06 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix example in README.md ...................................................................... Fix example in README.md This patch fixes the example inside README.md that explains how to create a connection, as it is missing the ".new" part in the call to the constructor. Change-Id: I6bf0f7047341c58a694d5e8aa79a422970964a1d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/README.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bf0f7047341c58a694d5e8aa79a422970964a1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0