- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Don't fail with unexpected version numbers
by juan.hernandez＠redhat.com 03 Mar '16

03 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't fail with unexpected version numbers ...................................................................... restapi: Don't fail with unexpected version numbers Currently the API assumes that the format of version numbers is something like 4.3.1-100, and it fails due to an array index out of bounds exception if it has a different format. This patch makes this code more tolerant, and avoids the failures. Change-Id: Icaf19907ee09b8e4db731c3516520abce2527d50 Bug-Url: https://bugzilla.redhat.com/1311616 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VersionMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VersionMapperTest.java 3 files changed, 236 insertions(+), 61 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaf19907ee09b8e4db731c3516520abce2527d50 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal, webadmin: updated csh for VMs > Run Once
by gshereme＠redhat.com 03 Mar '16

03 Mar '16

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: updated csh for VMs > Run Once ...................................................................... userportal, webadmin: updated csh for VMs > Run Once Updated csh mapping for VMs > Run Once to make it more obvious that this is for "Run Once." Change-Id: I440fd44038567b1e11b361825c65651bd2e74b81 Bug-Url: https://bugzilla.redhat.com/1260962 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/53762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I440fd44038567b1e11b361825c65651bd2e74b81 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: Rename command_entities.status from FAILED_RESTARTED
by laravot＠redhat.com 03 Mar '16

03 Mar '16

Liron Aravot has submitted this change and it was merged. Change subject: db: Rename command_entities.status from FAILED_RESTARTED ...................................................................... db: Rename command_entities.status from FAILED_RESTARTED The enum name for CommandStatus.FAILED_RESTARTED was changed to EXECUTION_FAILED to better reflect its new usage in commit 72462294bfbae0b87be541fcbbef09773ff030bd. Because the enum value is stored as a string in the command_entities table, any command entity records present with the old status name need to be updated to use the new name to prevent failure when the CommandEntity DAO attempts to retrieve them. Change-Id: I8b513fe6ace325e732fb6a5961a4354068d21964 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0270_rename_command_entity_failed_restarted.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Greg Padgett: Verified Liron Aravot: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b513fe6ace325e732fb6a5961a4354068d21964 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract vm jobs related code from vm-analyzer
by ahadas＠redhat.com 03 Mar '16

03 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract vm jobs related code from vm-analyzer ...................................................................... core: extract vm jobs related code from vm-analyzer VmAnalyzer should (ideally) take a VM that was reported by VDSM, compare it to the previous information we have for that VM and analyze the difference. However, the analyzer currently does more than that and therefore is not easy to maintain. This patch extracts the VM jobs handling from VmAnalyzer to a new class called VmJobsMonitoring. The benefits are: 1. Less not-that-related code in VmAnalyzer and one less DAO to pass to it. 2. We get to the point where the dynamic VM data is persisted into the database faster as we push the queries that are done in order to process the reported VM jobs to be after the VM dynamic data is persisted to the database. 3. The processing of VM jobs is done by another module which is a singleton and therefore it prepares the ground for events-based updates of command callbacks and for possible optimizations of the inefficient queries from the database that are done in statistics monitoring cycles. Change-Id: Ic244bfc0ca2aef014b09aaa2fcf4a1d7f1e9d166 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 5 files changed, 108 insertions(+), 85 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/53587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic244bfc0ca2aef014b09aaa2fcf4a1d7f1e9d166 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VideoDeviceSettings version
by amureini＠redhat.com 03 Mar '16

03 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: VideoDeviceSettings version ...................................................................... core: VideoDeviceSettings version Use the Version.v3_6 constant instead of hard coded int literals. Change-Id: Iebba95d73de8b21458e380a1945e9b5169a631f2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VideoDeviceSettings.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebba95d73de8b21458e380a1945e9b5169a631f2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: upgrade: prevent deploying additional 3.6 host on a 3.5 setup
by sbonazzo＠redhat.com 03 Mar '16

03 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: upgrade: prevent deploying additional 3.6 host on a 3.5 setup ...................................................................... upgrade: prevent deploying additional 3.6 host on a 3.5 setup Deploying an additional 3.6 hosted-engine host requires an existing 3.6 system. Mixing 3.6 and 3.5 hosts in the same HE cluster is not supported: in order to deploy a new 3.6 host, the user has to update existing hosts to 3.6, and only then add the new host. Looking for the presence of the configuration image uuid in the answerfile, we can detect if the answerfile is from 3.5 or 3.6, and warn the user if needed. Change-Id: I9283e5d45eba63b4bfbb99343af1b4331856b6a5 Bug-Url: https://bugzilla.redhat.com/1306825 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py M src/plugins/ovirt-hosted-engine-setup/storage/heconf.py 3 files changed, 75 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9283e5d45eba63b4bfbb99343af1b4331856b6a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Default for Cluster#migrationBandwidthLimitType
by ahadas＠redhat.com 03 Mar '16

03 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Default for Cluster#migrationBandwidthLimitType ...................................................................... core: Default for Cluster#migrationBandwidthLimitType It fixes the problem during cluster creation/edititng: "Error while executiong action: may not be null". Change-Id: Id2d56658ee171e50350e8dcca33c3015a1b6e1ce Bug-Url: https://bugzilla.redhat.com/1252426 Feature-Page: http://www.ovirt.org/Features/Migration_Enhancements Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/54304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2d56658ee171e50350e8dcca33c3015a1b6e1ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: packaging: build: Use python3 when running on fedora >= 23
by sbonazzo＠redhat.com 03 Mar '16

03 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: build: Use python3 when running on fedora >= 23 ...................................................................... packaging: build: Use python3 when running on fedora >= 23 This patch includes code to port ovirt-log-collector itself to Python3. Bug-Url: https://bugzilla.redhat.com/1254654 Change-Id: If5de8656b3e54d9911b67960492be851d64935bd Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M .gitignore M configure.ac M ovirt-log-collector.spec.in M src/Makefile.am M src/__main__.py A src/engine-log-collector.in M src/helper/hypervisors.py M src/tests.py 8 files changed, 94 insertions(+), 48 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5de8656b3e54d9911b67960492be851d64935bd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Ignore FindBugs on generated code
by amureini＠redhat.com 03 Mar '16

03 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Ignore FindBugs on generated code ...................................................................... restapi: Ignore FindBugs on generated code Added an exclusion filter to ignore FindBugs warning on generated code. Change-Id: I2253261a0da20a487f59bd65e83399bafb898f3b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/exclude-filters.xml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2253261a0da20a487f59bd65e83399bafb898f3b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Clean ActionVersionMap's DAO
by amureini＠redhat.com 03 Mar '16

03 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Clean ActionVersionMap's DAO ...................................................................... core: Clean ActionVersionMap's DAO ActionVersionMap's are not (and should not!) be update from within the application, only by upgrade scripts. Hence, there's no reason to have a DAO that can manipulate them, and these methods are indeed not used outside of the test's scope. This patch removes these redundant methods, as well as the stored procedures that back them up. Change-Id: Iff6f8ea4a8ee81c60d983a6973bb3334d3e883a0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ActionGroupDaoTest.java M packaging/dbscripts/action_version_map_sp.sql 4 files changed, 0 insertions(+), 99 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff6f8ea4a8ee81c60d983a6973bb3334d3e883a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0