- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddImageFromScratchCommand - command never ends
by laravot＠redhat.com 06 Mar '16

06 Mar '16

Liron Aravot has submitted this change and it was merged. Change subject: core: AddImageFromScratchCommand - command never ends ...................................................................... core: AddImageFromScratchCommand - command never ends When the added disk addition is reverted, the command nevers ends as setSucceeded(true) isn't being executed. Change-Id: Ia45f4d2b4f2af1d1dc2427bfe554ff9273970099 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AddImageFromScratchCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia45f4d2b4f2af1d1dc2427bfe554ff9273970099 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: log the cause when domain is determined as problematic
by laravot＠redhat.com 06 Mar '16

06 Mar '16

Liron Aravot has submitted this change and it was merged. Change subject: core: log the cause when domain is determined as problematic ...................................................................... core: log the cause when domain is determined as problematic When hosts reports are inspected as problematic the engine logs the fact that the domain report is problematic, but the monitoring result itself isn't logged, this patch adds it to ease the debug of host/storage report issues. Change-Id: I498cb9b321dac42b856c96d26cab18090ba36904 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/54012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I498cb9b321dac42b856c96d26cab18090ba36904 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: updated csh for VMs > Run Once
by tnisan＠redhat.com 06 Mar '16

06 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: updated csh for VMs > Run Once ...................................................................... userportal, webadmin: updated csh for VMs > Run Once Updated csh mapping for VMs > Run Once to make it more obvious that this is for "Run Once." Change-Id: I440fd44038567b1e11b361825c65651bd2e74b81 Bug-Url: https://bugzilla.redhat.com/1260962 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/54326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I440fd44038567b1e11b361825c65651bd2e74b81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Avoid potential NPEs in link helper
by juan.hernandez＠redhat.com 05 Mar '16

05 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Avoid potential NPEs in link helper ...................................................................... restapi: Avoid potential NPEs in link helper There are several places in the link helper where methods are called using references that could theoretically be null. This adds the null checks to avoid these potential NPEs. Change-Id: Ida284223e50bdc94ee3a1672433a0ed31cbbdefa Coverity-Id: 1352154, 1352155, 1352156 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java 2 files changed, 28 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida284223e50bdc94ee3a1672433a0ed31cbbdefa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Check result of loading YAML metadata
by juan.hernandez＠redhat.com 05 Mar '16

05 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Check result of loading YAML metadata ...................................................................... restapi: Check result of loading YAML metadata Currently the method that loads the YAML metadata doesn't check if the result is null, and this is reported as a defect by some code auditing tools. To avoid that defect this patch changes the code so that it checks for null and throws an exception. Change-Id: Ie2d64f1233d16f5acfbbd3890944deba72bff274 Coverity-Id: 1229037 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2d64f1233d16f5acfbbd3890944deba72bff274 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Add Authz search to SSO
by mperina＠redhat.com 04 Mar '16

04 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Add Authz search to SSO ...................................................................... aaa: Add Authz search to SSO Add user and groups search to sso, the search query will utilize SSO to extract the records from domain services. The resource is introduced as a new scope and can be accessed using token-info by passing the scope ovirt-ext:token-info:search-authz Change-Id: I6f1edab486a9467334139e97b868ecae8c123a85 Bug-Url: https://bugzilla.redhat.com/1092744 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/QueryData.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SSOOAuthServiceUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SSORestApiNegotiationFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java M backend/manager/modules/auth-plugin/src/main/java/org/ovirt/engine/core/jboss_auth_plugin/OvirtAuthPlugIn.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableNamespacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByPrincipalQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupsForUserQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryUserByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDomainListQueryTest.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/AuthzUtils.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectorySearch.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectoryUtils.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/SearchParsingUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenInfoServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonExtKeySerializer.java A packaging/dbscripts/upgrade/04_00_0280_add_authz_search_scope_to_sso_client_registration_and_scope_dependency.sql M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py 32 files changed, 1,451 insertions(+), 649 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51470 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f1edab486a9467334139e97b868ecae8c123a85 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Add SSO UI for Changing expired user passwd
by mperina＠redhat.com 04 Mar '16

04 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Add SSO UI for Changing expired user passwd ...................................................................... aaa: Add SSO UI for Changing expired user passwd Add Change Password page and sso service to handle the request to change user passwd If the authn profile allows password change a logged in user will be able to change his password using the change password menu item and users with expired passwords will be able to change password using the password change form presented on user failed login attempt. Change-Id: I9923114954737ea49b8ccd3d8ee69072cb5e01d9 Bug-Url: https://bugzilla.redhat.com/1092744 Bug-Url: https://bugzilla.redhat.com/1037844 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/header.tag M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/context/SSOContextListener.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveBasicAuthServlet.java A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveChangePasswdServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthRevokeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenInfoServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthnMessageMapper.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/Credentials.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/JsonExtDeserializer.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/JsonExtKeySerializer.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/NegotiateAuthUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/NonInteractiveAuth.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOContext.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOExtensionsManager.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOSession.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/TokenCleanupUtility.java A backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeContextListener.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java M backend/manager/modules/welcome/src/main/resources/messages.properties M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java 30 files changed, 781 insertions(+), 194 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/40445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9923114954737ea49b8ccd3d8ee69072cb5e01d9 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: Add compat rpm for easier consumption
by sbonazzo＠redhat.com 04 Mar '16

04 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add compat rpm for easier consumption ...................................................................... Add compat rpm for easier consumption Change-Id: If1e0c77b9926fe9e503957d1caae714f84b84422 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M automation/build-artifacts.sh 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1e0c77b9926fe9e503957d1caae714f84b84422 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: node: Require ovirt-hosted-engine-setup
by sbonazzo＠redhat.com 04 Mar '16

04 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Require ovirt-hosted-engine-setup ...................................................................... node: Require ovirt-hosted-engine-setup hosted-engine-setup should be available on Node, thus require it. vdsm-cli can be dropped, because it's a dependency of he-setup. Change-Id: Ia46c1fe10d9853ac0fdf1bbf2b91c5efeea1b7e4 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M ovirt-release-master.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia46c1fe10d9853ac0fdf1bbf2b91c5efeea1b7e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: build: remove retired Codehaus repository
by piotr.kliczewski＠gmail.com 04 Mar '16

04 Mar '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: build: remove retired Codehaus repository ...................................................................... build: remove retired Codehaus repository Codehaus is retired, and Maven kept trying to download jars from there, which would cause the compile to fail. Change-Id: I03ef9b43cd9e8f5d95fc44d661ac21cac9d3a086 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M pom.xml 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/54327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03ef9b43cd9e8f5d95fc44d661ac21cac9d3a086 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0