- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: services: ovirt-engine: replace cheetah with jinja2
by sbonazzo＠redhat.com 02 Feb '16

02 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: services: ovirt-engine: replace cheetah with jinja2 ...................................................................... packaging: services: ovirt-engine: replace cheetah with jinja2 Change-Id: I7cf4484284f846441ee455b4da441e90d6e41d04 Bug-Url: https://bugzilla.redhat.com/1267508 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M README.developer M ovirt-engine.spec.in M packaging/pythonlib/ovirt_engine/configfile.py M packaging/services/ovirt-engine/ovirt-engine-logging.properties.in M packaging/services/ovirt-engine/ovirt-engine.py M packaging/services/ovirt-engine/ovirt-engine.xml.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/notifier.py 7 files changed, 57 insertions(+), 66 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/52885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cf4484284f846441ee455b4da441e90d6e41d04 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup cmd data when compensation deleted
by emesika＠redhat.com 02 Feb '16

02 Feb '16

Eli Mesika has submitted this change and it was merged. Change subject: core: cleanup cmd data when compensation deleted ...................................................................... core: cleanup cmd data when compensation deleted This patch validates that when compensation data is deleted, the corresponding entries in the command_entities table are deleted as well. Change-Id: I8889f52a6ac44de4c1aa2b16d82c799e345a740f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303163 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner_sp.sql M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 2 files changed, 32 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8889f52a6ac44de4c1aa2b16d82c799e345a740f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: rename: Handle storage domains more nicely
by sbonazzo＠redhat.com 02 Feb '16

02 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: rename: Handle storage domains more nicely ...................................................................... packaging: rename: Handle storage domains more nicely Check all NFS, not only iso, in case data domains are also on engine. Notify user about active machines/domains on engine machine. Change-Id: I5a23ca3bb75efb23227c761b2aa4369d5828cf7f Bug-Url: https://bugzilla.redhat.com/1250556 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/domains.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py 2 files changed, 235 insertions(+), 52 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/50396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a23ca3bb75efb23227c761b2aa4369d5828cf7f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Andrew Burden <aburden(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Julie Wu <juwu(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-iso-uploader[master]: automation: add standard CI support
by sbonazzo＠redhat.com 02 Feb '16

02 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: add standard CI support ...................................................................... automation: add standard CI support Change-Id: Id52a337699b1116042ef3b4f4d02cc315463dd1f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/build-artifacts.packages A automation/build-artifacts.repos A automation/build-artifacts.sh A automation/check-merged.packages A automation/check-merged.repos A automation/check-merged.sh A automation/check-patch.packages A automation/check-patch.repos A automation/check-patch.sh 9 files changed, 58 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id52a337699b1116042ef3b4f4d02cc315463dd1f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-iso-uploader[master]: nit: fix pep8
by sbonazzo＠redhat.com 02 Feb '16

02 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: nit: fix pep8 ...................................................................... nit: fix pep8 Change-Id: Ibf6279868734fa97bfab12fce16d9a6a82cf0b60 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf6279868734fa97bfab12fce16d9a6a82cf0b60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dao: Reintroduce stream API usage in DAO classes
by mperina＠redhat.com 01 Feb '16

01 Feb '16

Martin Peřina has submitted this change and it was merged. Change subject: dao: Reintroduce stream API usage in DAO classes ...................................................................... dao: Reintroduce stream API usage in DAO classes Reintroduces stream API usage in VmDynamicDaoImpl which was removed by patch I64a396986c98ddf7640737bf4b5b9b25ad84874c to fix DAO test failures. As we upgraded Spring Framework to version 4.2, we are now able to use all Java 8 features in DAO classes. Change-Id: I27c9c28d41e72fd1219202a5b308768ca40d1a1a Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java 1 file changed, 4 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27c9c28d41e72fd1219202a5b308768ca40d1a1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: use the cluster version rather than host one
by alkaplan＠redhat.com 01 Feb '16

01 Feb '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: use the cluster version rather than host one ...................................................................... webadmin: use the cluster version rather than host one I use the cluster version rather than host one as that could lead to an NPE thrown in case tha host is newer than the engine. Change-Id: I8773775960364e83e76e226ce7b4aa24e57ea8ba Bug-Url: https://bugzilla.redhat.com/1297490 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/52926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8773775960364e83e76e226ce7b4aa24e57ea8ba Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Add support for GWT Super Dev Mode
by vszocs＠redhat.com 01 Feb '16

01 Feb '16

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Add support for GWT Super Dev Mode ...................................................................... webadmin,userportal: Add support for GWT Super Dev Mode This patch makes it possible to use Super Dev Mode to debug oVirt GWT applications (WebAdmin, UserPortal): http://www.gwtproject.org/articles/superdevmode.html For oVirt GWT applications currently based on GWT 2.6, Super Dev Mode is meant as alternative to the existing GWT debug mechanism, Classic Dev Mode a.k.a OOPHM (Out of Process Hosted Mode) based on NPAPI browser plugin: http://www.gwtproject.org/doc/latest/ DevGuideCompilingAndDebugging.html#dev_mode Key differences between Classic and Super Dev Mode: * SDM doesn't require any browser plugin * SDM uses Source Maps to map compiled JavaScript code to source Java code * with SDM, debugging hapens **in the browser** by stepping over the mapped code * SDM gives developers explicit control over when the GWT application is re-compiled -- combined with incremental compiles that take less time, this saves developer's time In general, SDM is good for "iterative" development when one changes UI code and wants to see the change reflected in the browser much more quickly (compared to CDM). On the other hand, SDM does NOT allow using Java IDE to debug UI code, so one has to rely on the browser's JavaScript developer tools. To use Super Dev Mode: 1, build Engine for development as following: $ make install-dev PREFIX="$HOME/ovirt-engine" \ DEV_BUILD_GWT_SUPER_DEV_MODE=1 2, setup & start Engine 3, start GWT code server which re-compiles the GWT application on-demand and serves its resources: $ make gwt-debug DEBUG_MODULE=webadmin \ DEV_BUILD_GWT_SUPER_DEV_MODE=1 note: upon starting, the code server compiles an initial "Chrome/English" permutation (this is SDM's default behavior) 4, visit http://127.0.0.1:9876/ and save "Dev Mode On & Off" bookmarklets in your browser 5, visit oVirt GWT application in your browser, click "Dev Mode On", then click "Compile" http://127.0.0.1:8080/ovirt-engine/webadmin/WebAdmin.html 6, open browser's developer tools (Ctrl-Shift-I), navigate to sources and put breakpoints into the mapped code 7, after making UI code changes, click "Dev Mode On" and "Compile" again to see changes applied IMPORTANT NOTE: This patch modifies the primary linker of oVirt GWT applications from 'std' to 'xsiframe': http://www.gwtproject.org/doc/latest/DevGuideLinkers.html see gwt-user-2.6.1/com/google/gwt/core/Core.gwt.xml While this change should not impact the functionality of oVirt GWT applications, it's suggested to merge the patch **only** after running UI functional tests, just to be on safe side. Change-Id: I6e03534e8af4f9c61d93bb715b80b433127cc4e8 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile M README.developer M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractXsrfProtectedRpcServlet.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/RpcRemoteOracleServlet.java A frontend/webadmin/modules/frontend/src/main/resources/META-INF/gwt-super-dev.properties M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 10 files changed, 251 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified Scott Dickerson: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e03534e8af4f9c61d93bb715b80b433127cc4e8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Improve calculation of disk actual/committed size
by amureini＠redhat.com 01 Feb '16

01 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Improve calculation of disk actual/committed size ...................................................................... core: Improve calculation of disk actual/committed size The various views containing the disk actual and committed sizes on storage domains was done by functions which performed aggregate queries, per storage domain. By converting them to joins, the calculation can be done in parallel on all the domains, like databases are supposed to be used. This patch performs the following: 1. Creates the storage_domains_image_sizes view to encapsulate the logic previously performed by the fn_get_disk_commited_value_by_storage and fn_get_actual_images_size_by_storage stored functions. 2. Remove the aforementioned functions. 3. Add some assertions to the DAO test to ensure the functionality is preserved. Change-Id: I1c76870153d55c4a4259ecaf6e9b96297f16aa72 Related-To: https://bugzilla.redhat.com/1302794 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java M packaging/dbscripts/create_functions.sql M packaging/dbscripts/create_views.sql 3 files changed, 66 insertions(+), 73 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c76870153d55c4a4259ecaf6e9b96297f16aa72 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageDomainDaoTest whitespaces
by amureini＠redhat.com 01 Feb '16

01 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainDaoTest whitespaces ...................................................................... core: StorageDomainDaoTest whitespaces Remove redundant whitespaces that hinder the code's readability instead of helping it. Change-Id: I2016afe67e31c812d3656d4ad4cd1fb46904a896 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java 1 file changed, 3 insertions(+), 21 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2016afe67e31c812d3656d4ad4cd1fb46904a896 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0