- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: StorageDomainDaoTest asserts
by amureini＠redhat.com 01 Feb '16

01 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainDaoTest asserts ...................................................................... core: StorageDomainDaoTest asserts Fixed the order the assertEquals parameters are given in order to produce an easily readable error message in case the test fails. Change-Id: I574d041cd2551c35ae5edd6e3244888e04b72d0f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I574d041cd2551c35ae5edd6e3244888e04b72d0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageDomainDaoTest literals
by amureini＠redhat.com 01 Feb '16

01 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainDaoTest literals ...................................................................... core: StorageDomainDaoTest literals Use constants from the FixturesTool class to improve the code's readability and maintainability. Note this patch should also have a [very slight] performance improvement, as it uses a pre-created Guids instead of invoking the constructor several times. Change-Id: I476ccdf32b96e15344f000c1216651ca5d3bf313 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java 1 file changed, 34 insertions(+), 41 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I476ccdf32b96e15344f000c1216651ca5d3bf313 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageDomainDaoTest members
by amureini＠redhat.com 01 Feb '16

01 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainDaoTest members ...................................................................... core: StorageDomainDaoTest members Removed a useless member. Change-Id: I7c1bb40f779df5d0f458afab23034f6267d3d1bb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c1bb40f779df5d0f458afab23034f6267d3d1bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageDomainDaoTest assertNulls
by amureini＠redhat.com 01 Feb '16

01 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainDaoTest assertNulls ...................................................................... core: StorageDomainDaoTest assertNulls executeReadList's contract specifies that when a method that returns a List has no data it returns an empty list, not a null. Thus, asserting this is wrong on several levels: 1. It represents a break in the abstraction - a unit test should only assert the behavior of the class its testing, not other classes. 2. It's pointless, as the contents of the list are always checked immediately afterwards. If the list were null, the test would just error out with a NullPointerException. This patch removes those aforementioned useless asserts. Once they are removed, the assertCorrectGetAllResult becomes a wrapper to asserting a list is not empty, so it was just inlined. Change-Id: I84ea47545ed9f4bf2375187843906da942c92d7e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java 1 file changed, 2 insertions(+), 30 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84ea47545ed9f4bf2375187843906da942c92d7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Allow branding of help url
by sbonazzo＠redhat.com 01 Feb '16

01 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Allow branding of help url ...................................................................... packaging: engine-backup: Allow branding of help url Bug-Url: https://bugzilla.redhat.com/1217405 Change-Id: I48f1da61d97a38211788d912aac11af00f6e2acb Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 29 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/52935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48f1da61d97a38211788d912aac11af00f6e2acb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: show the "latest" template only when the new VM is...
by tnisan＠redhat.com 01 Feb '16

01 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: show the "latest" template only when the new VM is stateless ...................................................................... webadmin: show the "latest" template only when the new VM is stateless It changes the behavior only for the new vm -> don't show the "latest" templates when the VM is not stateless. Change-Id: I5b2a7beeb2687521e73168d5171ef14a98185e06 Bug-Url: https://bugzilla.redhat.com/1293154 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 80 insertions(+), 19 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b2a7beeb2687521e73168d5171ef14a98185e06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: change sizes of suggest boxes
by tnisan＠redhat.com 01 Feb '16

01 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: change sizes of suggest boxes ...................................................................... webadmin: change sizes of suggest boxes Change-Id: Ibdddf508a61c36f01f54b5f6f1eab1a7a46ad92c Bug-Url: https://bugzilla.redhat.com/1293154 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdddf508a61c36f01f54b5f6f1eab1a7a46ad92c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: spagobi-dependencies: add missing deps
by sbonazzo＠redhat.com 01 Feb '16

01 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spagobi-dependencies: add missing deps ...................................................................... spagobi-dependencies: add missing deps Change-Id: Idc00a88ccd9c5a483dd81ba6a2f52efae2c2dfd3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/spagobi-dependencies/spagobi-dependencies.yaml 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc00a88ccd9c5a483dd81ba6a2f52efae2c2dfd3 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: spagobi-dependencies: new jobs
by sbonazzo＠redhat.com 01 Feb '16

01 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spagobi-dependencies: new jobs ...................................................................... spagobi-dependencies: new jobs Use releng builder until standard template is ready Change-Id: Ie2789972ffe2dca92bc2992032c9d4bad99cfeac Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/projects/spagobi-dependencies/spagobi-dependencies.yaml 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2789972ffe2dca92bc2992032c9d4bad99cfeac Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: added warning when import windows without virtio
by tnisan＠redhat.com 01 Feb '16

01 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: added warning when import windows without virtio ...................................................................... webadmin: added warning when import windows without virtio It is dangerous not to attach VirtIO driwers to windows VMs - added message to warn the user. Change-Id: Iec069ed5a5b021f0dadb594dcc7e087b00bf062c Bug-Url: https://bugzilla.redhat.com/1296593 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.ui.xml 4 files changed, 60 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Shahar Havivi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec069ed5a5b021f0dadb594dcc7e087b00bf062c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0